Morph MORPH
SIGN IN SIGN UP
SeleniumHQ / selenium UNCLAIMED

A browser automation framework and ecosystem.

34170 0 120 Java
Normal View History Raw
Moving implementation code of IE driver command handlers from headers The initial implementation of the IE driver's command handlers put the implementation for each command directly in the header files. While this works, it's not standard practice, and has led to a spaghetti-code of include statements. This takes the first step toward fixing that by moving the implementation of each command into a .cpp file, leaving the header to only contain the class definition.
2017-02-14 09:48:56 -08:00
// Licensed to the Software Freedom Conservancy (SFC) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The SFC licenses this file
// to you under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#ifndef WEBDRIVER_IE_COMMANDHANDLERREPOSITORY_H_
#define WEBDRIVER_IE_COMMANDHANDLERREPOSITORY_H_
#include <map>
#include <memory>
Cleaning up IE driver header file include statements No functional changes
2019-04-02 13:21:07 -07:00
#include <string>
Moving implementation code of IE driver command handlers from headers The initial implementation of the IE driver's command handlers put the implementation for each command directly in the header files. While this works, it's not standard practice, and has led to a spaghetti-code of include statements. This takes the first step toward fixing that by moving the implementation of each command into a .cpp file, leaving the header to only contain the class definition.
2017-02-14 09:48:56 -08:00
namespace webdriver {
// Forward declaration of classes.
class IECommandHandler;
Removing now deprecated non-standard tr1 namespace from IE driver
2018-01-30 08:32:07 -08:00
typedef std::shared_ptr<IECommandHandler> CommandHandlerHandle;
Moving implementation code of IE driver command handlers from headers The initial implementation of the IE driver's command handlers put the implementation for each command directly in the header files. While this works, it's not standard practice, and has led to a spaghetti-code of include statements. This takes the first step toward fixing that by moving the implementation of each command into a .cpp file, leaving the header to only contain the class definition.
2017-02-14 09:48:56 -08:00
class CommandHandlerRepository {
public:
CommandHandlerRepository(void);
virtual ~CommandHandlerRepository(void);
bool IsValidCommand(const std::string& command_name);
CommandHandlerHandle GetCommandHandler(const std::string& command_name);
private:
typedef std::map<std::string, CommandHandlerHandle> CommandHandlerMap;
void PopulateCommandHandlers(void);
CommandHandlerMap command_handlers_;
};
} // namespace webdriver
Removing now deprecated non-standard tr1 namespace from IE driver
2018-01-30 08:32:07 -08:00
#endif // WEBDRIVER_IE_COMMANDHANDLERREPOSITORY_H_
Reference in New Issue Copy Permalink