Morph MORPH
SIGN IN SIGN UP
SeleniumHQ / selenium UNCLAIMED

A browser automation framework and ecosystem.

34181 0 204 Java
Normal View History Raw
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
_GatheredModuleInfo = provider(
[bazel] Automatically generate java 9 modules for java_export
2019-08-16 19:05:07 +01:00
fields = {
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
"name": "Name of the module, may be `None`.",
"module_path": "depset of jars that make up the module path so far.",
"jars": "Jars to include in the module.",
"source_jars": "Source jars to include in the module.",
"java_info": "A merged JavaInfo of all the entries in `jars`.",
[bazel] Automatically generate java 9 modules for java_export
2019-08-16 19:05:07 +01:00
},
)
JavaModuleInfo = provider(
fields = {
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
"name": "Name of the module.",
"module_path": "depset of jars to include on the module path",
[bazel] Automated reformatting of build files
2020-05-14 17:30:31 +01:00
},
[bazel] Automatically generate java 9 modules for java_export
2019-08-16 19:05:07 +01:00
)
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
# In order to construct the module path, we do this:
# * `JavaModuleInfo`: use the module path from that
# * maven coordinates: add the runtime output jars to the module path
# * otherwise: just accumulate jars
_ATTR_ASPECTS = [
"deps",
"exports",
"runtime_deps",
]
def _infer_name(tags):
names = [tag[len("maven_coordinates="):] for tag in tags if tag.startswith("maven_coordinates=")]
if len(names) == 0:
return None
if len(names) > 1:
fail("Only one set of maven coordinates may be specified")
exploded = names[0].split(":")
[bazel] Automated reformatting of build files
2020-05-14 17:30:31 +01:00
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
# We want the group id and artifact id. If the artifact id begins
# with the last segment of the group id, then remove it.
groups = exploded[0].split(".")
final = groups[-1] + "-"
if exploded[1].startswith(final):
[bazel] Automated reformatting of build files
2020-05-14 17:30:31 +01:00
return (exploded[0] + "." + exploded[1][len(final):]).replace("-", "_")
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
return (exploded[0] + "." + exploded[1]).replace("-", "_")
def _java_module_aspect_impl(target, ctx):
name = _infer_name(ctx.rule.attr.tags)
all_deps = []
[all_deps.extend(getattr(ctx.rule.attr, attr, [])) for attr in _ATTR_ASPECTS]
[bazel] Automatically generate java 9 modules for java_export
2019-08-16 19:05:07 +01:00
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
all_infos = [dep[_GatheredModuleInfo] for dep in all_deps]
nameless_infos = [info for info in all_infos if not info.name]
[bazel] Automatically generate java 9 modules for java_export
2019-08-16 19:05:07 +01:00
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
jars = depset(direct = target[JavaInfo].runtime_output_jars, transitive = [info.jars for info in nameless_infos])
source_jars = depset(direct = target[JavaInfo].source_jars, transitive = [info.source_jars for info in nameless_infos])
derived = "unknown"
[bazel] Automatically generate java 9 modules for java_export
2019-08-16 19:05:07 +01:00
if JavaModuleInfo in target:
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
module_path = target[JavaModuleInfo].module_path
[build] Move bazel version to 5
2022-01-21 11:25:17 +00:00
jars = depset(target[JavaInfo].runtime_output_jars)
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
source_jars = target[JavaInfo].source_jars
java_info = target[JavaInfo]
elif name:
module_path = depset(direct = target[JavaInfo].runtime_output_jars, transitive = [info.module_path for info in all_infos])
java_info = java_common.merge([info.java_info for info in all_infos if info.name] + [target[JavaInfo]])
[bazel] Automatically generate java 9 modules for java_export
2019-08-16 19:05:07 +01:00
else:
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
module_path = depset(transitive = [info.module_path for info in all_infos])
java_info = java_common.merge([info.java_info for info in all_infos if info.name])
return [
_GatheredModuleInfo(
name = name,
module_path = module_path,
jars = jars,
source_jars = source_jars,
java_info = java_info,
[bazel] Automated reformatting of build files
2020-05-14 17:30:31 +01:00
),
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
]
_java_module_aspect = aspect(
_java_module_aspect_impl,
attr_aspects = _ATTR_ASPECTS,
[bazel] Automatically generate java 9 modules for java_export
2019-08-16 19:05:07 +01:00
required_aspect_providers = [
[JavaInfo],
],
provides = [
[bazel] Automated reformatting of build files
2020-05-14 17:30:31 +01:00
_GatheredModuleInfo,
[bazel] Automatically generate java 9 modules for java_export
2019-08-16 19:05:07 +01:00
],
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
host_fragments = [
"java",
[bazel] Automated reformatting of build files
2020-05-14 17:30:31 +01:00
],
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
)
def _java_module_impl(ctx):
name = _infer_name(ctx.attr.tags)
[bazel] Use java_export from rules_jvm_external This allows us to delete some of our own support classes and use the upstream versions instead. It is apparent we need to upstream some other changes from the javadoc generation, but this is a good starting point.
2021-01-19 16:26:51 +00:00
all_infos = [dep[_GatheredModuleInfo] for dep in ctx.attr.deps] + [dep[_GatheredModuleInfo] for dep in ctx.attr.exports]
Generate transitive javadocs more correctly
2021-03-15 14:38:42 +00:00
[build] Move bazel version to 5
2022-01-21 11:25:17 +00:00
included_jars = depset(direct = [ctx.file.target], transitive = [info.jars for info in all_infos])
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
# Now that we have a single jar, derive the module info.
all_jars = depset(transitive = [info.module_path for info in all_infos]).to_list()
module_path_jars = depset(transitive = [info.module_path for info in all_infos])
module_info_jar = ctx.actions.declare_file("%s-module-info.jar" % ctx.attr.name)
args = ctx.actions.args()
args.add_all(["--module-name", name])
[bazel] Use java_export from rules_jvm_external This allows us to delete some of our own support classes and use the upstream versions instead. It is apparent we need to upstream some other changes from the javadoc generation, but this is a good starting point.
2021-01-19 16:26:51 +00:00
args.add_all(["--in", ctx.file.target])
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
args.add_all(["--output", module_info_jar])
args.add_all(ctx.attr.hides, before_each = "--hides")
args.add_all(ctx.attr.uses, before_each = "--uses")
args.add_all(module_path_jars, before_each = "--module-path")
[bazel] Allow packages to be opened in modules
2021-01-25 11:48:02 +00:00
args.add_all(ctx.attr.opens_to, before_each = "--open-to")
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
ctx.actions.run(
executable = ctx.executable._module_generator,
outputs = [module_info_jar],
[bazel] Use java_export from rules_jvm_external This allows us to delete some of our own support classes and use the upstream versions instead. It is apparent we need to upstream some other changes from the javadoc generation, but this is a good starting point.
2021-01-19 16:26:51 +00:00
inputs = depset([ctx.file.target], transitive = [info.module_path for info in all_infos]),
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
arguments = [args],
)
# Now merge the input jars and the module info into a single unit.
# Bazel's singlejar strips the manifest of all useful information,
# which is suboptimal, so we don't use that.
module_jar = ctx.actions.declare_file("lib%s.jar" % ctx.attr.name)
args = ctx.actions.args()
[bazel] Use java_export from rules_jvm_external This allows us to delete some of our own support classes and use the upstream versions instead. It is apparent we need to upstream some other changes from the javadoc generation, but this is a good starting point.
2021-01-19 16:26:51 +00:00
args.add_all(["--sources", ctx.file.target])
args.add_all(["--sources", module_info_jar])
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
args.add_all(["--output", module_jar])
ctx.actions.run(
executable = ctx.executable._merge_jars,
outputs = [module_jar],
[bazel] Use java_export from rules_jvm_external This allows us to delete some of our own support classes and use the upstream versions instead. It is apparent we need to upstream some other changes from the javadoc generation, but this is a good starting point.
2021-01-19 16:26:51 +00:00
inputs = [
module_info_jar,
ctx.file.target,
],
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
arguments = [args],
)
# Generate the ijar
compile_jar = java_common.run_ijar(
actions = ctx.actions,
jar = module_jar,
target_label = ctx.label,
java_toolchain = ctx.attr._java_toolchain[java_common.JavaToolchainInfo],
)
# Create the merged source jar
src_jar = java_common.pack_sources(
actions = ctx.actions,
Generate transitive javadocs more correctly
2021-03-15 14:38:42 +00:00
output_source_jar = ctx.actions.declare_file("lib%s-src.jar" % ctx.attr.name),
source_jars = depset(
[build] Move bazel version to 5
2022-01-21 11:25:17 +00:00
direct = ctx.attr.target[JavaInfo].source_jars,
[bazel] Run buildifier. No logical changes. Command invocation was: buildifier -r -lint fix -type auto .
2021-04-24 22:07:28 +01:00
transitive = [info.source_jars for info in all_infos if not info.name],
).to_list(),
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
java_toolchain = ctx.attr._java_toolchain[java_common.JavaToolchainInfo],
)
# TODO: This JavaInfo needs to have the JavaInfos of all jars included in module stripped
java_info = JavaInfo(
output_jar = module_jar,
source_jar = src_jar,
compile_jar = compile_jar,
deps = [info.java_info for info in all_infos],
exports = [ex[JavaInfo] for ex in ctx.attr.exports],
[bazel] Automated reformatting of build files
2020-05-14 17:30:31 +01:00
runtime_deps = [dep[JavaInfo] for dep in ctx.attr.deps],
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
)
return [
Generate a Maven BOM (#11560)
2023-02-07 15:33:44 +00:00
DefaultInfo(files = depset([module_jar])),
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
JavaModuleInfo(
name = name,
[bazel] Automated reformatting of build files
2020-05-14 17:30:31 +01:00
module_path = depset(direct = [module_jar], transitive = [info.module_path for info in all_infos]),
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
),
[bazel] Make sure maven artifacts use generated modules
2021-01-25 16:02:47 +00:00
OutputGroupInfo(
module_jar = [module_jar],
module_source = [src_jar],
_source_jars = [src_jar],
),
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
java_info,
]
java_module = rule(
_java_module_impl,
attrs = {
[bazel] Use java_export from rules_jvm_external This allows us to delete some of our own support classes and use the upstream versions instead. It is apparent we need to upstream some other changes from the javadoc generation, but this is a good starting point.
2021-01-19 16:26:51 +00:00
"target": attr.label(
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
mandatory = True,
[bazel] Use java_export from rules_jvm_external This allows us to delete some of our own support classes and use the upstream versions instead. It is apparent we need to upstream some other changes from the javadoc generation, but this is a good starting point.
2021-01-19 16:26:51 +00:00
allow_single_file = True,
providers = [
[_GatheredModuleInfo, JavaInfo],
],
aspects = [
_java_module_aspect,
],
),
"deps": attr.label_list(
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
providers = [
[_GatheredModuleInfo],
],
aspects = [
_java_module_aspect,
],
),
"exports": attr.label_list(
providers = [
[bazel] Use java_export from rules_jvm_external This allows us to delete some of our own support classes and use the upstream versions instead. It is apparent we need to upstream some other changes from the javadoc generation, but this is a good starting point.
2021-01-19 16:26:51 +00:00
[_GatheredModuleInfo, JavaInfo],
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
],
[bazel] Use java_export from rules_jvm_external This allows us to delete some of our own support classes and use the upstream versions instead. It is apparent we need to upstream some other changes from the javadoc generation, but this is a good starting point.
2021-01-19 16:26:51 +00:00
aspects = [
Run buildifier over build and bzl files
2021-02-09 21:15:38 +00:00
_java_module_aspect,
],
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
),
"hides": attr.string_list(
doc = "List of package names to hide",
default = [],
),
[bazel] Allow packages to be opened in modules
2021-01-25 11:48:02 +00:00
"opens_to": attr.string_list(
doc = "List of modules this module is open to",
default = [],
),
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
"uses": attr.string_list(
doc = "List of classnames that the module uses",
[bazel] Automated reformatting of build files
2020-05-14 17:30:31 +01:00
default = [],
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
),
"_javabase": attr.label(
Run buildifier. No logical changes `buildifier --lint fix -r .`
2022-08-09 19:15:01 +01:00
cfg = "exec",
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
default = "@bazel_tools//tools/jdk:current_java_runtime",
providers = [java_common.JavaRuntimeInfo],
),
"_java_toolchain": attr.label(
default = "@bazel_tools//tools/jdk:current_java_toolchain",
),
"_merge_jars": attr.label(
Bump rules_jvm_external to 5.1
2023-03-22 10:01:26 +00:00
default = "@rules_jvm_external//private/tools/java/com/github/bazelbuild/rules_jvm_external/jar:MergeJars",
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
executable = True,
Run buildifier. No logical changes `buildifier --lint fix -r .`
2022-08-09 19:15:01 +01:00
cfg = "exec",
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
),
"_module_generator": attr.label(
Move java sources and tests into a single tree (#9710) This emphasizes that all the java code is inter-related. We make use of bazel to avoid introducing Java 8 incompatible changes, and bazel's visibility rules to ensure that generated jars only contain what they should.
2021-08-03 17:39:24 +03:00
default = "//java/src/dev/selenium/tools/modules:ModuleGenerator",
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
executable = True,
Run buildifier. No logical changes `buildifier --lint fix -r .`
2022-08-09 19:15:01 +01:00
cfg = "exec",
[bazel] Rework how we generate java modules This allows us to better express what goes into a module, and to tweak the module definition more easily. Note: this change has broken maven exports, and generating dist-zips. These will be repaired in a forthcoming PR.
2020-01-01 13:19:35 +00:00
),
},
[bazel] Bump to 7.1.0 without bzlmod (#13713)
2024-03-21 18:33:29 +00:00
toolchains = ["@bazel_tools//tools/jdk:toolchain_type"],
[bazel] Automatically generate java 9 modules for java_export
2019-08-16 19:05:07 +01:00
)
Reference in New Issue Copy Permalink