Morph MORPH
SIGN IN SIGN UP
SeleniumHQ / selenium UNCLAIMED

A browser automation framework and ecosystem.

0 0 1232 Java
Normal View History Raw
Setting up bazel build rules for javascript stuff. I've covered most of the major stuff (excluding selenium-core). The closure bazel build rules are really strict and our code has hundreds of errors, so I've configured everything to suppress warnings; we can clean up later. There's one exception in selenium-atoms/text.js, where the build caught a reference to a variable that doesn't exist anymore - since I happened to notice that warning in particular, I went ahead and fixed it. With this change, I can `bazel build //javascript/...` using: $ bazel version Starting local Bazel server and connecting to it... Build label: 0.24.1 Build target: bazel-out/k8-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar Build time: Tue Apr 2 16:29:26 2019 (1554222566) Build timestamp: 1554222566 Build timestamp as int: 1554222566
2019-04-30 11:18:59 -07:00
load("@io_bazel_rules_closure//closure:defs.bzl", "closure_js_binary", "closure_js_library")
Issue 12549 fix atoms generation lowdash (#15247) * Updating the atom frament bazel file so that "_" is not used as the exported function, also passing in entire window so that all pieces should have access to what they need. * Added the exported function name to the string substitution list. Atoms build now. * Properly adding the exported function variable to the wrapper. * Updated exported symbol to relate to selenium for namespacing purposes, updating single quotes to to double for linting check. --------- Co-authored-by: Sri Harsha <12621691+harsha509@users.noreply.github.com> Co-authored-by: David Burns <david.burns@theautomatedtester.co.uk>
2025-03-11 14:36:50 -04:00
EXPORT_FUNCTION_NAME = "se_exportedFunctionSymbol"
Setting up bazel build rules for javascript stuff. I've covered most of the major stuff (excluding selenium-core). The closure bazel build rules are really strict and our code has hundreds of errors, so I've configured everything to suppress warnings; we can clean up later. There's one exception in selenium-atoms/text.js, where the build caught a reference to a variable that doesn't exist anymore - since I happened to notice that warning in particular, I went ahead and fixed it. With this change, I can `bazel build //javascript/...` using: $ bazel version Starting local Bazel server and connecting to it... Build label: 0.24.1 Build target: bazel-out/k8-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar Build time: Tue Apr 2 16:29:26 2019 (1554222566) Build timestamp: 1554222566 Build timestamp as int: 1554222566
2019-04-30 11:18:59 -07:00
def _internal_closure_fragment_export_impl(ctx):
ctx.actions.write(
output = ctx.outputs.out,
content = """
goog.require('%s');
Issue 12549 fix atoms generation lowdash (#15247) * Updating the atom frament bazel file so that "_" is not used as the exported function, also passing in entire window so that all pieces should have access to what they need. * Added the exported function name to the string substitution list. Atoms build now. * Properly adding the exported function variable to the wrapper. * Updated exported symbol to relate to selenium for namespacing purposes, updating single quotes to to double for linting check. --------- Co-authored-by: Sri Harsha <12621691+harsha509@users.noreply.github.com> Co-authored-by: David Burns <david.burns@theautomatedtester.co.uk>
2025-03-11 14:36:50 -04:00
goog.exportSymbol('%s', %s);
""" % (ctx.attr.module, EXPORT_FUNCTION_NAME, ctx.attr.function),
Setting up bazel build rules for javascript stuff. I've covered most of the major stuff (excluding selenium-core). The closure bazel build rules are really strict and our code has hundreds of errors, so I've configured everything to suppress warnings; we can clean up later. There's one exception in selenium-atoms/text.js, where the build caught a reference to a variable that doesn't exist anymore - since I happened to notice that warning in particular, I went ahead and fixed it. With this change, I can `bazel build //javascript/...` using: $ bazel version Starting local Bazel server and connecting to it... Build label: 0.24.1 Build target: bazel-out/k8-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar Build time: Tue Apr 2 16:29:26 2019 (1554222566) Build timestamp: 1554222566 Build timestamp as int: 1554222566
2019-04-30 11:18:59 -07:00
)
_internal_closure_fragment_export = rule(
implementation = _internal_closure_fragment_export_impl,
attrs = {
"function": attr.string(mandatory = True),
"module": attr.string(mandatory = True),
},
outputs = {"out": "%{name}.js"},
)
def _closure_fragment_impl(ctx):
defs = ctx.attr.defines + [
"goog.userAgent.ASSUME_MOBILE_WEBKIT=true",
"goog.userAgent.product.ASSUME_ANDROID=true",
]
def closure_fragment(
name,
module,
function,
browsers = None,
**kwargs):
if browsers == None:
browsers = []
if type(browsers) != "list":
fail("browsers must be None or a list of strings")
exports_file_name = "_%s_exports" % name
_internal_closure_fragment_export(
name = exports_file_name,
module = module,
function = function,
)
exports_lib_name = "%s_lib" % exports_file_name
closure_js_library(
name = exports_lib_name,
srcs = [exports_file_name],
deps = kwargs.get("deps", []),
)
# Wrap the output in two functions. The outer function ensures the
# compiled fragment never pollutes the global scope by using its
[atoms] Update fragment.bzl to fix a bug where "_" was overwritten (#12704) * Update fragment.bzl to fix bug where "_" was overwritten Update fragment.bzl to fix bug where "_" was overwritten * Update fragment.bzl (full revert) Update fragment.bzl (full revert)
2023-09-14 09:53:44 -04:00
# own scope on each invocation. We must import window.navigator into
# this unique scope since Closure's goog.userAgent package assumes
# navigator and document are defined on goog.global. Normally, this
# would be window, but we are explicitly defining the fragment so that
# goog.global is _not_ window.
# See http://code.google.com/p/selenium/issues/detail?id=1333
Setting up bazel build rules for javascript stuff. I've covered most of the major stuff (excluding selenium-core). The closure bazel build rules are really strict and our code has hundreds of errors, so I've configured everything to suppress warnings; we can clean up later. There's one exception in selenium-atoms/text.js, where the build caught a reference to a variable that doesn't exist anymore - since I happened to notice that warning in particular, I went ahead and fixed it. With this change, I can `bazel build //javascript/...` using: $ bazel version Starting local Bazel server and connecting to it... Build label: 0.24.1 Build target: bazel-out/k8-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar Build time: Tue Apr 2 16:29:26 2019 (1554222566) Build timestamp: 1554222566 Build timestamp as int: 1554222566
2019-04-30 11:18:59 -07:00
wrapper = (
"function(){" +
Issue 12549 fix atoms generation lowdash (#15247) * Updating the atom frament bazel file so that "_" is not used as the exported function, also passing in entire window so that all pieces should have access to what they need. * Added the exported function name to the string substitution list. Atoms build now. * Properly adding the exported function variable to the wrapper. * Updated exported symbol to relate to selenium for namespacing purposes, updating single quotes to to double for linting check. --------- Co-authored-by: Sri Harsha <12621691+harsha509@users.noreply.github.com> Co-authored-by: David Burns <david.burns@theautomatedtester.co.uk>
2025-03-11 14:36:50 -04:00
"return (function(){%output%; return this." + EXPORT_FUNCTION_NAME + ".apply(null,arguments);}).apply(window, arguments);}"
Setting up bazel build rules for javascript stuff. I've covered most of the major stuff (excluding selenium-core). The closure bazel build rules are really strict and our code has hundreds of errors, so I've configured everything to suppress warnings; we can clean up later. There's one exception in selenium-atoms/text.js, where the build caught a reference to a variable that doesn't exist anymore - since I happened to notice that warning in particular, I went ahead and fixed it. With this change, I can `bazel build //javascript/...` using: $ bazel version Starting local Bazel server and connecting to it... Build label: 0.24.1 Build target: bazel-out/k8-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar Build time: Tue Apr 2 16:29:26 2019 (1554222566) Build timestamp: 1554222566 Build timestamp as int: 1554222566
2019-04-30 11:18:59 -07:00
)
browser_defs = {
"*": [],
"android": [
"--define=goog.userAgent.ASSUME_MOBILE_WEBKIT=true",
"--define=goog.userAgent.product.ASSUME_ANDROID=true",
],
"chrome": [
"--define=goog.userAgent.ASSUME_WEBKIT=true",
"--define=goog.userAgent.product.ASSUME_CHROME=true",
Additional closure compiler flags for ChromeDriver (#8245) Adding a couple of command line flags to closure compiler while generating atoms for ChromeDriver: * --define=goog.NATIVE_ARRAY_PROTOTYPES=false: This flag used to be present before migration to Bazel. Its removal caused ChromeDriver bugs, such as https://crbug.com/chromedriver/3422 and https://crbug.com/chromedriver/3439. * --use_types_for_optimization=false: Works around closure compiler bugs. This used to be added by hand when the ChromeDriver team built atoms. Co-authored-by: David Burns <david.burns@theautomatedtester.co.uk>
2020-04-27 00:56:47 -07:00
"--define=goog.NATIVE_ARRAY_PROTOTYPES=false",
"--use_types_for_optimization=false",
Setting up bazel build rules for javascript stuff. I've covered most of the major stuff (excluding selenium-core). The closure bazel build rules are really strict and our code has hundreds of errors, so I've configured everything to suppress warnings; we can clean up later. There's one exception in selenium-atoms/text.js, where the build caught a reference to a variable that doesn't exist anymore - since I happened to notice that warning in particular, I went ahead and fixed it. With this change, I can `bazel build //javascript/...` using: $ bazel version Starting local Bazel server and connecting to it... Build label: 0.24.1 Build target: bazel-out/k8-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar Build time: Tue Apr 2 16:29:26 2019 (1554222566) Build timestamp: 1554222566 Build timestamp as int: 1554222566
2019-04-30 11:18:59 -07:00
],
"ie": [
"--define=goog.userAgent.ASSUME_IE=true",
],
"ios": [
"--define=goog.userAgent.ASSUME_MOBILE_WEBKIT=true",
],
"firefox": [
"--define=goog.userAgent.ASSUME_GECKO=true",
"--define=goog.userAgent.product.ASSUME_FIREFOX=true",
],
}
for browser, defs in browser_defs.items():
if len(browsers) > 0 and (browser == "*" or browser not in browsers):
continue
bin_name = name
if browser != "*":
bin_name = bin_name + "-" + browser
closure_js_binary(
name = bin_name,
deps = [":" + exports_lib_name],
defs = kwargs.get("defs", []) + defs,
output_wrapper = wrapper,
visibility = kwargs.get("visibility"),
)
Reference in New Issue Copy Permalink