nowinandroid/.github/pull_request_template.md at main

mirror of https://github.com/android/nowinandroid.git synced 2026-04-01 17:07:15 +00:00

Files

Aurimas 5ba16edde9 Apply spotless by default (#2055 )

* Apply spotless by default

- Upgrades to spotless 8.2.1
- Moves spotless setup from an init.gradle.kts to build-logic
- Narrows down the scope of `target` in spotless configuration to
  be more precise to workaround https://github.com/diffplug/spotless/issues/2717
- Updates all references to init.gradle.kts

Ran gradle-profiler ./gradlew build --dry-run to validate performance
impact.
Before PR:
Mean 10,527.96 ms with 289.01 ms std dev
After PR:
Mean 11,251.78 ms with 530.29 ms std dev

Regression is there, but quite minor.

Test: ./gradlew spotlessCheck

* Address comments from AI overlords

* Fix usage of rootProject

* Enable spotless for build-logic via root project

2026-01-30 09:17:35 -08:00

902 B

Raw Permalink Blame History

DO NOT CREATE A PULL REQUEST WITHOUT READING THESE INSTRUCTIONS

Instructions

Thanks for submitting a pull request. To accept your pull request we need you do a few things:

If this is your first pull request

Sign the contributors license agreement

Ensure tests pass and code is formatted correctly

Run local tests on the DemoDebug variant by running ./gradlew testDemoDebug
Fix code formatting: ./gradlew spotlessApply

Add a description

We need to know what you've done and why you've done it. Include a summary of what your pull request contains, and why you have made these changes. Include links to any relevant issues which it fixes.

Here's an example.

NOW DELETE THIS LINE AND EVERYTHING ABOVE IT

What I have done and why

902 B Raw Permalink Blame History

Instructions

902 B

Raw Permalink Blame History