SIGN IN SIGN UP
apache / airflow UNCLAIMED

Apache Airflow - A platform to programmatically author, schedule, and monitor workflows

0 0 0 Python

Upgrade to latest ruff and remove ISC001 warning from output (#36649)

This PR upgrades to latest ruff, and removes the ISC001 warning that
warns us against potential conflict between ruff and ruff-formatter
when two strings in one line get concatenated.

This warning makes sense if you run both ruff and formatting at the
same time, but in our case we are doing it in two separate
steps - one step is to run ruff linting and the second step is to
run formatting and running formatting already runs after linting
is complete.

This warnign is pretty misleading as it distracts from real formatting
issues you might have.

There is - unfortunately - no standard way to remove the warning
so we have to do it a little "around" - rather than running
the pre-commit directly from ruff website, we run our local pre-commit
with few lines of Python code that runs ruff through shell and
greps out the ISC001 warning. We also force color to make
sure the output is still coloured.
J
Jarek Potiuk committed
11c46fd2ec165da32202b464be7c2df5cca4d6c0
Parent: 579c4b5
Committed by GitHub <noreply@github.com> on 1/7/2024, 7:02:08 PM