2014-04-05 12:20:07 -04:00
## Process used by committers to review and submit patches
2015-02-04 16:43:26 +01:00
1. Make sure that there is an issue for the patch(s) you are about to commit in our [Jira issue tracker ](http://issues.apache.org/jira/browse/THRIFT )
2014-04-05 12:20:07 -04:00
1. Check out the latest version of the source code
2015-02-04 16:43:26 +01:00
2018-12-27 23:57:35 +08:00
* git clone https://github.com/apache/thrift.git thrift
2014-04-05 12:20:07 -04:00
1. Apply the patch
2015-02-04 16:43:26 +01:00
* curl https://issues.apache.org/jira/... |git apply --ignore-space-change
or
* curl https://github.com/<GitHub User>/thrift/commit/<Commit ID>.patch |git apply --ignore-space-change
2014-04-05 12:20:07 -04:00
1. Inspect the applied patch to ensure that all [Legal aspects on Submission of Contributions (Patches) ](http://www.apache.org/licenses/LICENSE-2.0.html#contributions ) are met
2020-11-06 11:33:40 +01:00
1. Run the necessary unit tests and cross-language test cases to verify the patch
2014-04-05 12:20:07 -04:00
1. Commit the patch
2015-02-04 16:43:26 +01:00
git --config user.name "Your Name"
git --config user.email "YourApacheID@apache .org"
git add -A
git commit
2014-04-05 12:20:07 -04:00
1. The commit message should be in the format:
2015-02-04 16:43:26 +01:00
2019-09-22 11:04:07 +02:00
THRIFT-####: <Jira description>
2015-02-04 16:43:26 +01:00
Client: <component>
Patch: <Name of person contributing the patch>
Description of what was fixed or addressed.
2020-11-06 11:33:40 +01:00
If this is a github pull request then add the below comment to automatically close the GitHub request,
2019-09-22 11:04:07 +02:00
where #NNNN is the PR number:
This closes #NNNN
2014-04-05 12:20:07 -04:00
1. Double check the patch committed and that nothing was missed then push the patch
2015-02-04 16:43:26 +01:00
git status
git show HEAD
git push origin master
2014-04-05 12:20:07 -04:00
2020-11-06 11:33:40 +01:00
1. Resolve the Jira issue and set the following for the changelog
2014-04-05 12:20:07 -04:00
2015-02-04 16:43:26 +01:00
* Component the patch is for
* fixVersion to the current version on master
