Morph MORPH
SIGN IN SIGN UP
cefsharp / CefSharp UNCLAIMED

.NET (WPF and Windows Forms) bindings for the Chromium Embedded Framework

0 0 0 C#
Normal View History Raw
Maintenance - Fixed formatting, file encoding, and copyright year (#2504) * Applied formatting * Fixed file encoding + Updated copyright year * Updated License * Fixed more file encoding * Copyright notice now shows the year the file was created
2018-09-10 02:41:13 +02:00
// Copyright © 2014 The CefSharp Authors. All rights reserved.
Move CefAppUnmanagedWrapper into it's own class (.cpp and .h)
2014-08-29 10:53:50 +10:00
//
// Use of this source code is governed by a BSD-style license that can be found in the LICENSE file.
Maintenance - Fixed formatting, file encoding, and copyright year (#2504) * Applied formatting * Fixed file encoding + Updated copyright year * Updated License * Fixed more file encoding * Copyright notice now shows the year the file was created
2018-09-10 02:41:13 +02:00
Move CefAppUnmanagedWrapper into it's own class (.cpp and .h)
2014-08-29 10:53:50 +10:00
#pragma once
#include "Stdafx.h"
Rename CefSubprocessWrapper.h to CefBrowserWrapper.h
2014-09-12 00:40:33 +10:00
#include "CefBrowserWrapper.h"
Move CefAppUnmanagedWrapper into it's own class (.cpp and .h)
2014-08-29 10:53:50 +10:00
#include "CefAppUnmanagedWrapper.h"
Implement Javascript Binding v2 (#2247) * JSB Rewrite - Add CefSharp.RegisterBoundObject javascript method To get around the problem of IPC timing, I've reversed the communication, now it's the render process requesting the bound objects, the implementation is incomplete at this stage, more just a basic proof of concept Rewrite BindingTest.html using QUnit One of the tests doesn't map correctly as it requires def user interaction TODO: - Get objects by name - Rename Messages.h values that relate to this change so they are more descriptive - Better error handling - Caching of objects within a render process - Investigate global context options, don't think it's possible to call an async method directly in the global context # Conflicts: # CefSharp.Example/Resources/BindingTest.html * JSB Improve Request/Response message names * BindingTest.html - Output stress test results * Remove JavascriptRootObject was leftover from time we used WCF to transmit objects * JavascriptObjectRepository - Objects are now sent in the same list with an IsAsync flag Separation when sending over IPC with two unique lists isn't necessary * JavascriptObjectRepository - Return objects by name or return all by default Untabify CefAppUnmanagedWrapper.cpp Add minor comment to CefBrowserWrapper for a reminder that we use Frame Identifier as dictionary key * Add //TODO: JSB comments for work that's left to be done Ideally within a render process we cache bound objects once they've been communicated, It would also be nice to make multiple binding requests so objects can later be added dynamically * JSB Allow multiple calls to CefSharp.RegisterBoundObject Update BindingTest.html to name two distinct calls to different bound objects * JSB - Add some notes about caching, no working implementation yet * JSB - Dynamically Register object on Request * JSB Add ability to unbind an object and rename RegisterBoundObject to BindObjectAsync # Conflicts: # CefSharp.Example/Resources/BindingTest.html * JSB BindObjectAsync - if objects already bound then return false * JSB - Ignore Indexer properties Were previously throwing an exception * JSB - Add LegacyJavascriptBindingEnabled option so preserve existing behaviour This is only useful for SPA application and those that only navigate to pages hosting within a single domain. Any sort of cross-site navigation and a new render process will be spawned and objects won't be bound automatically (You can use the new methods to request they're bound yourself, at least in theory, more testing required on this) * Add LegacyBindingTest.html Current disabled by default. To enable uncomment CefSharpSettings.LegacyJavascriptBindingEnabled = true; in CefExample.cs * RegisterJsObject and RegisterAsyncJsObject can now only be used when CefSharpSettings.LegacyJavascriptBindingEnabled = true See https://github.com/cefsharp/CefSharp/issues/2246 for details
2018-01-22 10:24:25 +10:00
#include "RegisterBoundObjectHandler.h"
CefSharp.BindObjectAsync - Split out into it's own Handler - Add BindObjectAsyncHandler - Remove unneeded params from RegisterBoundObjectHandler
2019-07-08 13:47:22 +10:00
#include "BindObjectAsyncHandler.h"
Add CefSharp.PostMessage (#2799) - JavascriptMessageReceived event added to ChromiumWebBrowser/IWebBrowser - CefSharp.PostMessage and cefSharp.postMessage added to V8Context on creation for use in Javascript - Add PostMessageTest.html
2019-06-03 21:08:03 +10:00
#include "JavascriptPostMessageHandler.h"
Remove redundant #include statements Fix incorrect #include statements
2014-11-27 20:57:11 +10:00
#include "JavascriptRootObjectWrapper.h"
Core - Add EvaluateScriptAsPromiseAsync (#3251) - Add useImmediatelyInvokedFuncExpression param to EvaluateScriptAsync which wraps the script in an IIFE with the cefSharpInternalCallbackId variable defined in scope to allow for deferred completion - Wrap script in Immediately Invoked Function Expression and call promise.resolve to guarantee a promise. - Return 'CefSharpDefEvalScriptRes' as the result of the js function to defer execution of the callback - Call newly added cefSharp.sendEvalScriptResponse method in javascript when promise has been resolved/rejected This is built up of a few parts and can technically be used by the new user to defer the response until they are ready. Just return `'CefSharpDefEvalScriptRes'` and manually call cefSharp.sendEvalScriptResponse using the cefSharpInternalCallbackId variable which is injected into the script execution (wrapped in an IIFE to limit scope)
2020-10-06 15:19:37 +10:00
#include "JavascriptPromiseHandler.h"
Enhancement - Improve Promise support (#4326) * Enhancement - Improved promise support Resolves #4276
2022-12-06 14:54:19 +10:00
#include "JavascriptPromiseResolverCatch.h"
#include "JavascriptPromiseResolverThen.h"
Add Initial IRenderProcessHandler.OnContextCreated/Released implementation (#2697) * WinForms/WPF - Dispose of IFrame after calling LoadUrl * BrowserProcess - Add initial implementation of IRenderProcessHandler.OnContextCreated/OnContextReleased - IV8Context.Execute is the only method to be implemented so far (execute script without returning a result) - Wrappers for CefFrame and CefBrowser have yet to be imported yet, still need to determine if they should be included individually or reference to CefSharp.Core added * BrowserProcess - Add wrappers for Browser and Frame Ultimately we should probably remove the CefSharp.BrowserSubprocess.Core project and move all the code into a folder/namespace within CefSharp.Core This would allow us to share the a lot of existing code, major refactor required * CefSharp.Common.props - Add CefSharpBrowserProcessCore32/64 properties Make creating your own custom browser process easier * BrowserProcess - Remove example and add comments about creating your own custom version
2019-03-20 20:33:10 +10:00
#include "Async\JavascriptAsyncMethodCallback.h"
For now simplify message handing - remove delegates Will look at implementing a managed class to handle/route messages later
2015-06-29 15:08:53 +10:00
#include "Serialization\V8Serialization.h"
normal bound objects transfered with cef ipc as well
2015-08-06 10:25:33 +02:00
#include "Serialization\JsObjectsSerialization.h"
Add Initial IRenderProcessHandler.OnContextCreated/Released implementation (#2697) * WinForms/WPF - Dispose of IFrame after calling LoadUrl * BrowserProcess - Add initial implementation of IRenderProcessHandler.OnContextCreated/OnContextReleased - IV8Context.Execute is the only method to be implemented so far (execute script without returning a result) - Wrappers for CefFrame and CefBrowser have yet to be imported yet, still need to determine if they should be included individually or reference to CefSharp.Core added * BrowserProcess - Add wrappers for Browser and Frame Ultimately we should probably remove the CefSharp.BrowserSubprocess.Core project and move all the code into a folder/namespace within CefSharp.Core This would allow us to share the a lot of existing code, major refactor required * CefSharp.Common.props - Add CefSharpBrowserProcessCore32/64 properties Make creating your own custom browser process easier * BrowserProcess - Remove example and add comments about creating your own custom version
2019-03-20 20:33:10 +10:00
#include "Wrapper\V8Context.h"
#include "Wrapper\Frame.h"
#include "Wrapper\Browser.h"
Refactor CefSharp.Core into CefSharp.Core.Runtime (#3311) * Net Core - Rename CefSharp.Core.dll to CefSharp.Core.Runtime.dll Partial rename, only Net Core, folder not renamed * Net Core - Rename CefSharp.Core.RefAssembly to CefSharp.Core.netcore Remove GenApi * Core - Rename CefDragDataWrapper to DragData Move into CefSharp.Core namespace * WinForms/WPF/OffScreen - Migrate from GitLink command line to Nuget package * Net Core - Refactor to have CefSharp.Core.dll contain only public Api * Net Core - Remove CefSharp.Core.RefAssembly * Net Core - Change CefSharp.Core.netcore output folder * Net Core - Restructure nuget packages * Net Core - Add Cefsharp.Core.Runtime.RefAssembly * Net Core - Hide CLI/C++ classes from intellisense Make sure users don't attempt to load them directly * Rename CefSharp.Core to CefSharp.Core.Runtime * Core - Restructure Net 4.5.2 packages to use CefSharp.Core.dll anycpu variant Attempt to load CefSharp.Core.Runtime at runtime rather than having to use msbuild to copy the correct version * Rename CefSharp.Core.netcore to CefSharp.Core * WPF/WinForms/OffScreen - Change from x86/64 to AnyCPU As they are all managed assemblies they can target AnyCPU. Includes CefSharp.dll * Convert RequestContextBuilder from C++ to C# Now part of the CefSharp.Core PublicApi * Update version number to 87.1.11 * Migrate more of the public Api to C# * Net Core - Basic restructure complete * Net Core - ModuleInitializer (Doesn't work yet) * Remove direct references to BrowserSettings * Net Core - ModuleInitializer load CefShar.Core.Runtime.dl * Net Core - Load libcef.dll via CLR Module initializer If no RID is specified then we can load libcef.dll using the module initializer * Add version to CefSharp.Core * Remove dependency on CefSharp.Core.Runtime Rewrite common targets * AnyCPU app.config transform Improve AnyCPU support * Improve Net Core 3 support Only delete CefSharp.Core.Runtime.dll when AnyCPU * Nuget - Add CefSharp.Core.Runtime reference when TargetFramework = NetCore * Fix Typos Based on #3306 * Net Core - Rename CefSharp.Core.Runtime RefAssembly source file * Net Full - Generate CefSharp.Core.Runtime Ref Assembly For now the powershell build script generates the .cs file based on a x86 release build.ps1 It's not possible to directly install GenApi as it requires a Sdk style project * Net Core - Old packages copy files to required folders * Test - Install newer .Net Compiler and set Lang Version to 7.3 * Net Core - Exclude Net 452 Runtime generated reference source * Core - Add Refactoring TODO * Ref Assembly - Generate source as part of build - Move ref assembly source generate into GenerateRefAssemblySource.ps1 - Call before project build Runs locally, see if Appveyor has a problem with the powershell script execution * Core - Add more factory methods to create instances of managed wrappers * Net Core - Make Initialzier properties internal Not quite sure what the public API should look like as yet, so making internal for now.
2020-12-16 10:47:34 +10:00
#include "..\CefSharp.Core.Runtime\Internals\Messaging\Messages.h"
#include "..\CefSharp.Core.Runtime\Internals\Serialization\Primitives.h"
Javascript Binding - Finalize JavascriptBindingApiAllowOrigins: Per-browser isolation and origin normalization (#5218) * Javascript Binding - Add Ability to limit origins * Move JS binding settings to CefBrowserWrapper and optimize origin validation * Initialize origins to null * Normalize allowed origins * Optimize origin validation * Add null check for origin compare * Fix JavaScript Binding API settings for popups Move the JS binding API configuration block out of the !browser->IsPopup() scope in OnBrowserCreated. This ensures that IsJavascriptBindingApiAllowed() enforces configured restrictions for popups as well. * Fix possible null deref for JavascriptBindingApiAllowOrigins In IsJavascriptBindingApiAllowed, added a null check for JavascriptBindingApiAllowOrigins to prevent a potential null dereference if JavascriptBindingApiHasAllowOrigins is true but the allowOrigins list itself was null. * Simplify origin normalization and add null check * Add more test cases * Refactor IsJavascriptBindingApiAllowed signature Refactored IsJavascriptBindingApiAllowed to accept a CefBrowserWrapper^ parameter directly, eliminating redundant lookups and improving clarity. Updated all call sites to pass the browser wrapper explicitly. * Clarify summary for HasJavascriptBindingApiAllowOrigins Clarify documentation for HasJavascriptBindingApiAllowOrigins method to specify zero or more origins * Simplify origin comparison logic in CefAppUnmanagedWrapper Refactored code to directly compare wide string origins using _wcsicmp, removing unnecessary pointer casts and null checks. This streamlines the logic and improves readability. * Add tests for JavaScript binding API behavior across cross-origin navigation --------- Co-authored-by: amaitland <307872+amaitland@users.noreply.github.com> Co-authored-by: Luca Sonntag <luca.sonntag@cgm.com>
2026-03-21 22:35:54 +01:00
#include <include/cef_parser.h>
Move CefAppUnmanagedWrapper into it's own class (.cpp and .h)
2014-08-29 10:53:50 +10:00
JSB Add Caching Bound object meta data is cached within a render process CefSharp.IsObjectCached - JS method to test if object cached CefSharp.RemoveObjectFromCache - JS method to remove object from cache If a request is made for multiple objects with not all of them being cached then a IPC message is sent. When all objects already bound return response object for consistency FindBrowserWrapper signature change - it's really not safe to throw a managed exception in the middle of unmanaged code, changed to logging and null checking JavascriptObjectRepository - Add All Constant - Used when All objects are requested for binding (objects can also be requested by name) TODO: Add a JS library to improve user experience when dealing with cached objects
2018-01-29 15:48:54 +10:00
using namespace System;
Move CefAppUnmanagedWrapper into it's own class (.cpp and .h)
2014-08-29 10:53:50 +10:00
using namespace System::Diagnostics;
using namespace System::Collections::Generic;
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
using namespace CefSharp::BrowserSubprocess::Serialization;
For now simplify message handing - remove delegates Will look at implementing a managed class to handle/route messages later
2015-06-29 15:08:53 +10:00
using namespace CefSharp::Internals::Messaging;
using namespace CefSharp::Internals::Serialization;
Move CefAppUnmanagedWrapper into it's own class (.cpp and .h)
2014-08-29 10:53:50 +10:00
namespace CefSharp
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
namespace BrowserSubprocess
Move CefAppUnmanagedWrapper into it's own class (.cpp and .h)
2014-08-29 10:53:50 +10:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
const CefString CefAppUnmanagedWrapper::kPromiseCreatorScript = ""
"(function()"
"{"
" var result = {};"
" var promise = new Promise(function(resolve, reject) {"
" result.res = resolve; result.rej = reject;"
" });"
" result.p = promise;"
" return result;"
"})();";
const CefString kRenderProcessId = CefString("RenderProcessId");
const CefString kRenderProcessIdCamelCase = CefString("renderProcessId");
CefRefPtr<CefRenderProcessHandler> CefAppUnmanagedWrapper::GetRenderProcessHandler()
{
return this;
};
Javascript Legacy Binding - Pass objects on CefBrowserHost::CreateBrowser Previously objects were sent in OnRenderViewReady, which is only called once for a browser instance, not for process switches Now objects are passed when the browser is created, still need to check for popup handling
2019-06-14 14:29:53 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
// CefRenderProcessHandler
void CefAppUnmanagedWrapper::OnBrowserCreated(CefRefPtr<CefBrowser> browser, CefRefPtr<CefDictionaryValue> extraInfo)
Javascript Legacy Binding - Pass objects on CefBrowserHost::CreateBrowser Previously objects were sent in OnRenderViewReady, which is only called once for a browser instance, not for process switches Now objects are passed when the browser is created, still need to check for popup handling
2019-06-14 14:29:53 +10:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
auto wrapper = gcnew CefBrowserWrapper(browser);
_onBrowserCreated->Invoke(wrapper);
Javascript Legacy Binding - Pass objects on CefBrowserHost::CreateBrowser Previously objects were sent in OnRenderViewReady, which is only called once for a browser instance, not for process switches Now objects are passed when the browser is created, still need to check for popup handling
2019-06-14 14:29:53 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
//Multiple CefBrowserWrappers created when opening popups
_browserWrappers->TryAdd(browser->GetIdentifier(), wrapper);
Subprocess - OnBrowserCreated handle extraInfo being null - Looks like when Chromium creates it's own windows we don't get a reference to the object Issue #4963
2024-10-26 10:41:31 +10:00
if (!extraInfo.get())
{
return;
}
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
//For the main browser only we check LegacyBindingEnabled and
//load the objects. Popups don't send this information and checking
//will override the _legacyBindingEnabled field
if (!browser->IsPopup())
LegacyJavascriptBinding - Enabled field was overwritten when a popup was opened Popups don't transmit their own bound object information, _legacyBindingEnabled was being set to false
2019-08-11 18:28:42 +10:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
_legacyBindingEnabled = extraInfo->GetBool("LegacyBindingEnabled");
LegacyJavascriptBinding - Enabled field was overwritten when a popup was opened Popups don't transmit their own bound object information, _legacyBindingEnabled was being set to false
2019-08-11 18:28:42 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
if (_legacyBindingEnabled)
{
auto objects = extraInfo->GetList("LegacyBindingObjects");
if (objects.get() && objects->IsValid())
Javascript Legacy Binding - Pass objects on CefBrowserHost::CreateBrowser Previously objects were sent in OnRenderViewReady, which is only called once for a browser instance, not for process switches Now objects are passed when the browser is created, still need to check for popup handling
2019-06-14 14:29:53 +10:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
auto javascriptObjects = DeserializeJsObjects(objects, 0);
for each (JavascriptObject ^ obj in Enumerable::OfType<JavascriptObject^>(javascriptObjects))
LegacyJavascriptBinding - Enabled field was overwritten when a popup was opened Popups don't transmit their own bound object information, _legacyBindingEnabled was being set to false
2019-08-11 18:28:42 +10:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
//Using LegacyBinding with multiple ChromiumWebBrowser instances that share the same
//render process and using LegacyBinding will cause problems for the limited caching implementation
//that exists at the moment, for now we'll remove an object if already exists, same behaviour
Javascript Binding - Finalize JavascriptBindingApiAllowOrigins: Per-browser isolation and origin normalization (#5218) * Javascript Binding - Add Ability to limit origins * Move JS binding settings to CefBrowserWrapper and optimize origin validation * Initialize origins to null * Normalize allowed origins * Optimize origin validation * Add null check for origin compare * Fix JavaScript Binding API settings for popups Move the JS binding API configuration block out of the !browser->IsPopup() scope in OnBrowserCreated. This ensures that IsJavascriptBindingApiAllowed() enforces configured restrictions for popups as well. * Fix possible null deref for JavascriptBindingApiAllowOrigins In IsJavascriptBindingApiAllowed, added a null check for JavascriptBindingApiAllowOrigins to prevent a potential null dereference if JavascriptBindingApiHasAllowOrigins is true but the allowOrigins list itself was null. * Simplify origin normalization and add null check * Add more test cases * Refactor IsJavascriptBindingApiAllowed signature Refactored IsJavascriptBindingApiAllowed to accept a CefBrowserWrapper^ parameter directly, eliminating redundant lookups and improving clarity. Updated all call sites to pass the browser wrapper explicitly. * Clarify summary for HasJavascriptBindingApiAllowOrigins Clarify documentation for HasJavascriptBindingApiAllowOrigins method to specify zero or more origins * Simplify origin comparison logic in CefAppUnmanagedWrapper Refactored code to directly compare wide string origins using _wcsicmp, removing unnecessary pointer casts and null checks. This streamlines the logic and improves readability. * Add tests for JavaScript binding API behavior across cross-origin navigation --------- Co-authored-by: amaitland <307872+amaitland@users.noreply.github.com> Co-authored-by: Luca Sonntag <luca.sonntag@cgm.com>
2026-03-21 22:35:54 +01:00
//as the new binding method.
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
//TODO: This should be removed when https://github.com/cefsharp/CefSharp/issues/2306
//Is complete as objects will be stored at the browser level
if (_javascriptObjects->ContainsKey(obj->JavascriptName))
{
_javascriptObjects->Remove(obj->JavascriptName);
}
_javascriptObjects->Add(obj->JavascriptName, obj);
LegacyJavascriptBinding - Enabled field was overwritten when a popup was opened Popups don't transmit their own bound object information, _legacyBindingEnabled was being set to false
2019-08-11 18:28:42 +10:00
}
Javascript Legacy Binding - Pass objects on CefBrowserHost::CreateBrowser Previously objects were sent in OnRenderViewReady, which is only called once for a browser instance, not for process switches Now objects are passed when the browser is created, still need to check for popup handling
2019-06-14 14:29:53 +10:00
}
}
Javascript Binding - Finalize JavascriptBindingApiAllowOrigins: Per-browser isolation and origin normalization (#5218) * Javascript Binding - Add Ability to limit origins * Move JS binding settings to CefBrowserWrapper and optimize origin validation * Initialize origins to null * Normalize allowed origins * Optimize origin validation * Add null check for origin compare * Fix JavaScript Binding API settings for popups Move the JS binding API configuration block out of the !browser->IsPopup() scope in OnBrowserCreated. This ensures that IsJavascriptBindingApiAllowed() enforces configured restrictions for popups as well. * Fix possible null deref for JavascriptBindingApiAllowOrigins In IsJavascriptBindingApiAllowed, added a null check for JavascriptBindingApiAllowOrigins to prevent a potential null dereference if JavascriptBindingApiHasAllowOrigins is true but the allowOrigins list itself was null. * Simplify origin normalization and add null check * Add more test cases * Refactor IsJavascriptBindingApiAllowed signature Refactored IsJavascriptBindingApiAllowed to accept a CefBrowserWrapper^ parameter directly, eliminating redundant lookups and improving clarity. Updated all call sites to pass the browser wrapper explicitly. * Clarify summary for HasJavascriptBindingApiAllowOrigins Clarify documentation for HasJavascriptBindingApiAllowOrigins method to specify zero or more origins * Simplify origin comparison logic in CefAppUnmanagedWrapper Refactored code to directly compare wide string origins using _wcsicmp, removing unnecessary pointer casts and null checks. This streamlines the logic and improves readability. * Add tests for JavaScript binding API behavior across cross-origin navigation --------- Co-authored-by: amaitland <307872+amaitland@users.noreply.github.com> Co-authored-by: Luca Sonntag <luca.sonntag@cgm.com>
2026-03-21 22:35:54 +01:00
}
JavascriptBinding - Add JavascriptBindingSettings.JavascriptBindingApiEnabled property (#3571) - The Javascript methods that CefSharp provides in relation to JavaScript Binding are created using a Global (window) Object. Settings this property allows you to disable the creation of this object. Features like EvaluateScriptAsPromiseAsync that rely on the creation of this object will no longer function.
2021-06-04 13:26:00 +10:00
Javascript Binding - Finalize JavascriptBindingApiAllowOrigins: Per-browser isolation and origin normalization (#5218) * Javascript Binding - Add Ability to limit origins * Move JS binding settings to CefBrowserWrapper and optimize origin validation * Initialize origins to null * Normalize allowed origins * Optimize origin validation * Add null check for origin compare * Fix JavaScript Binding API settings for popups Move the JS binding API configuration block out of the !browser->IsPopup() scope in OnBrowserCreated. This ensures that IsJavascriptBindingApiAllowed() enforces configured restrictions for popups as well. * Fix possible null deref for JavascriptBindingApiAllowOrigins In IsJavascriptBindingApiAllowed, added a null check for JavascriptBindingApiAllowOrigins to prevent a potential null dereference if JavascriptBindingApiHasAllowOrigins is true but the allowOrigins list itself was null. * Simplify origin normalization and add null check * Add more test cases * Refactor IsJavascriptBindingApiAllowed signature Refactored IsJavascriptBindingApiAllowed to accept a CefBrowserWrapper^ parameter directly, eliminating redundant lookups and improving clarity. Updated all call sites to pass the browser wrapper explicitly. * Clarify summary for HasJavascriptBindingApiAllowOrigins Clarify documentation for HasJavascriptBindingApiAllowOrigins method to specify zero or more origins * Simplify origin comparison logic in CefAppUnmanagedWrapper Refactored code to directly compare wide string origins using _wcsicmp, removing unnecessary pointer casts and null checks. This streamlines the logic and improves readability. * Add tests for JavaScript binding API behavior across cross-origin navigation --------- Co-authored-by: amaitland <307872+amaitland@users.noreply.github.com> Co-authored-by: Luca Sonntag <luca.sonntag@cgm.com>
2026-03-21 22:35:54 +01:00
if (extraInfo->HasKey("JavascriptBindingApiEnabled"))
{
wrapper->JavascriptBindingApiEnabled = extraInfo->GetBool("JavascriptBindingApiEnabled");
}
if (extraInfo->HasKey("JavascriptBindingApiHasAllowOrigins"))
{
wrapper->JavascriptBindingApiHasAllowOrigins = extraInfo->GetBool("JavascriptBindingApiHasAllowOrigins");
Core - Added ability to configure/customize javascript binding property name.
2020-05-14 23:18:32 +10:00
Javascript Binding - Finalize JavascriptBindingApiAllowOrigins: Per-browser isolation and origin normalization (#5218) * Javascript Binding - Add Ability to limit origins * Move JS binding settings to CefBrowserWrapper and optimize origin validation * Initialize origins to null * Normalize allowed origins * Optimize origin validation * Add null check for origin compare * Fix JavaScript Binding API settings for popups Move the JS binding API configuration block out of the !browser->IsPopup() scope in OnBrowserCreated. This ensures that IsJavascriptBindingApiAllowed() enforces configured restrictions for popups as well. * Fix possible null deref for JavascriptBindingApiAllowOrigins In IsJavascriptBindingApiAllowed, added a null check for JavascriptBindingApiAllowOrigins to prevent a potential null dereference if JavascriptBindingApiHasAllowOrigins is true but the allowOrigins list itself was null. * Simplify origin normalization and add null check * Add more test cases * Refactor IsJavascriptBindingApiAllowed signature Refactored IsJavascriptBindingApiAllowed to accept a CefBrowserWrapper^ parameter directly, eliminating redundant lookups and improving clarity. Updated all call sites to pass the browser wrapper explicitly. * Clarify summary for HasJavascriptBindingApiAllowOrigins Clarify documentation for HasJavascriptBindingApiAllowOrigins method to specify zero or more origins * Simplify origin comparison logic in CefAppUnmanagedWrapper Refactored code to directly compare wide string origins using _wcsicmp, removing unnecessary pointer casts and null checks. This streamlines the logic and improves readability. * Add tests for JavaScript binding API behavior across cross-origin navigation --------- Co-authored-by: amaitland <307872+amaitland@users.noreply.github.com> Co-authored-by: Luca Sonntag <luca.sonntag@cgm.com>
2026-03-21 22:35:54 +01:00
if (wrapper->JavascriptBindingApiHasAllowOrigins)
Core - Crash opening popup window Upstream changes mean that extraInfo can now be null (https://bitbucket.org/chromiumembedded/cef/issues/3123/convert-legacy-ipc-messages-to-mojo) We currently only send extra Info for the main browser and not for popups. Assign the _jsBindingPropertyName/_jsBindingPropertyNameCamelCase properties by default and only update when the user has specified their own name. It's not currently possible to have different naming in the same render process (was previously the case). Issue #3670
2021-07-06 11:54:37 +10:00
{
Javascript Binding - Finalize JavascriptBindingApiAllowOrigins: Per-browser isolation and origin normalization (#5218) * Javascript Binding - Add Ability to limit origins * Move JS binding settings to CefBrowserWrapper and optimize origin validation * Initialize origins to null * Normalize allowed origins * Optimize origin validation * Add null check for origin compare * Fix JavaScript Binding API settings for popups Move the JS binding API configuration block out of the !browser->IsPopup() scope in OnBrowserCreated. This ensures that IsJavascriptBindingApiAllowed() enforces configured restrictions for popups as well. * Fix possible null deref for JavascriptBindingApiAllowOrigins In IsJavascriptBindingApiAllowed, added a null check for JavascriptBindingApiAllowOrigins to prevent a potential null dereference if JavascriptBindingApiHasAllowOrigins is true but the allowOrigins list itself was null. * Simplify origin normalization and add null check * Add more test cases * Refactor IsJavascriptBindingApiAllowed signature Refactored IsJavascriptBindingApiAllowed to accept a CefBrowserWrapper^ parameter directly, eliminating redundant lookups and improving clarity. Updated all call sites to pass the browser wrapper explicitly. * Clarify summary for HasJavascriptBindingApiAllowOrigins Clarify documentation for HasJavascriptBindingApiAllowOrigins method to specify zero or more origins * Simplify origin comparison logic in CefAppUnmanagedWrapper Refactored code to directly compare wide string origins using _wcsicmp, removing unnecessary pointer casts and null checks. This streamlines the logic and improves readability. * Add tests for JavaScript binding API behavior across cross-origin navigation --------- Co-authored-by: amaitland <307872+amaitland@users.noreply.github.com> Co-authored-by: Luca Sonntag <luca.sonntag@cgm.com>
2026-03-21 22:35:54 +01:00
auto allowOrigins = extraInfo->GetList("JavascriptBindingApiAllowOrigins");
if (allowOrigins.get() && allowOrigins->IsValid())
{
wrapper->JavascriptBindingApiAllowOrigins = allowOrigins->Copy();
}
Core - Crash opening popup window Upstream changes mean that extraInfo can now be null (https://bitbucket.org/chromiumembedded/cef/issues/3123/convert-legacy-ipc-messages-to-mojo) We currently only send extra Info for the main browser and not for popups. Assign the _jsBindingPropertyName/_jsBindingPropertyNameCamelCase properties by default and only update when the user has specified their own name. It's not currently possible to have different naming in the same render process (was previously the case). Issue #3670
2021-07-06 11:54:37 +10:00
}
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
}
Javascript Binding - Finalize JavascriptBindingApiAllowOrigins: Per-browser isolation and origin normalization (#5218) * Javascript Binding - Add Ability to limit origins * Move JS binding settings to CefBrowserWrapper and optimize origin validation * Initialize origins to null * Normalize allowed origins * Optimize origin validation * Add null check for origin compare * Fix JavaScript Binding API settings for popups Move the JS binding API configuration block out of the !browser->IsPopup() scope in OnBrowserCreated. This ensures that IsJavascriptBindingApiAllowed() enforces configured restrictions for popups as well. * Fix possible null deref for JavascriptBindingApiAllowOrigins In IsJavascriptBindingApiAllowed, added a null check for JavascriptBindingApiAllowOrigins to prevent a potential null dereference if JavascriptBindingApiHasAllowOrigins is true but the allowOrigins list itself was null. * Simplify origin normalization and add null check * Add more test cases * Refactor IsJavascriptBindingApiAllowed signature Refactored IsJavascriptBindingApiAllowed to accept a CefBrowserWrapper^ parameter directly, eliminating redundant lookups and improving clarity. Updated all call sites to pass the browser wrapper explicitly. * Clarify summary for HasJavascriptBindingApiAllowOrigins Clarify documentation for HasJavascriptBindingApiAllowOrigins method to specify zero or more origins * Simplify origin comparison logic in CefAppUnmanagedWrapper Refactored code to directly compare wide string origins using _wcsicmp, removing unnecessary pointer casts and null checks. This streamlines the logic and improves readability. * Add tests for JavaScript binding API behavior across cross-origin navigation --------- Co-authored-by: amaitland <307872+amaitland@users.noreply.github.com> Co-authored-by: Luca Sonntag <luca.sonntag@cgm.com>
2026-03-21 22:35:54 +01:00
if (extraInfo->HasKey("JsBindingPropertyName") || extraInfo->HasKey("JsBindingPropertyNameCamelCase"))
{
//TODO: Create constant for these and legacy binding strings above
_jsBindingPropertyName = extraInfo->GetString("JsBindingPropertyName");
_jsBindingPropertyNameCamelCase = extraInfo->GetString("JsBindingPropertyNameCamelCase");
}
Core - Javascript Binding Configure Property Name - Rename settings object to JavascriptBindingSettings - Validate JavascriptBindingSettings.JsBindingGlobalObjectName in setter to provide immediate feedback - Add FreezableBase which throws exception when frozen (we can reuse this for some other settings classes) - Add some basic Unit Tests (More would be better) Follow on from #3126
2020-05-19 21:55:16 +10:00
}
Move CefAppUnmanagedWrapper into it's own class (.cpp and .h)
2014-08-29 10:53:50 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
void CefAppUnmanagedWrapper::OnBrowserDestroyed(CefRefPtr<CefBrowser> browser)
Revert previous change when code to manage cleanup of multiple CefBrowserWrapper classes was removed - it appears multiple can be created when using popups (and potentially other circumstances)
2014-09-15 00:21:22 +10:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
CefBrowserWrapper^ wrapper;
if (_browserWrappers->TryRemove(browser->GetIdentifier(), wrapper))
{
_onBrowserDestroyed->Invoke(wrapper);
delete wrapper;
}
};
Add OnContextReleased and reorder methods to group together
2014-09-12 16:27:47 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
void CefAppUnmanagedWrapper::OnContextCreated(CefRefPtr<CefBrowser> browser, CefRefPtr<CefFrame> frame, CefRefPtr<CefV8Context> context)
Add Initial IRenderProcessHandler.OnContextCreated/Released implementation (#2697) * WinForms/WPF - Dispose of IFrame after calling LoadUrl * BrowserProcess - Add initial implementation of IRenderProcessHandler.OnContextCreated/OnContextReleased - IV8Context.Execute is the only method to be implemented so far (execute script without returning a result) - Wrappers for CefFrame and CefBrowser have yet to be imported yet, still need to determine if they should be included individually or reference to CefSharp.Core added * BrowserProcess - Add wrappers for Browser and Frame Ultimately we should probably remove the CefSharp.BrowserSubprocess.Core project and move all the code into a folder/namespace within CefSharp.Core This would allow us to share the a lot of existing code, major refactor required * CefSharp.Common.props - Add CefSharpBrowserProcessCore32/64 properties Make creating your own custom browser process easier * BrowserProcess - Remove example and add comments about creating your own custom version
2019-03-20 20:33:10 +10:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
if (!Object::ReferenceEquals(_handler, nullptr))
{
Browser browserWrapper(browser);
Frame frameWrapper(frame);
V8Context contextWrapper(context);
Add Initial IRenderProcessHandler.OnContextCreated/Released implementation (#2697) * WinForms/WPF - Dispose of IFrame after calling LoadUrl * BrowserProcess - Add initial implementation of IRenderProcessHandler.OnContextCreated/OnContextReleased - IV8Context.Execute is the only method to be implemented so far (execute script without returning a result) - Wrappers for CefFrame and CefBrowser have yet to be imported yet, still need to determine if they should be included individually or reference to CefSharp.Core added * BrowserProcess - Add wrappers for Browser and Frame Ultimately we should probably remove the CefSharp.BrowserSubprocess.Core project and move all the code into a folder/namespace within CefSharp.Core This would allow us to share the a lot of existing code, major refactor required * CefSharp.Common.props - Add CefSharpBrowserProcessCore32/64 properties Make creating your own custom browser process easier * BrowserProcess - Remove example and add comments about creating your own custom version
2019-03-20 20:33:10 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
_handler->OnContextCreated(% browserWrapper, % frameWrapper, % contextWrapper);
}
Add Initial IRenderProcessHandler.OnContextCreated/Released implementation (#2697) * WinForms/WPF - Dispose of IFrame after calling LoadUrl * BrowserProcess - Add initial implementation of IRenderProcessHandler.OnContextCreated/OnContextReleased - IV8Context.Execute is the only method to be implemented so far (execute script without returning a result) - Wrappers for CefFrame and CefBrowser have yet to be imported yet, still need to determine if they should be included individually or reference to CefSharp.Core added * BrowserProcess - Add wrappers for Browser and Frame Ultimately we should probably remove the CefSharp.BrowserSubprocess.Core project and move all the code into a folder/namespace within CefSharp.Core This would allow us to share the a lot of existing code, major refactor required * CefSharp.Common.props - Add CefSharpBrowserProcessCore32/64 properties Make creating your own custom browser process easier * BrowserProcess - Remove example and add comments about creating your own custom version
2019-03-20 20:33:10 +10:00
Fixed duplicate calls to OnContextCreated (#5073) * Added a reload button * Added checks for V8Context
2025-04-03 23:17:23 +02:00
//Skip additional contexts (DevTools, extensions) to avoid
//double binding and duplicate calls to IRenderProcessMessageHandler.OnContextCreated
//https://github.com/chromiumembedded/cef/issues/3867
bool isSameContext = frame->GetV8Context()->IsSame(context);
if (!isSameContext)
return;
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
auto rootObject = GetJsRootObjectWrapper(browser->GetIdentifier(), frame->GetIdentifier());
Add CefSharp.PostMessage (#2799) - JavascriptMessageReceived event added to ChromiumWebBrowser/IWebBrowser - CefSharp.PostMessage and cefSharp.postMessage added to V8Context on creation for use in Javascript - Add PostMessageTest.html
2019-06-03 21:08:03 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
if (_legacyBindingEnabled)
Make js callbacks and async methods Frame aware - add FrameId so they can be executed on a specific frame Resolves a problem where multiple contexts are created and only the first one is dealt with properly (each frame has it's own V8 context)
2015-10-11 20:41:17 +10:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
if (_javascriptObjects->Count > 0 && rootObject != nullptr)
{
rootObject->Bind(_javascriptObjects->Values, context->GetGlobal());
}
Make js callbacks and async methods Frame aware - add FrameId so they can be executed on a specific frame Resolves a problem where multiple contexts are created and only the first one is dealt with properly (each frame has it's own V8 context)
2015-10-11 20:41:17 +10:00
}
Implement Javascript Binding v2 (#2247) * JSB Rewrite - Add CefSharp.RegisterBoundObject javascript method To get around the problem of IPC timing, I've reversed the communication, now it's the render process requesting the bound objects, the implementation is incomplete at this stage, more just a basic proof of concept Rewrite BindingTest.html using QUnit One of the tests doesn't map correctly as it requires def user interaction TODO: - Get objects by name - Rename Messages.h values that relate to this change so they are more descriptive - Better error handling - Caching of objects within a render process - Investigate global context options, don't think it's possible to call an async method directly in the global context # Conflicts: # CefSharp.Example/Resources/BindingTest.html * JSB Improve Request/Response message names * BindingTest.html - Output stress test results * Remove JavascriptRootObject was leftover from time we used WCF to transmit objects * JavascriptObjectRepository - Objects are now sent in the same list with an IsAsync flag Separation when sending over IPC with two unique lists isn't necessary * JavascriptObjectRepository - Return objects by name or return all by default Untabify CefAppUnmanagedWrapper.cpp Add minor comment to CefBrowserWrapper for a reminder that we use Frame Identifier as dictionary key * Add //TODO: JSB comments for work that's left to be done Ideally within a render process we cache bound objects once they've been communicated, It would also be nice to make multiple binding requests so objects can later be added dynamically * JSB Allow multiple calls to CefSharp.RegisterBoundObject Update BindingTest.html to name two distinct calls to different bound objects * JSB - Add some notes about caching, no working implementation yet * JSB - Dynamically Register object on Request * JSB Add ability to unbind an object and rename RegisterBoundObject to BindObjectAsync # Conflicts: # CefSharp.Example/Resources/BindingTest.html * JSB BindObjectAsync - if objects already bound then return false * JSB - Ignore Indexer properties Were previously throwing an exception * JSB - Add LegacyJavascriptBindingEnabled option so preserve existing behaviour This is only useful for SPA application and those that only navigate to pages hosting within a single domain. Any sort of cross-site navigation and a new render process will be spawned and objects won't be bound automatically (You can use the new methods to request they're bound yourself, at least in theory, more testing required on this) * Add LegacyBindingTest.html Current disabled by default. To enable uncomment CefSharpSettings.LegacyJavascriptBindingEnabled = true; in CefExample.cs * RegisterJsObject and RegisterAsyncJsObject can now only be used when CefSharpSettings.LegacyJavascriptBindingEnabled = true See https://github.com/cefsharp/CefSharp/issues/2246 for details
2018-01-22 10:24:25 +10:00
Javascript Binding - Finalize JavascriptBindingApiAllowOrigins: Per-browser isolation and origin normalization (#5218) * Javascript Binding - Add Ability to limit origins * Move JS binding settings to CefBrowserWrapper and optimize origin validation * Initialize origins to null * Normalize allowed origins * Optimize origin validation * Add null check for origin compare * Fix JavaScript Binding API settings for popups Move the JS binding API configuration block out of the !browser->IsPopup() scope in OnBrowserCreated. This ensures that IsJavascriptBindingApiAllowed() enforces configured restrictions for popups as well. * Fix possible null deref for JavascriptBindingApiAllowOrigins In IsJavascriptBindingApiAllowed, added a null check for JavascriptBindingApiAllowOrigins to prevent a potential null dereference if JavascriptBindingApiHasAllowOrigins is true but the allowOrigins list itself was null. * Simplify origin normalization and add null check * Add more test cases * Refactor IsJavascriptBindingApiAllowed signature Refactored IsJavascriptBindingApiAllowed to accept a CefBrowserWrapper^ parameter directly, eliminating redundant lookups and improving clarity. Updated all call sites to pass the browser wrapper explicitly. * Clarify summary for HasJavascriptBindingApiAllowOrigins Clarify documentation for HasJavascriptBindingApiAllowOrigins method to specify zero or more origins * Simplify origin comparison logic in CefAppUnmanagedWrapper Refactored code to directly compare wide string origins using _wcsicmp, removing unnecessary pointer casts and null checks. This streamlines the logic and improves readability. * Add tests for JavaScript binding API behavior across cross-origin navigation --------- Co-authored-by: amaitland <307872+amaitland@users.noreply.github.com> Co-authored-by: Luca Sonntag <luca.sonntag@cgm.com>
2026-03-21 22:35:54 +01:00
auto browserWrapper = FindBrowserWrapper(browser->GetIdentifier());
if (browserWrapper != nullptr && browserWrapper->JavascriptBindingApiEnabled && IsJavascriptBindingApiAllowed(browserWrapper, frame))
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
{
JavascriptBinding - Add JavascriptBindingSettings.JavascriptBindingApiEnabled property (#3571) - The Javascript methods that CefSharp provides in relation to JavaScript Binding are created using a Global (window) Object. Settings this property allows you to disable the creation of this object. Features like EvaluateScriptAsPromiseAsync that rely on the creation of this object will no longer function.
2021-06-04 13:26:00 +10:00
//TODO: Look at adding some sort of javascript mapping layer to reduce the code duplication
auto global = context->GetGlobal();
auto processId = System::Diagnostics::Process::GetCurrentProcess()->Id;
//TODO: JSB: Split functions into their own classes
//Browser wrapper is only used for BindObjectAsync
Core - Rewrite RenderProcess to avoid using OnBrowserDestroyed for JS eval (#5197) - JavascriptCallbackRegistry - Get BrowserId From V8Context - Render Process - Rewrite to store root object wrapper by frame instead of per browser - Don't store JavascriptRootObjectWrapper in the browserWrapper as CEF is calling destroyed more than it should. - Revert "Tests - Simplify ShouldFailWhenIsObjectCachedCalledWithInvalidObjectName" This reverts commit f8a81acf7abd270680f5c36fa165df948599f2a1. --------- Co-authored-by: amaitland <307872+amaitland@users.noreply.github.com>
2025-12-03 19:00:12 +10:00
auto bindObjAsyncFunction = CefV8Value::CreateFunction(kBindObjectAsync, new BindObjectAsyncHandler(_registerBoundObjectRegistry, _javascriptObjects, rootObject));
JavascriptBinding - Add JavascriptBindingSettings.JavascriptBindingApiEnabled property (#3571) - The Javascript methods that CefSharp provides in relation to JavaScript Binding are created using a Global (window) Object. Settings this property allows you to disable the creation of this object. Features like EvaluateScriptAsPromiseAsync that rely on the creation of this object will no longer function.
2021-06-04 13:26:00 +10:00
auto unBindObjFunction = CefV8Value::CreateFunction(kDeleteBoundObject, new RegisterBoundObjectHandler(_javascriptObjects));
auto removeObjectFromCacheFunction = CefV8Value::CreateFunction(kRemoveObjectFromCache, new RegisterBoundObjectHandler(_javascriptObjects));
auto isObjectCachedFunction = CefV8Value::CreateFunction(kIsObjectCached, new RegisterBoundObjectHandler(_javascriptObjects));
auto postMessageFunction = CefV8Value::CreateFunction(kPostMessage, new JavascriptPostMessageHandler(rootObject == nullptr ? nullptr : rootObject->CallbackRegistry));
auto promiseHandlerFunction = CefV8Value::CreateFunction(kSendEvalScriptResponse, new JavascriptPromiseHandler());
//By default We'll support both CefSharp and cefSharp, for those who prefer the JS style
auto createCefSharpObj = !_jsBindingPropertyName.empty();
auto createCefSharpObjCamelCase = !_jsBindingPropertyNameCamelCase.empty();
if (createCefSharpObj)
{
C++/CLI - Replace NULL with nullptr Issue #3636
2021-07-31 15:35:38 +10:00
auto cefSharpObj = CefV8Value::CreateObject(nullptr, nullptr);
JavascriptBinding - Add JavascriptBindingSettings.JavascriptBindingApiEnabled property (#3571) - The Javascript methods that CefSharp provides in relation to JavaScript Binding are created using a Global (window) Object. Settings this property allows you to disable the creation of this object. Features like EvaluateScriptAsPromiseAsync that rely on the creation of this object will no longer function.
2021-06-04 13:26:00 +10:00
cefSharpObj->SetValue(kBindObjectAsync, bindObjAsyncFunction, CefV8Value::PropertyAttribute::V8_PROPERTY_ATTRIBUTE_NONE);
cefSharpObj->SetValue(kDeleteBoundObject, unBindObjFunction, CefV8Value::PropertyAttribute::V8_PROPERTY_ATTRIBUTE_NONE);
cefSharpObj->SetValue(kRemoveObjectFromCache, removeObjectFromCacheFunction, CefV8Value::PropertyAttribute::V8_PROPERTY_ATTRIBUTE_NONE);
cefSharpObj->SetValue(kIsObjectCached, isObjectCachedFunction, CefV8Value::PropertyAttribute::V8_PROPERTY_ATTRIBUTE_NONE);
cefSharpObj->SetValue(kPostMessage, postMessageFunction, CefV8Value::PropertyAttribute::V8_PROPERTY_ATTRIBUTE_NONE);
cefSharpObj->SetValue(kSendEvalScriptResponse, promiseHandlerFunction, CefV8Value::PropertyAttribute::V8_PROPERTY_ATTRIBUTE_NONE);
cefSharpObj->SetValue(kRenderProcessId, CefV8Value::CreateInt(processId), CefV8Value::PropertyAttribute::V8_PROPERTY_ATTRIBUTE_NONE);
global->SetValue(_jsBindingPropertyName, cefSharpObj, CefV8Value::PropertyAttribute::V8_PROPERTY_ATTRIBUTE_READONLY);
}
JSB - Add JavascriptBindingCompleteEventArgs and config options to CefSharp.BindObjectAsync CefSharp.BindObjectAsync can now take an optional config object as first param Include additional information when binding complete Add option for cefSharp.bindObjectAsync (starting with lowercase latters) Add new syntax options - not entirely complete, no variant for the options object Add ignore cache option
2018-04-26 10:20:39 +10:00
JavascriptBinding - Add JavascriptBindingSettings.JavascriptBindingApiEnabled property (#3571) - The Javascript methods that CefSharp provides in relation to JavaScript Binding are created using a Global (window) Object. Settings this property allows you to disable the creation of this object. Features like EvaluateScriptAsPromiseAsync that rely on the creation of this object will no longer function.
2021-06-04 13:26:00 +10:00
if (createCefSharpObjCamelCase)
{
C++/CLI - Replace NULL with nullptr Issue #3636
2021-07-31 15:35:38 +10:00
auto cefSharpObjCamelCase = CefV8Value::CreateObject(nullptr, nullptr);
JavascriptBinding - Add JavascriptBindingSettings.JavascriptBindingApiEnabled property (#3571) - The Javascript methods that CefSharp provides in relation to JavaScript Binding are created using a Global (window) Object. Settings this property allows you to disable the creation of this object. Features like EvaluateScriptAsPromiseAsync that rely on the creation of this object will no longer function.
2021-06-04 13:26:00 +10:00
cefSharpObjCamelCase->SetValue(kBindObjectAsyncCamelCase, bindObjAsyncFunction, CefV8Value::PropertyAttribute::V8_PROPERTY_ATTRIBUTE_NONE);
cefSharpObjCamelCase->SetValue(kDeleteBoundObjectCamelCase, unBindObjFunction, CefV8Value::PropertyAttribute::V8_PROPERTY_ATTRIBUTE_NONE);
cefSharpObjCamelCase->SetValue(kRemoveObjectFromCacheCamelCase, removeObjectFromCacheFunction, CefV8Value::PropertyAttribute::V8_PROPERTY_ATTRIBUTE_NONE);
cefSharpObjCamelCase->SetValue(kIsObjectCachedCamelCase, isObjectCachedFunction, CefV8Value::PropertyAttribute::V8_PROPERTY_ATTRIBUTE_NONE);
cefSharpObjCamelCase->SetValue(kPostMessageCamelCase, postMessageFunction, CefV8Value::PropertyAttribute::V8_PROPERTY_ATTRIBUTE_NONE);
cefSharpObjCamelCase->SetValue(kSendEvalScriptResponseCamelCase, promiseHandlerFunction, CefV8Value::PropertyAttribute::V8_PROPERTY_ATTRIBUTE_NONE);
cefSharpObjCamelCase->SetValue(kRenderProcessIdCamelCase, CefV8Value::CreateInt(processId), CefV8Value::PropertyAttribute::V8_PROPERTY_ATTRIBUTE_NONE);
global->SetValue(_jsBindingPropertyNameCamelCase, cefSharpObjCamelCase, CefV8Value::PropertyAttribute::V8_PROPERTY_ATTRIBUTE_READONLY);
}
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
}
CefAppUnmanagedWrapper::OnContextCreated - Send OnContextCreated message after Objects created Message is now sent once the CefSharp.BindObjectAsync and helper functions are created and Legacy objects are bound. It should now be reliable to call CefSharp.BindObjectAsync in OnContextCreated
2018-08-05 19:56:41 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
//Send a message to the browser processing signaling that OnContextCreated has been called
//only param is the FrameId. Previous sent only for main frame, now sent for all frames
//Message sent after legacy objects have been bound and the CefSharp bind async helper methods
//have been created
auto contextCreatedMessage = CefProcessMessage::Create(kOnContextCreatedRequest);
CefAppUnmanagedWrapper::OnContextCreated - Send OnContextCreated message after Objects created Message is now sent once the CefSharp.BindObjectAsync and helper functions are created and Legacy objects are bound. It should now be reliable to call CefSharp.BindObjectAsync in OnContextCreated
2018-08-05 19:56:41 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
frame->SendProcessMessage(CefProcessId::PID_BROWSER, contextCreatedMessage);
};
Move CefAppUnmanagedWrapper into it's own class (.cpp and .h)
2014-08-29 10:53:50 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
void CefAppUnmanagedWrapper::OnContextReleased(CefRefPtr<CefBrowser> browser, CefRefPtr<CefFrame> frame, CefRefPtr<CefV8Context> context)
Add Initial IRenderProcessHandler.OnContextCreated/Released implementation (#2697) * WinForms/WPF - Dispose of IFrame after calling LoadUrl * BrowserProcess - Add initial implementation of IRenderProcessHandler.OnContextCreated/OnContextReleased - IV8Context.Execute is the only method to be implemented so far (execute script without returning a result) - Wrappers for CefFrame and CefBrowser have yet to be imported yet, still need to determine if they should be included individually or reference to CefSharp.Core added * BrowserProcess - Add wrappers for Browser and Frame Ultimately we should probably remove the CefSharp.BrowserSubprocess.Core project and move all the code into a folder/namespace within CefSharp.Core This would allow us to share the a lot of existing code, major refactor required * CefSharp.Common.props - Add CefSharpBrowserProcessCore32/64 properties Make creating your own custom browser process easier * BrowserProcess - Remove example and add comments about creating your own custom version
2019-03-20 20:33:10 +10:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
if (!Object::ReferenceEquals(_handler, nullptr))
{
Browser browserWrapper(browser);
Frame frameWrapper(frame);
V8Context contextWrapper(context);
Add Initial IRenderProcessHandler.OnContextCreated/Released implementation (#2697) * WinForms/WPF - Dispose of IFrame after calling LoadUrl * BrowserProcess - Add initial implementation of IRenderProcessHandler.OnContextCreated/OnContextReleased - IV8Context.Execute is the only method to be implemented so far (execute script without returning a result) - Wrappers for CefFrame and CefBrowser have yet to be imported yet, still need to determine if they should be included individually or reference to CefSharp.Core added * BrowserProcess - Add wrappers for Browser and Frame Ultimately we should probably remove the CefSharp.BrowserSubprocess.Core project and move all the code into a folder/namespace within CefSharp.Core This would allow us to share the a lot of existing code, major refactor required * CefSharp.Common.props - Add CefSharpBrowserProcessCore32/64 properties Make creating your own custom browser process easier * BrowserProcess - Remove example and add comments about creating your own custom version
2019-03-20 20:33:10 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
_handler->OnContextReleased(% browserWrapper, % frameWrapper, % contextWrapper);
}
Add Initial IRenderProcessHandler.OnContextCreated/Released implementation (#2697) * WinForms/WPF - Dispose of IFrame after calling LoadUrl * BrowserProcess - Add initial implementation of IRenderProcessHandler.OnContextCreated/OnContextReleased - IV8Context.Execute is the only method to be implemented so far (execute script without returning a result) - Wrappers for CefFrame and CefBrowser have yet to be imported yet, still need to determine if they should be included individually or reference to CefSharp.Core added * BrowserProcess - Add wrappers for Browser and Frame Ultimately we should probably remove the CefSharp.BrowserSubprocess.Core project and move all the code into a folder/namespace within CefSharp.Core This would allow us to share the a lot of existing code, major refactor required * CefSharp.Common.props - Add CefSharpBrowserProcessCore32/64 properties Make creating your own custom browser process easier * BrowserProcess - Remove example and add comments about creating your own custom version
2019-03-20 20:33:10 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
auto contextReleasedMessage = CefProcessMessage::Create(kOnContextReleasedRequest);
Add IRenderProcessMessageHandler.OnContextReleased - native IPC message sent from render process
2017-03-07 09:23:10 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
frame->SendProcessMessage(CefProcessId::PID_BROWSER, contextReleasedMessage);
Add IRenderProcessMessageHandler.OnContextReleased - native IPC message sent from render process
2017-03-07 09:23:10 +10:00
Core - Rewrite RenderProcess to avoid using OnBrowserDestroyed for JS eval (#5197) - JavascriptCallbackRegistry - Get BrowserId From V8Context - Render Process - Rewrite to store root object wrapper by frame instead of per browser - Don't store JavascriptRootObjectWrapper in the browserWrapper as CEF is calling destroyed more than it should. - Revert "Tests - Simplify ShouldFailWhenIsObjectCachedCalledWithInvalidObjectName" This reverts commit f8a81acf7abd270680f5c36fa165df948599f2a1. --------- Co-authored-by: amaitland <307872+amaitland@users.noreply.github.com>
2025-12-03 19:00:12 +10:00
auto rootObjectWrappers = _jsRootObjectWrappersByFrameId;
JSB Add Caching Bound object meta data is cached within a render process CefSharp.IsObjectCached - JS method to test if object cached CefSharp.RemoveObjectFromCache - JS method to remove object from cache If a request is made for multiple objects with not all of them being cached then a IPC message is sent. When all objects already bound return response object for consistency FindBrowserWrapper signature change - it's really not safe to throw a managed exception in the middle of unmanaged code, changed to logging and null checking JavascriptObjectRepository - Add All Constant - Used when All objects are requested for binding (objects can also be requested by name) TODO: Add a JS library to improve user experience when dealing with cached objects
2018-01-29 15:48:54 +10:00
Core - Rewrite RenderProcess to avoid using OnBrowserDestroyed for JS eval (#5197) - JavascriptCallbackRegistry - Get BrowserId From V8Context - Render Process - Rewrite to store root object wrapper by frame instead of per browser - Don't store JavascriptRootObjectWrapper in the browserWrapper as CEF is calling destroyed more than it should. - Revert "Tests - Simplify ShouldFailWhenIsObjectCachedCalledWithInvalidObjectName" This reverts commit f8a81acf7abd270680f5c36fa165df948599f2a1. --------- Co-authored-by: amaitland <307872+amaitland@users.noreply.github.com>
2025-12-03 19:00:12 +10:00
//If we no longer have a _jsRootObjectWrappersByFrameId reference then there's nothing we can do
if (Object::ReferenceEquals(rootObjectWrappers, nullptr))
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
{
return;
}
memleak : show problem
2014-11-25 09:34:15 -05:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
JavascriptRootObjectWrapper^ wrapper;
Change Frame identifier from Int64 to String (#4740) * Change Frame identifier from Int64 to String Issue https://github.com/cefsharp/CefSharp/issues/4737 * Fix SetCanExecuteJavascriptOnMainFrame frameId parsing * Add tests * NetCore Tests - Install missing packages
2024-03-09 06:55:27 +10:00
if (rootObjectWrappers->TryRemove(StringUtils::ToClr(frame->GetIdentifier()), wrapper))
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
{
delete wrapper;
}
};
Reorder methods - logical grouping (cef methods kept together)
2014-09-12 12:48:10 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
void CefAppUnmanagedWrapper::OnFocusedNodeChanged(CefRefPtr<CefBrowser> browser, CefRefPtr<CefFrame> frame, CefRefPtr<CefDOMNode> node)
Add the OptionalMessages property to CefSettings.
2015-12-07 16:27:17 -05:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
if (!_focusedNodeChangedEnabled)
{
return;
}
Add the OptionalMessages property to CefSettings.
2015-12-07 16:27:17 -05:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
auto focusedNodeChangedMessage = CefProcessMessage::Create(kOnFocusedNodeChanged);
auto list = focusedNodeChangedMessage->GetArgumentList();
When OnFocusedNodeChanged data is passed from render to browser process.
2015-12-03 15:59:27 -05:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
// The node will be empty if an element loses focus but another one
// doesn't gain focus. Only transfer information if the node is an
// element.
if (node != nullptr && node->IsElement())
{
// True when a node exists, false if it doesn't.
list->SetBool(0, true);
// Store the tag name.
list->SetString(1, node->GetElementTagName());
Fix: tabs to spaces, if and for braces, use frame ID.
2015-12-07 09:48:57 -05:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
// Transfer the attributes in a Dictionary.
auto attributes = CefDictionaryValue::Create();
CefDOMNode::AttributeMap attributeMap;
node->GetElementAttributes(attributeMap);
for (auto iter : attributeMap)
{
attributes->SetString(iter.first, iter.second);
}
Fix: tabs to spaces, if and for braces, use frame ID.
2015-12-07 09:48:57 -05:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
list->SetDictionary(2, attributes);
}
else
Fix: tabs to spaces, if and for braces, use frame ID.
2015-12-07 09:48:57 -05:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
list->SetBool(0, false);
Fix: tabs to spaces, if and for braces, use frame ID.
2015-12-07 09:48:57 -05:00
}
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
frame->SendProcessMessage(CefProcessId::PID_BROWSER, focusedNodeChangedMessage);
Fix: tabs to spaces, if and for braces, use frame ID.
2015-12-07 09:48:57 -05:00
}
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
void CefAppUnmanagedWrapper::OnUncaughtException(CefRefPtr<CefBrowser> browser, CefRefPtr<CefFrame> frame, CefRefPtr<CefV8Context> context, CefRefPtr<CefV8Exception> exception, CefRefPtr<CefV8StackTrace> stackTrace)
Fix: tabs to spaces, if and for braces, use frame ID.
2015-12-07 09:48:57 -05:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
auto uncaughtExceptionMessage = CefProcessMessage::Create(kOnUncaughtException);
auto list = uncaughtExceptionMessage->GetArgumentList();
Fix: tabs to spaces, if and for braces, use frame ID.
2015-12-07 09:48:57 -05:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
list->SetString(0, exception->GetMessage());
When OnFocusedNodeChanged data is passed from render to browser process.
2015-12-03 15:59:27 -05:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
auto frames = CefListValue::Create();
for (auto i = 0; i < stackTrace->GetFrameCount(); i++)
{
auto stackTraceFrame = CefListValue::Create();
auto frameArg = stackTrace->GetFrame(i);
Support uncaught exception handling (#2244) * Added support for uncaught javascript exception in Render Process Message Handler * Fixed typo * Added stack frame column numbers * Code review * Code review * Update JavascriptException.cs
2018-03-07 00:21:31 +00:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
stackTraceFrame->SetString(0, frameArg->GetFunctionName());
stackTraceFrame->SetInt(1, frameArg->GetLineNumber());
stackTraceFrame->SetInt(2, frameArg->GetColumn());
stackTraceFrame->SetString(3, frameArg->GetScriptNameOrSourceURL());
Support uncaught exception handling (#2244) * Added support for uncaught javascript exception in Render Process Message Handler * Fixed typo * Added stack frame column numbers * Code review * Code review * Update JavascriptException.cs
2018-03-07 00:21:31 +00:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
frames->SetList(i, stackTraceFrame);
}
Support uncaught exception handling (#2244) * Added support for uncaught javascript exception in Render Process Message Handler * Fixed typo * Added stack frame column numbers * Code review * Code review * Update JavascriptException.cs
2018-03-07 00:21:31 +00:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
list->SetList(1, frames);
Support uncaught exception handling (#2244) * Added support for uncaught javascript exception in Render Process Message Handler * Fixed typo * Added stack frame column numbers * Code review * Code review * Update JavascriptException.cs
2018-03-07 00:21:31 +00:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
frame->SendProcessMessage(CefProcessId::PID_BROWSER, uncaughtExceptionMessage);
Support uncaught exception handling (#2244) * Added support for uncaught javascript exception in Render Process Message Handler * Fixed typo * Added stack frame column numbers * Code review * Code review * Update JavascriptException.cs
2018-03-07 00:21:31 +00:00
}
Core - Fix CPP compiler warnings
2026-02-20 21:08:41 +10:00
JavascriptRootObjectWrapper^ CefAppUnmanagedWrapper::GetJsRootObjectWrapper(int browserId, const CefString& frameId)
JSB Add Caching Bound object meta data is cached within a render process CefSharp.IsObjectCached - JS method to test if object cached CefSharp.RemoveObjectFromCache - JS method to remove object from cache If a request is made for multiple objects with not all of them being cached then a IPC message is sent. When all objects already bound return response object for consistency FindBrowserWrapper signature change - it's really not safe to throw a managed exception in the middle of unmanaged code, changed to logging and null checking JavascriptObjectRepository - Add All Constant - Used when All objects are requested for binding (objects can also be requested by name) TODO: Add a JS library to improve user experience when dealing with cached objects
2018-01-29 15:48:54 +10:00
{
Core - Rewrite RenderProcess to avoid using OnBrowserDestroyed for JS eval (#5197) - JavascriptCallbackRegistry - Get BrowserId From V8Context - Render Process - Rewrite to store root object wrapper by frame instead of per browser - Don't store JavascriptRootObjectWrapper in the browserWrapper as CEF is calling destroyed more than it should. - Revert "Tests - Simplify ShouldFailWhenIsObjectCachedCalledWithInvalidObjectName" This reverts commit f8a81acf7abd270680f5c36fa165df948599f2a1. --------- Co-authored-by: amaitland <307872+amaitland@users.noreply.github.com>
2025-12-03 19:00:12 +10:00
auto rootObjectWrappers = _jsRootObjectWrappersByFrameId;
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
Core - Rewrite RenderProcess to avoid using OnBrowserDestroyed for JS eval (#5197) - JavascriptCallbackRegistry - Get BrowserId From V8Context - Render Process - Rewrite to store root object wrapper by frame instead of per browser - Don't store JavascriptRootObjectWrapper in the browserWrapper as CEF is calling destroyed more than it should. - Revert "Tests - Simplify ShouldFailWhenIsObjectCachedCalledWithInvalidObjectName" This reverts commit f8a81acf7abd270680f5c36fa165df948599f2a1. --------- Co-authored-by: amaitland <307872+amaitland@users.noreply.github.com>
2025-12-03 19:00:12 +10:00
if (Object::ReferenceEquals(rootObjectWrappers, nullptr))
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
{
return nullptr;
}
JSB Add Caching Bound object meta data is cached within a render process CefSharp.IsObjectCached - JS method to test if object cached CefSharp.RemoveObjectFromCache - JS method to remove object from cache If a request is made for multiple objects with not all of them being cached then a IPC message is sent. When all objects already bound return response object for consistency FindBrowserWrapper signature change - it's really not safe to throw a managed exception in the middle of unmanaged code, changed to logging and null checking JavascriptObjectRepository - Add All Constant - Used when All objects are requested for binding (objects can also be requested by name) TODO: Add a JS library to improve user experience when dealing with cached objects
2018-01-29 15:48:54 +10:00
Change Frame identifier from Int64 to String (#4740) * Change Frame identifier from Int64 to String Issue https://github.com/cefsharp/CefSharp/issues/4737 * Fix SetCanExecuteJavascriptOnMainFrame frameId parsing * Add tests * NetCore Tests - Install missing packages
2024-03-09 06:55:27 +10:00
auto frameIdClr = StringUtils::ToClr(frameId);
JSB Add Caching Bound object meta data is cached within a render process CefSharp.IsObjectCached - JS method to test if object cached CefSharp.RemoveObjectFromCache - JS method to remove object from cache If a request is made for multiple objects with not all of them being cached then a IPC message is sent. When all objects already bound return response object for consistency FindBrowserWrapper signature change - it's really not safe to throw a managed exception in the middle of unmanaged code, changed to logging and null checking JavascriptObjectRepository - Add All Constant - Used when All objects are requested for binding (objects can also be requested by name) TODO: Add a JS library to improve user experience when dealing with cached objects
2018-01-29 15:48:54 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
JavascriptRootObjectWrapper^ rootObject;
Change Frame identifier from Int64 to String (#4740) * Change Frame identifier from Int64 to String Issue https://github.com/cefsharp/CefSharp/issues/4737 * Fix SetCanExecuteJavascriptOnMainFrame frameId parsing * Add tests * NetCore Tests - Install missing packages
2024-03-09 06:55:27 +10:00
if (!rootObjectWrappers->TryGetValue(frameIdClr, rootObject))
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
{
Net Core - Support for compiling with .Net Core 3.1 - Make Wpf/WinForms/OffScreen projects target AnyCPU Only the VC++ projects are platform specific now. - Remove BrowserSubProcess project reference Not needed as we now have a standalone exe - Add OffScreen example - Add WPF Example project - Fix some compile errors for main solution - Add BrowserSubProcess executable - JavascriptObjectRepository remove isAsync param Rather than throw exception remove the option - BrowserSubprocess Exclude the WCF specific code from the netCore project - Add some ifdef/ifndef to exclude the WCF specific implementation - Move WCF implementation into separate namespace
2020-07-18 13:30:54 +10:00
#ifdef NETCOREAPP
Core - Rewrite RenderProcess to avoid using OnBrowserDestroyed for JS eval (#5197) - JavascriptCallbackRegistry - Get BrowserId From V8Context - Render Process - Rewrite to store root object wrapper by frame instead of per browser - Don't store JavascriptRootObjectWrapper in the browserWrapper as CEF is calling destroyed more than it should. - Revert "Tests - Simplify ShouldFailWhenIsObjectCachedCalledWithInvalidObjectName" This reverts commit f8a81acf7abd270680f5c36fa165df948599f2a1. --------- Co-authored-by: amaitland <307872+amaitland@users.noreply.github.com>
2025-12-03 19:00:12 +10:00
rootObject = gcnew JavascriptRootObjectWrapper();
Net Core - Support for compiling with .Net Core 3.1 - Make Wpf/WinForms/OffScreen projects target AnyCPU Only the VC++ projects are platform specific now. - Remove BrowserSubProcess project reference Not needed as we now have a standalone exe - Add OffScreen example - Add WPF Example project - Fix some compile errors for main solution - Add BrowserSubProcess executable - JavascriptObjectRepository remove isAsync param Rather than throw exception remove the option - BrowserSubprocess Exclude the WCF specific code from the netCore project - Add some ifdef/ifndef to exclude the WCF specific implementation - Move WCF implementation into separate namespace
2020-07-18 13:30:54 +10:00
#else
Core - Rewrite RenderProcess to avoid using OnBrowserDestroyed for JS eval (#5197) - JavascriptCallbackRegistry - Get BrowserId From V8Context - Render Process - Rewrite to store root object wrapper by frame instead of per browser - Don't store JavascriptRootObjectWrapper in the browserWrapper as CEF is calling destroyed more than it should. - Revert "Tests - Simplify ShouldFailWhenIsObjectCachedCalledWithInvalidObjectName" This reverts commit f8a81acf7abd270680f5c36fa165df948599f2a1. --------- Co-authored-by: amaitland <307872+amaitland@users.noreply.github.com>
2025-12-03 19:00:12 +10:00
auto browserWrapper = FindBrowserWrapper(browserId);
rootObject = gcnew JavascriptRootObjectWrapper(browserWrapper == nullptr ? nullptr : browserWrapper->BrowserProcess);
Net Core - Support for compiling with .Net Core 3.1 - Make Wpf/WinForms/OffScreen projects target AnyCPU Only the VC++ projects are platform specific now. - Remove BrowserSubProcess project reference Not needed as we now have a standalone exe - Add OffScreen example - Add WPF Example project - Fix some compile errors for main solution - Add BrowserSubProcess executable - JavascriptObjectRepository remove isAsync param Rather than throw exception remove the option - BrowserSubprocess Exclude the WCF specific code from the netCore project - Add some ifdef/ifndef to exclude the WCF specific implementation - Move WCF implementation into separate namespace
2020-07-18 13:30:54 +10:00
#endif
Change Frame identifier from Int64 to String (#4740) * Change Frame identifier from Int64 to String Issue https://github.com/cefsharp/CefSharp/issues/4737 * Fix SetCanExecuteJavascriptOnMainFrame frameId parsing * Add tests * NetCore Tests - Install missing packages
2024-03-09 06:55:27 +10:00
rootObjectWrappers->TryAdd(frameIdClr, rootObject);
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
}
return rootObject;
JSB Add Caching Bound object meta data is cached within a render process CefSharp.IsObjectCached - JS method to test if object cached CefSharp.RemoveObjectFromCache - JS method to remove object from cache If a request is made for multiple objects with not all of them being cached then a IPC message is sent. When all objects already bound return response object for consistency FindBrowserWrapper signature change - it's really not safe to throw a managed exception in the middle of unmanaged code, changed to logging and null checking JavascriptObjectRepository - Add All Constant - Used when All objects are requested for binding (objects can also be requested by name) TODO: Add a JS library to improve user experience when dealing with cached objects
2018-01-29 15:48:54 +10:00
}
Javascript Binding - Finalize JavascriptBindingApiAllowOrigins: Per-browser isolation and origin normalization (#5218) * Javascript Binding - Add Ability to limit origins * Move JS binding settings to CefBrowserWrapper and optimize origin validation * Initialize origins to null * Normalize allowed origins * Optimize origin validation * Add null check for origin compare * Fix JavaScript Binding API settings for popups Move the JS binding API configuration block out of the !browser->IsPopup() scope in OnBrowserCreated. This ensures that IsJavascriptBindingApiAllowed() enforces configured restrictions for popups as well. * Fix possible null deref for JavascriptBindingApiAllowOrigins In IsJavascriptBindingApiAllowed, added a null check for JavascriptBindingApiAllowOrigins to prevent a potential null dereference if JavascriptBindingApiHasAllowOrigins is true but the allowOrigins list itself was null. * Simplify origin normalization and add null check * Add more test cases * Refactor IsJavascriptBindingApiAllowed signature Refactored IsJavascriptBindingApiAllowed to accept a CefBrowserWrapper^ parameter directly, eliminating redundant lookups and improving clarity. Updated all call sites to pass the browser wrapper explicitly. * Clarify summary for HasJavascriptBindingApiAllowOrigins Clarify documentation for HasJavascriptBindingApiAllowOrigins method to specify zero or more origins * Simplify origin comparison logic in CefAppUnmanagedWrapper Refactored code to directly compare wide string origins using _wcsicmp, removing unnecessary pointer casts and null checks. This streamlines the logic and improves readability. * Add tests for JavaScript binding API behavior across cross-origin navigation --------- Co-authored-by: amaitland <307872+amaitland@users.noreply.github.com> Co-authored-by: Luca Sonntag <luca.sonntag@cgm.com>
2026-03-21 22:35:54 +01:00
bool CefAppUnmanagedWrapper::IsJavascriptBindingApiAllowed(CefBrowserWrapper^ browserWrapper, CefRefPtr<CefFrame> frame)
{
if (browserWrapper == nullptr || !browserWrapper->JavascriptBindingApiHasAllowOrigins)
{
return true;
}
auto allowOrigins = browserWrapper->JavascriptBindingApiAllowOrigins;
if (!allowOrigins.get())
{
return false;
}
auto frameUrl = frame->GetURL();
CefURLParts frameUrlParts;
if (CefParseURL(frameUrl, frameUrlParts))
{
auto originStr = frameUrlParts.origin.str;
auto originLen = frameUrlParts.origin.length;
if (originLen > 0 && originStr[originLen - 1] == L'/')
{
originLen--;
}
auto frameUrlOrigin = CefString(originStr, originLen);
auto size = static_cast<int>(allowOrigins->GetSize());
for (int i = 0; i < size; i++)
{
auto origin = allowOrigins->GetString(i);
if (_wcsicmp(frameUrlOrigin.ToWString().c_str(), origin.ToWString().c_str()) == 0)
{
return true;
}
}
}
return false;
}
JSB Add Caching Bound object meta data is cached within a render process CefSharp.IsObjectCached - JS method to test if object cached CefSharp.RemoveObjectFromCache - JS method to remove object from cache If a request is made for multiple objects with not all of them being cached then a IPC message is sent. When all objects already bound return response object for consistency FindBrowserWrapper signature change - it's really not safe to throw a managed exception in the middle of unmanaged code, changed to logging and null checking JavascriptObjectRepository - Add All Constant - Used when All objects are requested for binding (objects can also be requested by name) TODO: Add a JS library to improve user experience when dealing with cached objects
2018-01-29 15:48:54 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
CefBrowserWrapper^ CefAppUnmanagedWrapper::FindBrowserWrapper(int browserId)
{
CefBrowserWrapper^ wrapper = nullptr;
JSB Add Caching Bound object meta data is cached within a render process CefSharp.IsObjectCached - JS method to test if object cached CefSharp.RemoveObjectFromCache - JS method to remove object from cache If a request is made for multiple objects with not all of them being cached then a IPC message is sent. When all objects already bound return response object for consistency FindBrowserWrapper signature change - it's really not safe to throw a managed exception in the middle of unmanaged code, changed to logging and null checking JavascriptObjectRepository - Add All Constant - Used when All objects are requested for binding (objects can also be requested by name) TODO: Add a JS library to improve user experience when dealing with cached objects
2018-01-29 15:48:54 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
_browserWrappers->TryGetValue(browserId, wrapper);
Fix: js bindings must be kept by browser, not by process
2014-10-28 11:25:53 -04:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
if (wrapper == nullptr)
{
//TODO: Find the syntax for delcaring the native string directly
LOG(ERROR) << StringUtils::ToNative("Failed to identify BrowserWrapper in OnContextCreated BrowserId:" + browserId).ToString();
}
Fix: js bindings must be kept by browser, not by process
2014-10-28 11:25:53 -04:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
return wrapper;
Fix: js bindings must be kept by browser, not by process
2014-10-28 11:25:53 -04:00
}
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
bool CefAppUnmanagedWrapper::OnProcessMessageReceived(CefRefPtr<CefBrowser> browser, CefRefPtr<CefFrame> frame, CefProcessId sourceProcessId, CefRefPtr<CefProcessMessage> message)
added process message handlers and code to call them on both sides
2015-06-27 17:01:51 +02:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
auto handled = false;
auto name = message->GetName();
auto argList = message->GetArgumentList();
added error handling when browser id has no match in render process
2015-07-09 23:36:31 +02:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
//these messages are roughly handled the same way
if (name == kEvaluateJavascriptRequest || name == kJavascriptCallbackRequest)
Conditionally create response for kEvaluateJavascriptRequest and kJavascriptCallbackRequest (was only going to create the kEvaluateJavascriptResponse before
2015-10-19 13:40:36 +10:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
bool sendResponse = true;
bool success = false;
CefRefPtr<CefV8Value> result;
CefString errorMessage;
CefRefPtr<CefProcessMessage> response;
Conditionally create response for kEvaluateJavascriptRequest and kJavascriptCallbackRequest (was only going to create the kEvaluateJavascriptResponse before
2015-10-19 13:40:36 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
if (name == kEvaluateJavascriptRequest)
{
response = CefProcessMessage::Create(kEvaluateJavascriptResponse);
}
else
{
response = CefProcessMessage::Create(kJavascriptCallbackResponse);
}
For now simplify message handing - remove delegates Will look at implementing a managed class to handle/route messages later
2015-06-29 15:08:53 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
//both messages have callbackId stored at index 0
Change Frame identifier from Int64 to String (#4740) * Change Frame identifier from Int64 to String Issue https://github.com/cefsharp/CefSharp/issues/4737 * Fix SetCanExecuteJavascriptOnMainFrame frameId parsing * Add tests * NetCore Tests - Install missing packages
2024-03-09 06:55:27 +10:00
auto frameId = StringUtils::ToClr(frame->GetIdentifier());
Core - Change from cef type defs to C++11 defs https://bitbucket.org/chromiumembedded/cef/commits/5042d7140822cd13b80990f61ce2d3865864a3d8
2023-07-16 06:32:58 +10:00
int64_t callbackId = GetInt64(argList, 0);
Maintenance - Fixed formatting, file encoding, and copyright year (#2504) * Applied formatting * Fixed file encoding + Updated copyright year * Updated License * Fixed more file encoding * Copyright notice now shows the year the file was created
2018-09-10 02:41:13 +02:00
Core - Rewrite RenderProcess to avoid using OnBrowserDestroyed for JS eval (#5197) - JavascriptCallbackRegistry - Get BrowserId From V8Context - Render Process - Rewrite to store root object wrapper by frame instead of per browser - Don't store JavascriptRootObjectWrapper in the browserWrapper as CEF is calling destroyed more than it should. - Revert "Tests - Simplify ShouldFailWhenIsObjectCachedCalledWithInvalidObjectName" This reverts commit f8a81acf7abd270680f5c36fa165df948599f2a1. --------- Co-authored-by: amaitland <307872+amaitland@users.noreply.github.com>
2025-12-03 19:00:12 +10:00
//NOTE: In the rare case when when OnContextCreated hasn't been called we need to manually create the rootObjectWrapper
//It appears that OnContextCreated is only called for pages that have javascript on them, which makes sense
//as without javascript there is no need for a context.
JavascriptRootObjectWrapper^ rootObjectWrapper = GetJsRootObjectWrapper(browser->GetIdentifier(), frame->GetIdentifier());
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
if (name == kEvaluateJavascriptRequest)
Proposed solution to #1354 The problem seems to be that OnContextCreated is never called as the page has no javascript code on it. Keep the same callbackRegistry logic for kJavascriptCallbackRequest as without a context there cannot be a callback For kEvaluateJavascriptRequest we now manually create a callback registry for the frame if required. Once the script is executed OnContextCreated is called, the wrapper creation is ignored and the context should be released as per normal in OnContextReleased
2015-10-26 11:41:19 +10:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
auto script = argList->GetString(1);
auto scriptUrl = argList->GetString(2);
auto startLine = argList->GetInt(3);
Maintenance - Fixed formatting, file encoding, and copyright year (#2504) * Applied formatting * Fixed file encoding + Updated copyright year * Updated License * Fixed more file encoding * Copyright notice now shows the year the file was created
2018-09-10 02:41:13 +02:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
if (frame.get() && frame->IsValid())
readded try-finally for renderprocess side messaging handling
2015-07-08 18:46:28 +02:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
auto context = frame->GetV8Context();
Maintenance - Fixed formatting, file encoding, and copyright year (#2504) * Applied formatting * Fixed file encoding + Updated copyright year * Updated License * Fixed more file encoding * Copyright notice now shows the year the file was created
2018-09-10 02:41:13 +02:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
if (context.get() && context->Enter())
{
try
readded try-finally for renderprocess side messaging handling
2015-07-08 18:46:28 +02:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
CefRefPtr<CefV8Exception> exception;
success = context->Eval(script, scriptUrl, startLine, result, exception);
//we need to do this here to be able to store the v8context
if (success)
Core - Add EvaluateScriptAsPromiseAsync (#3251) - Add useImmediatelyInvokedFuncExpression param to EvaluateScriptAsync which wraps the script in an IIFE with the cefSharpInternalCallbackId variable defined in scope to allow for deferred completion - Wrap script in Immediately Invoked Function Expression and call promise.resolve to guarantee a promise. - Return 'CefSharpDefEvalScriptRes' as the result of the js function to defer execution of the callback - Call newly added cefSharp.sendEvalScriptResponse method in javascript when promise has been resolved/rejected This is built up of a few parts and can technically be used by the new user to defer the response until they are ready. Just return `'CefSharpDefEvalScriptRes'` and manually call cefSharp.sendEvalScriptResponse using the cefSharpInternalCallbackId variable which is injected into the script execution (wrapped in an IIFE to limit scope)
2020-10-06 15:19:37 +10:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
//If the response is a string of CefSharpDefEvalScriptRes then
//we don't send the response, we'll let that happen when the promise has completed.
if (result->IsString() && result->GetStringValue() == "CefSharpDefEvalScriptRes")
{
sendResponse = false;
}
Enhancement - Improve Promise support (#4326) * Enhancement - Improved promise support Resolves #4276
2022-12-06 14:54:19 +10:00
else if (result->IsPromise())
{
sendResponse = false;
auto promiseThen = result->GetValue("then");
auto promiseCatch = result->GetValue("catch");
auto promiseThenFunc = CefV8Value::CreateFunction("promiseResolverThen", new JavascriptPromiseResolverThen(callbackId, false));
auto promiseCatchFunc = CefV8Value::CreateFunction("promiseResolverCatch", new JavascriptPromiseResolverCatch(callbackId, false));
CefV8ValueList promiseThenArgs;
promiseThenArgs.push_back(promiseThenFunc);
promiseThen->ExecuteFunction(result, promiseThenArgs);
CefV8ValueList promiseCatchArgs;
promiseCatchArgs.push_back(promiseCatchFunc);
promiseCatch->ExecuteFunction(result, promiseCatchArgs);
}
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
else
{
Core - Rewrite RenderProcess to avoid using OnBrowserDestroyed for JS eval (#5197) - JavascriptCallbackRegistry - Get BrowserId From V8Context - Render Process - Rewrite to store root object wrapper by frame instead of per browser - Don't store JavascriptRootObjectWrapper in the browserWrapper as CEF is calling destroyed more than it should. - Revert "Tests - Simplify ShouldFailWhenIsObjectCachedCalledWithInvalidObjectName" This reverts commit f8a81acf7abd270680f5c36fa165df948599f2a1. --------- Co-authored-by: amaitland <307872+amaitland@users.noreply.github.com>
2025-12-03 19:00:12 +10:00
auto callbackRegistry = rootObjectWrapper == nullptr ? nullptr : rootObjectWrapper->CallbackRegistry;
if (callbackRegistry == nullptr)
{
errorMessage = StringUtils::ToNative("The callback registry for Frame " + frameId + " is no longer available.");
}
else
{
auto responseArgList = response->GetArgumentList();
SerializeV8Object(result, responseArgList, 2, callbackRegistry);
}
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
}
Core - Add EvaluateScriptAsPromiseAsync (#3251) - Add useImmediatelyInvokedFuncExpression param to EvaluateScriptAsync which wraps the script in an IIFE with the cefSharpInternalCallbackId variable defined in scope to allow for deferred completion - Wrap script in Immediately Invoked Function Expression and call promise.resolve to guarantee a promise. - Return 'CefSharpDefEvalScriptRes' as the result of the js function to defer execution of the callback - Call newly added cefSharp.sendEvalScriptResponse method in javascript when promise has been resolved/rejected This is built up of a few parts and can technically be used by the new user to defer the response until they are ready. Just return `'CefSharpDefEvalScriptRes'` and manually call cefSharp.sendEvalScriptResponse using the cefSharpInternalCallbackId variable which is injected into the script execution (wrapped in an IIFE to limit scope)
2020-10-06 15:19:37 +10:00
}
else
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
errorMessage = StringUtils::CreateExceptionString(exception);
Core - Add EvaluateScriptAsPromiseAsync (#3251) - Add useImmediatelyInvokedFuncExpression param to EvaluateScriptAsync which wraps the script in an IIFE with the cefSharpInternalCallbackId variable defined in scope to allow for deferred completion - Wrap script in Immediately Invoked Function Expression and call promise.resolve to guarantee a promise. - Return 'CefSharpDefEvalScriptRes' as the result of the js function to defer execution of the callback - Call newly added cefSharp.sendEvalScriptResponse method in javascript when promise has been resolved/rejected This is built up of a few parts and can technically be used by the new user to defer the response until they are ready. Just return `'CefSharpDefEvalScriptRes'` and manually call cefSharp.sendEvalScriptResponse using the cefSharpInternalCallbackId variable which is injected into the script execution (wrapped in an IIFE to limit scope)
2020-10-06 15:19:37 +10:00
}
readded try-finally for renderprocess side messaging handling
2015-07-08 18:46:28 +02:00
}
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
finally
Return error message when unable to enter context or find matching frame
2015-07-10 10:22:12 +10:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
context->Exit();
Return error message when unable to enter context or find matching frame
2015-07-10 10:22:12 +10:00
}
readded try-finally for renderprocess side messaging handling
2015-07-08 18:46:28 +02:00
}
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
else
Reapply change to move try finally block inside context->Enter() - otherwise we could potentially Exit a context we never entered
2015-07-10 10:18:01 +10:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
errorMessage = "Unable to Enter Context";
Reapply change to move try finally block inside context->Enter() - otherwise we could potentially Exit a context we never entered
2015-07-10 10:18:01 +10:00
}
readded try-finally for renderprocess side messaging handling
2015-07-08 18:46:28 +02:00
}
Reapply change to move try finally block inside context->Enter() - otherwise we could potentially Exit a context we never entered
2015-07-10 10:18:01 +10:00
else
For now simplify message handing - remove delegates Will look at implementing a managed class to handle/route messages later
2015-06-29 15:08:53 +10:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
errorMessage = StringUtils::ToNative("Frame " + frameId + " is no longer available, most likely the Frame has been Disposed or Removed.");
message handling added for js callback execution through cef ipc
2015-07-07 08:12:04 +02:00
}
}
else
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
auto callbackRegistry = rootObjectWrapper == nullptr ? nullptr : rootObjectWrapper->CallbackRegistry;
if (callbackRegistry == nullptr)
Proposed solution to #1354 The problem seems to be that OnContextCreated is never called as the page has no javascript code on it. Keep the same callbackRegistry logic for kJavascriptCallbackRequest as without a context there cannot be a callback For kEvaluateJavascriptRequest we now manually create a callback registry for the frame if required. Once the script is executed OnContextCreated is called, the wrapper creation is ignored and the context should be released as per normal in OnContextReleased
2015-10-26 11:41:19 +10:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
errorMessage = StringUtils::ToNative("The callback registry for Frame " + frameId + " is no longer available, most likely the Frame has been Disposed.");
Proposed solution to #1354 The problem seems to be that OnContextCreated is never called as the page has no javascript code on it. Keep the same callbackRegistry logic for kJavascriptCallbackRequest as without a context there cannot be a callback For kEvaluateJavascriptRequest we now manually create a callback registry for the frame if required. Once the script is executed OnContextCreated is called, the wrapper creation is ignored and the context should be released as per normal in OnContextReleased
2015-10-26 11:41:19 +10:00
}
else
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
auto jsCallbackId = GetInt64(argList, 1);
Maintenance - Fixed formatting, file encoding, and copyright year (#2504) * Applied formatting * Fixed file encoding + Updated copyright year * Updated License * Fixed more file encoding * Copyright notice now shows the year the file was created
2018-09-10 02:41:13 +02:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
auto callbackWrapper = callbackRegistry->FindWrapper(jsCallbackId);
if (callbackWrapper == nullptr)
readded try-finally for renderprocess side messaging handling
2015-07-08 18:46:28 +02:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
errorMessage = StringUtils::ToNative("Unable to find JavascriptCallback with Id " + jsCallbackId + " for Frame " + frameId);
}
else
{
auto context = callbackWrapper->GetContext();
auto value = callbackWrapper->GetValue();
Maintenance - Fixed formatting, file encoding, and copyright year (#2504) * Applied formatting * Fixed file encoding + Updated copyright year * Updated License * Fixed more file encoding * Copyright notice now shows the year the file was created
2018-09-10 02:41:13 +02:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
if (context.get() && context->Enter())
{
try
Resolves #1407 More the DeserializeV8Object call to within the context->Enter so a V8Object can be created Change callback to use a struct as it's return type to demo the solution to this bug Add missing list->SetDictionary call in V8Serialization.cpp
2015-11-18 09:17:16 +10:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
auto parameterList = argList->GetList(2);
CefV8ValueList params;
Resolves #1407 More the DeserializeV8Object call to within the context->Enter so a V8Object can be created Change callback to use a struct as it's return type to demo the solution to this bug Add missing list->SetDictionary call in V8Serialization.cpp
2015-11-18 09:17:16 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
//Needs to be called within the context as for Dictionary (mapped to struct)
//a V8Object will be created
for (CefV8ValueList::size_type i = 0; i < parameterList->GetSize(); i++)
{
params.push_back(DeserializeV8Object(parameterList, static_cast<int>(i)));
}
Maintenance - Fixed formatting, file encoding, and copyright year (#2504) * Applied formatting * Fixed file encoding + Updated copyright year * Updated License * Fixed more file encoding * Copyright notice now shows the year the file was created
2018-09-10 02:41:13 +02:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
result = value->ExecuteFunction(nullptr, params);
success = result.get() != nullptr;
//we need to do this here to be able to store the v8context
if (success)
Javascript Callback - Add very basic support for executing a Promise It's a manual process at this stage and requires the end user to deal to: - Return "CefSharpDefEvalScriptRes" immediately after the promise function has been created - Call cefSharp.sendEvalScriptResponse when the async/await (promise) processing has completed
2021-02-15 13:43:51 +10:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
//If the response is a string of CefSharpDefEvalScriptRes then
//we don't send the response, we'll let that happen when the promise has completed.
if (result->IsString() && result->GetStringValue() == "CefSharpDefEvalScriptRes")
{
sendResponse = false;
}
Enhancement - Improve Promise support (#4326) * Enhancement - Improved promise support Resolves #4276
2022-12-06 14:54:19 +10:00
else if (result->IsPromise())
{
sendResponse = false;
auto promiseThen = result->GetValue("then");
auto promiseCatch = result->GetValue("catch");
auto promiseThenFunc = CefV8Value::CreateFunction("promiseResolverThen", new JavascriptPromiseResolverThen(callbackId, true));
auto promiseCatchFunc = CefV8Value::CreateFunction("promiseResolverCatch", new JavascriptPromiseResolverCatch(callbackId, true));
CefV8ValueList promiseThenArgs;
promiseThenArgs.push_back(promiseThenFunc);
promiseThen->ExecuteFunction(result, promiseThenArgs);
CefV8ValueList promiseCatchArgs;
promiseCatchArgs.push_back(promiseCatchFunc);
promiseCatch->ExecuteFunction(result, promiseCatchArgs);
}
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
else
{
auto responseArgList = response->GetArgumentList();
SerializeV8Object(result, responseArgList, 2, callbackRegistry);
}
Javascript Callback - Add very basic support for executing a Promise It's a manual process at this stage and requires the end user to deal to: - Return "CefSharpDefEvalScriptRes" immediately after the promise function has been created - Call cefSharp.sendEvalScriptResponse when the async/await (promise) processing has completed
2021-02-15 13:43:51 +10:00
}
else
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
auto exception = value->GetException();
errorMessage = StringUtils::CreateExceptionString(exception);
Javascript Callback - Add very basic support for executing a Promise It's a manual process at this stage and requires the end user to deal to: - Return "CefSharpDefEvalScriptRes" immediately after the promise function has been created - Call cefSharp.sendEvalScriptResponse when the async/await (promise) processing has completed
2021-02-15 13:43:51 +10:00
}
Proposed solution to #1354 The problem seems to be that OnContextCreated is never called as the page has no javascript code on it. Keep the same callbackRegistry logic for kJavascriptCallbackRequest as without a context there cannot be a callback For kEvaluateJavascriptRequest we now manually create a callback registry for the frame if required. Once the script is executed OnContextCreated is called, the wrapper creation is ignored and the context should be released as per normal in OnContextReleased
2015-10-26 11:41:19 +10:00
}
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
finally
Proposed solution to #1354 The problem seems to be that OnContextCreated is never called as the page has no javascript code on it. Keep the same callbackRegistry logic for kJavascriptCallbackRequest as without a context there cannot be a callback For kEvaluateJavascriptRequest we now manually create a callback registry for the frame if required. Once the script is executed OnContextCreated is called, the wrapper creation is ignored and the context should be released as per normal in OnContextReleased
2015-10-26 11:41:19 +10:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
context->Exit();
Proposed solution to #1354 The problem seems to be that OnContextCreated is never called as the page has no javascript code on it. Keep the same callbackRegistry logic for kJavascriptCallbackRequest as without a context there cannot be a callback For kEvaluateJavascriptRequest we now manually create a callback registry for the frame if required. Once the script is executed OnContextCreated is called, the wrapper creation is ignored and the context should be released as per normal in OnContextReleased
2015-10-26 11:41:19 +10:00
}
This should fix #1336 (IJavascriptCallback.ExecuteAsync never returns when callback no longer exists) and likely fixes as-of-yet undiscovered related callback problems. The code previously in CefAppUnmanagedWrapper.cpp's OnProcessMessageReceived method did not check for a nullptr callbackWrapper resulting in an exception. Also note that previously the success and reponse variables were not initialized by default which I believe to have been a mistake after following all of the if..else code paths (most importantly some error conditions would never be returned back). I added a new test to BindingTest.html entitled "Test Disposed Callback" which makes the same 1.5 second delayed callback that "Test Callback" does, but then immediately navigate the page to www.google.com. Without the fix in CefAppUnmanagedWrapper.cpp the browser's renderer process will die in about 10 seconds.
2015-10-18 14:47:54 -07:00
}
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
else
This should fix #1336 (IJavascriptCallback.ExecuteAsync never returns when callback no longer exists) and likely fixes as-of-yet undiscovered related callback problems. The code previously in CefAppUnmanagedWrapper.cpp's OnProcessMessageReceived method did not check for a nullptr callbackWrapper resulting in an exception. Also note that previously the success and reponse variables were not initialized by default which I believe to have been a mistake after following all of the if..else code paths (most importantly some error conditions would never be returned back). I added a new test to BindingTest.html entitled "Test Disposed Callback" which makes the same 1.5 second delayed callback that "Test Callback" does, but then immediately navigate the page to www.google.com. Without the fix in CefAppUnmanagedWrapper.cpp the browser's renderer process will die in about 10 seconds.
2015-10-18 14:47:54 -07:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
errorMessage = "Unable to Enter Context";
Return error message when unable to enter context or find matching frame
2015-07-10 10:22:12 +10:00
}
readded try-finally for renderprocess side messaging handling
2015-07-08 18:46:28 +02:00
}
For now simplify message handing - remove delegates Will look at implementing a managed class to handle/route messages later
2015-06-29 15:08:53 +10:00
}
}
message handling added for js callback execution through cef ipc
2015-07-07 08:12:04 +02:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
if (sendResponse)
Core - Add EvaluateScriptAsPromiseAsync (#3251) - Add useImmediatelyInvokedFuncExpression param to EvaluateScriptAsync which wraps the script in an IIFE with the cefSharpInternalCallbackId variable defined in scope to allow for deferred completion - Wrap script in Immediately Invoked Function Expression and call promise.resolve to guarantee a promise. - Return 'CefSharpDefEvalScriptRes' as the result of the js function to defer execution of the callback - Call newly added cefSharp.sendEvalScriptResponse method in javascript when promise has been resolved/rejected This is built up of a few parts and can technically be used by the new user to defer the response until they are ready. Just return `'CefSharpDefEvalScriptRes'` and manually call cefSharp.sendEvalScriptResponse using the cefSharpInternalCallbackId variable which is injected into the script execution (wrapped in an IIFE to limit scope)
2020-10-06 15:19:37 +10:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
auto responseArgList = response->GetArgumentList();
responseArgList->SetBool(0, success);
SetInt64(responseArgList, 1, callbackId);
if (!success)
{
responseArgList->SetString(2, errorMessage);
}
frame->SendProcessMessage(sourceProcessId, response);
Core - Add EvaluateScriptAsPromiseAsync (#3251) - Add useImmediatelyInvokedFuncExpression param to EvaluateScriptAsync which wraps the script in an IIFE with the cefSharpInternalCallbackId variable defined in scope to allow for deferred completion - Wrap script in Immediately Invoked Function Expression and call promise.resolve to guarantee a promise. - Return 'CefSharpDefEvalScriptRes' as the result of the js function to defer execution of the callback - Call newly added cefSharp.sendEvalScriptResponse method in javascript when promise has been resolved/rejected This is built up of a few parts and can technically be used by the new user to defer the response until they are ready. Just return `'CefSharpDefEvalScriptRes'` and manually call cefSharp.sendEvalScriptResponse using the cefSharpInternalCallbackId variable which is injected into the script execution (wrapped in an IIFE to limit scope)
2020-10-06 15:19:37 +10:00
}
For now simplify message handing - remove delegates Will look at implementing a managed class to handle/route messages later
2015-06-29 15:08:53 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
handled = true;
}
else if (name == kJavascriptCallbackDestroyRequest)
ensure destroyed root objects are not accessed in cef app unmanaged warpper message handling
2015-10-13 13:00:39 +09:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
if (frame.get() && frame->IsValid())
Javascript Legacy Binding - Pass objects on CefBrowserHost::CreateBrowser Previously objects were sent in OnRenderViewReady, which is only called once for a browser instance, not for process switches Now objects are passed when the browser is created, still need to check for popup handling
2019-06-14 14:29:53 +10:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
auto jsCallbackId = GetInt64(argList, 0);
JavascriptRootObjectWrapper^ rootObjectWrapper;
Core - Rewrite RenderProcess to avoid using OnBrowserDestroyed for JS eval (#5197) - JavascriptCallbackRegistry - Get BrowserId From V8Context - Render Process - Rewrite to store root object wrapper by frame instead of per browser - Don't store JavascriptRootObjectWrapper in the browserWrapper as CEF is calling destroyed more than it should. - Revert "Tests - Simplify ShouldFailWhenIsObjectCachedCalledWithInvalidObjectName" This reverts commit f8a81acf7abd270680f5c36fa165df948599f2a1. --------- Co-authored-by: amaitland <307872+amaitland@users.noreply.github.com>
2025-12-03 19:00:12 +10:00
_jsRootObjectWrappersByFrameId->TryGetValue(StringUtils::ToClr(frame->GetIdentifier()), rootObjectWrapper);
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
if (rootObjectWrapper != nullptr && rootObjectWrapper->CallbackRegistry != nullptr)
{
rootObjectWrapper->CallbackRegistry->Deregister(jsCallbackId);
}
Javascript Legacy Binding - Pass objects on CefBrowserHost::CreateBrowser Previously objects were sent in OnRenderViewReady, which is only called once for a browser instance, not for process switches Now objects are passed when the browser is created, still need to check for popup handling
2019-06-14 14:29:53 +10:00
}
message handling added for js callback execution through cef ipc
2015-07-07 08:12:04 +02:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
handled = true;
}
else if (name == kJavascriptRootObjectResponse)
Implement Javascript Binding v2 (#2247) * JSB Rewrite - Add CefSharp.RegisterBoundObject javascript method To get around the problem of IPC timing, I've reversed the communication, now it's the render process requesting the bound objects, the implementation is incomplete at this stage, more just a basic proof of concept Rewrite BindingTest.html using QUnit One of the tests doesn't map correctly as it requires def user interaction TODO: - Get objects by name - Rename Messages.h values that relate to this change so they are more descriptive - Better error handling - Caching of objects within a render process - Investigate global context options, don't think it's possible to call an async method directly in the global context # Conflicts: # CefSharp.Example/Resources/BindingTest.html * JSB Improve Request/Response message names * BindingTest.html - Output stress test results * Remove JavascriptRootObject was leftover from time we used WCF to transmit objects * JavascriptObjectRepository - Objects are now sent in the same list with an IsAsync flag Separation when sending over IPC with two unique lists isn't necessary * JavascriptObjectRepository - Return objects by name or return all by default Untabify CefAppUnmanagedWrapper.cpp Add minor comment to CefBrowserWrapper for a reminder that we use Frame Identifier as dictionary key * Add //TODO: JSB comments for work that's left to be done Ideally within a render process we cache bound objects once they've been communicated, It would also be nice to make multiple binding requests so objects can later be added dynamically * JSB Allow multiple calls to CefSharp.RegisterBoundObject Update BindingTest.html to name two distinct calls to different bound objects * JSB - Add some notes about caching, no working implementation yet * JSB - Dynamically Register object on Request * JSB Add ability to unbind an object and rename RegisterBoundObject to BindObjectAsync # Conflicts: # CefSharp.Example/Resources/BindingTest.html * JSB BindObjectAsync - if objects already bound then return false * JSB - Ignore Indexer properties Were previously throwing an exception * JSB - Add LegacyJavascriptBindingEnabled option so preserve existing behaviour This is only useful for SPA application and those that only navigate to pages hosting within a single domain. Any sort of cross-site navigation and a new render process will be spawned and objects won't be bound automatically (You can use the new methods to request they're bound yourself, at least in theory, more testing required on this) * Add LegacyBindingTest.html Current disabled by default. To enable uncomment CefSharpSettings.LegacyJavascriptBindingEnabled = true; in CefExample.cs * RegisterJsObject and RegisterAsyncJsObject can now only be used when CefSharpSettings.LegacyJavascriptBindingEnabled = true See https://github.com/cefsharp/CefSharp/issues/2246 for details
2018-01-22 10:24:25 +10:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
if (browser.get() && frame.get() && frame->IsValid())
Implement Javascript Binding v2 (#2247) * JSB Rewrite - Add CefSharp.RegisterBoundObject javascript method To get around the problem of IPC timing, I've reversed the communication, now it's the render process requesting the bound objects, the implementation is incomplete at this stage, more just a basic proof of concept Rewrite BindingTest.html using QUnit One of the tests doesn't map correctly as it requires def user interaction TODO: - Get objects by name - Rename Messages.h values that relate to this change so they are more descriptive - Better error handling - Caching of objects within a render process - Investigate global context options, don't think it's possible to call an async method directly in the global context # Conflicts: # CefSharp.Example/Resources/BindingTest.html * JSB Improve Request/Response message names * BindingTest.html - Output stress test results * Remove JavascriptRootObject was leftover from time we used WCF to transmit objects * JavascriptObjectRepository - Objects are now sent in the same list with an IsAsync flag Separation when sending over IPC with two unique lists isn't necessary * JavascriptObjectRepository - Return objects by name or return all by default Untabify CefAppUnmanagedWrapper.cpp Add minor comment to CefBrowserWrapper for a reminder that we use Frame Identifier as dictionary key * Add //TODO: JSB comments for work that's left to be done Ideally within a render process we cache bound objects once they've been communicated, It would also be nice to make multiple binding requests so objects can later be added dynamically * JSB Allow multiple calls to CefSharp.RegisterBoundObject Update BindingTest.html to name two distinct calls to different bound objects * JSB - Add some notes about caching, no working implementation yet * JSB - Dynamically Register object on Request * JSB Add ability to unbind an object and rename RegisterBoundObject to BindObjectAsync # Conflicts: # CefSharp.Example/Resources/BindingTest.html * JSB BindObjectAsync - if objects already bound then return false * JSB - Ignore Indexer properties Were previously throwing an exception * JSB - Add LegacyJavascriptBindingEnabled option so preserve existing behaviour This is only useful for SPA application and those that only navigate to pages hosting within a single domain. Any sort of cross-site navigation and a new render process will be spawned and objects won't be bound automatically (You can use the new methods to request they're bound yourself, at least in theory, more testing required on this) * Add LegacyBindingTest.html Current disabled by default. To enable uncomment CefSharpSettings.LegacyJavascriptBindingEnabled = true; in CefExample.cs * RegisterJsObject and RegisterAsyncJsObject can now only be used when CefSharpSettings.LegacyJavascriptBindingEnabled = true See https://github.com/cefsharp/CefSharp/issues/2246 for details
2018-01-22 10:24:25 +10:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
auto callbackId = GetInt64(argList, 0);
auto javascriptObjects = DeserializeJsObjects(argList, 1);
//Caching of JavascriptObjects
//TODO: JSB Should caching be configurable? On a per object basis?
for each (JavascriptObject ^ obj in Enumerable::OfType<JavascriptObject^>(javascriptObjects))
Implement Javascript Binding v2 (#2247) * JSB Rewrite - Add CefSharp.RegisterBoundObject javascript method To get around the problem of IPC timing, I've reversed the communication, now it's the render process requesting the bound objects, the implementation is incomplete at this stage, more just a basic proof of concept Rewrite BindingTest.html using QUnit One of the tests doesn't map correctly as it requires def user interaction TODO: - Get objects by name - Rename Messages.h values that relate to this change so they are more descriptive - Better error handling - Caching of objects within a render process - Investigate global context options, don't think it's possible to call an async method directly in the global context # Conflicts: # CefSharp.Example/Resources/BindingTest.html * JSB Improve Request/Response message names * BindingTest.html - Output stress test results * Remove JavascriptRootObject was leftover from time we used WCF to transmit objects * JavascriptObjectRepository - Objects are now sent in the same list with an IsAsync flag Separation when sending over IPC with two unique lists isn't necessary * JavascriptObjectRepository - Return objects by name or return all by default Untabify CefAppUnmanagedWrapper.cpp Add minor comment to CefBrowserWrapper for a reminder that we use Frame Identifier as dictionary key * Add //TODO: JSB comments for work that's left to be done Ideally within a render process we cache bound objects once they've been communicated, It would also be nice to make multiple binding requests so objects can later be added dynamically * JSB Allow multiple calls to CefSharp.RegisterBoundObject Update BindingTest.html to name two distinct calls to different bound objects * JSB - Add some notes about caching, no working implementation yet * JSB - Dynamically Register object on Request * JSB Add ability to unbind an object and rename RegisterBoundObject to BindObjectAsync # Conflicts: # CefSharp.Example/Resources/BindingTest.html * JSB BindObjectAsync - if objects already bound then return false * JSB - Ignore Indexer properties Were previously throwing an exception * JSB - Add LegacyJavascriptBindingEnabled option so preserve existing behaviour This is only useful for SPA application and those that only navigate to pages hosting within a single domain. Any sort of cross-site navigation and a new render process will be spawned and objects won't be bound automatically (You can use the new methods to request they're bound yourself, at least in theory, more testing required on this) * Add LegacyBindingTest.html Current disabled by default. To enable uncomment CefSharpSettings.LegacyJavascriptBindingEnabled = true; in CefExample.cs * RegisterJsObject and RegisterAsyncJsObject can now only be used when CefSharpSettings.LegacyJavascriptBindingEnabled = true See https://github.com/cefsharp/CefSharp/issues/2246 for details
2018-01-22 10:24:25 +10:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
if (_javascriptObjects->ContainsKey(obj->JavascriptName))
{
_javascriptObjects->Remove(obj->JavascriptName);
}
_javascriptObjects->Add(obj->JavascriptName, obj);
Implement Javascript Binding v2 (#2247) * JSB Rewrite - Add CefSharp.RegisterBoundObject javascript method To get around the problem of IPC timing, I've reversed the communication, now it's the render process requesting the bound objects, the implementation is incomplete at this stage, more just a basic proof of concept Rewrite BindingTest.html using QUnit One of the tests doesn't map correctly as it requires def user interaction TODO: - Get objects by name - Rename Messages.h values that relate to this change so they are more descriptive - Better error handling - Caching of objects within a render process - Investigate global context options, don't think it's possible to call an async method directly in the global context # Conflicts: # CefSharp.Example/Resources/BindingTest.html * JSB Improve Request/Response message names * BindingTest.html - Output stress test results * Remove JavascriptRootObject was leftover from time we used WCF to transmit objects * JavascriptObjectRepository - Objects are now sent in the same list with an IsAsync flag Separation when sending over IPC with two unique lists isn't necessary * JavascriptObjectRepository - Return objects by name or return all by default Untabify CefAppUnmanagedWrapper.cpp Add minor comment to CefBrowserWrapper for a reminder that we use Frame Identifier as dictionary key * Add //TODO: JSB comments for work that's left to be done Ideally within a render process we cache bound objects once they've been communicated, It would also be nice to make multiple binding requests so objects can later be added dynamically * JSB Allow multiple calls to CefSharp.RegisterBoundObject Update BindingTest.html to name two distinct calls to different bound objects * JSB - Add some notes about caching, no working implementation yet * JSB - Dynamically Register object on Request * JSB Add ability to unbind an object and rename RegisterBoundObject to BindObjectAsync # Conflicts: # CefSharp.Example/Resources/BindingTest.html * JSB BindObjectAsync - if objects already bound then return false * JSB - Ignore Indexer properties Were previously throwing an exception * JSB - Add LegacyJavascriptBindingEnabled option so preserve existing behaviour This is only useful for SPA application and those that only navigate to pages hosting within a single domain. Any sort of cross-site navigation and a new render process will be spawned and objects won't be bound automatically (You can use the new methods to request they're bound yourself, at least in theory, more testing required on this) * Add LegacyBindingTest.html Current disabled by default. To enable uncomment CefSharpSettings.LegacyJavascriptBindingEnabled = true; in CefExample.cs * RegisterJsObject and RegisterAsyncJsObject can now only be used when CefSharpSettings.LegacyJavascriptBindingEnabled = true See https://github.com/cefsharp/CefSharp/issues/2246 for details
2018-01-22 10:24:25 +10:00
}
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
auto rootObject = GetJsRootObjectWrapper(browser->GetIdentifier(), frame->GetIdentifier());
Implement Javascript Binding v2 (#2247) * JSB Rewrite - Add CefSharp.RegisterBoundObject javascript method To get around the problem of IPC timing, I've reversed the communication, now it's the render process requesting the bound objects, the implementation is incomplete at this stage, more just a basic proof of concept Rewrite BindingTest.html using QUnit One of the tests doesn't map correctly as it requires def user interaction TODO: - Get objects by name - Rename Messages.h values that relate to this change so they are more descriptive - Better error handling - Caching of objects within a render process - Investigate global context options, don't think it's possible to call an async method directly in the global context # Conflicts: # CefSharp.Example/Resources/BindingTest.html * JSB Improve Request/Response message names * BindingTest.html - Output stress test results * Remove JavascriptRootObject was leftover from time we used WCF to transmit objects * JavascriptObjectRepository - Objects are now sent in the same list with an IsAsync flag Separation when sending over IPC with two unique lists isn't necessary * JavascriptObjectRepository - Return objects by name or return all by default Untabify CefAppUnmanagedWrapper.cpp Add minor comment to CefBrowserWrapper for a reminder that we use Frame Identifier as dictionary key * Add //TODO: JSB comments for work that's left to be done Ideally within a render process we cache bound objects once they've been communicated, It would also be nice to make multiple binding requests so objects can later be added dynamically * JSB Allow multiple calls to CefSharp.RegisterBoundObject Update BindingTest.html to name two distinct calls to different bound objects * JSB - Add some notes about caching, no working implementation yet * JSB - Dynamically Register object on Request * JSB Add ability to unbind an object and rename RegisterBoundObject to BindObjectAsync # Conflicts: # CefSharp.Example/Resources/BindingTest.html * JSB BindObjectAsync - if objects already bound then return false * JSB - Ignore Indexer properties Were previously throwing an exception * JSB - Add LegacyJavascriptBindingEnabled option so preserve existing behaviour This is only useful for SPA application and those that only navigate to pages hosting within a single domain. Any sort of cross-site navigation and a new render process will be spawned and objects won't be bound automatically (You can use the new methods to request they're bound yourself, at least in theory, more testing required on this) * Add LegacyBindingTest.html Current disabled by default. To enable uncomment CefSharpSettings.LegacyJavascriptBindingEnabled = true; in CefExample.cs * RegisterJsObject and RegisterAsyncJsObject can now only be used when CefSharpSettings.LegacyJavascriptBindingEnabled = true See https://github.com/cefsharp/CefSharp/issues/2246 for details
2018-01-22 10:24:25 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
if (rootObject == nullptr)
{
return false;
}
Implement Javascript Binding v2 (#2247) * JSB Rewrite - Add CefSharp.RegisterBoundObject javascript method To get around the problem of IPC timing, I've reversed the communication, now it's the render process requesting the bound objects, the implementation is incomplete at this stage, more just a basic proof of concept Rewrite BindingTest.html using QUnit One of the tests doesn't map correctly as it requires def user interaction TODO: - Get objects by name - Rename Messages.h values that relate to this change so they are more descriptive - Better error handling - Caching of objects within a render process - Investigate global context options, don't think it's possible to call an async method directly in the global context # Conflicts: # CefSharp.Example/Resources/BindingTest.html * JSB Improve Request/Response message names * BindingTest.html - Output stress test results * Remove JavascriptRootObject was leftover from time we used WCF to transmit objects * JavascriptObjectRepository - Objects are now sent in the same list with an IsAsync flag Separation when sending over IPC with two unique lists isn't necessary * JavascriptObjectRepository - Return objects by name or return all by default Untabify CefAppUnmanagedWrapper.cpp Add minor comment to CefBrowserWrapper for a reminder that we use Frame Identifier as dictionary key * Add //TODO: JSB comments for work that's left to be done Ideally within a render process we cache bound objects once they've been communicated, It would also be nice to make multiple binding requests so objects can later be added dynamically * JSB Allow multiple calls to CefSharp.RegisterBoundObject Update BindingTest.html to name two distinct calls to different bound objects * JSB - Add some notes about caching, no working implementation yet * JSB - Dynamically Register object on Request * JSB Add ability to unbind an object and rename RegisterBoundObject to BindObjectAsync # Conflicts: # CefSharp.Example/Resources/BindingTest.html * JSB BindObjectAsync - if objects already bound then return false * JSB - Ignore Indexer properties Were previously throwing an exception * JSB - Add LegacyJavascriptBindingEnabled option so preserve existing behaviour This is only useful for SPA application and those that only navigate to pages hosting within a single domain. Any sort of cross-site navigation and a new render process will be spawned and objects won't be bound automatically (You can use the new methods to request they're bound yourself, at least in theory, more testing required on this) * Add LegacyBindingTest.html Current disabled by default. To enable uncomment CefSharpSettings.LegacyJavascriptBindingEnabled = true; in CefExample.cs * RegisterJsObject and RegisterAsyncJsObject can now only be used when CefSharpSettings.LegacyJavascriptBindingEnabled = true See https://github.com/cefsharp/CefSharp/issues/2246 for details
2018-01-22 10:24:25 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
auto context = frame->GetV8Context();
CefAppUnmanagedWrapper - Minor refactor in kJavascriptRootObjectResponse and kJavascriptAsyncMethodCallResponse kJavascriptRootObjectResponse - delete the callback when not used kJavascriptAsyncMethodCallResponse - Only execute if we have a valid frame
2019-07-20 18:28:36 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
if (context.get() && context->Enter())
Implement Javascript Binding v2 (#2247) * JSB Rewrite - Add CefSharp.RegisterBoundObject javascript method To get around the problem of IPC timing, I've reversed the communication, now it's the render process requesting the bound objects, the implementation is incomplete at this stage, more just a basic proof of concept Rewrite BindingTest.html using QUnit One of the tests doesn't map correctly as it requires def user interaction TODO: - Get objects by name - Rename Messages.h values that relate to this change so they are more descriptive - Better error handling - Caching of objects within a render process - Investigate global context options, don't think it's possible to call an async method directly in the global context # Conflicts: # CefSharp.Example/Resources/BindingTest.html * JSB Improve Request/Response message names * BindingTest.html - Output stress test results * Remove JavascriptRootObject was leftover from time we used WCF to transmit objects * JavascriptObjectRepository - Objects are now sent in the same list with an IsAsync flag Separation when sending over IPC with two unique lists isn't necessary * JavascriptObjectRepository - Return objects by name or return all by default Untabify CefAppUnmanagedWrapper.cpp Add minor comment to CefBrowserWrapper for a reminder that we use Frame Identifier as dictionary key * Add //TODO: JSB comments for work that's left to be done Ideally within a render process we cache bound objects once they've been communicated, It would also be nice to make multiple binding requests so objects can later be added dynamically * JSB Allow multiple calls to CefSharp.RegisterBoundObject Update BindingTest.html to name two distinct calls to different bound objects * JSB - Add some notes about caching, no working implementation yet * JSB - Dynamically Register object on Request * JSB Add ability to unbind an object and rename RegisterBoundObject to BindObjectAsync # Conflicts: # CefSharp.Example/Resources/BindingTest.html * JSB BindObjectAsync - if objects already bound then return false * JSB - Ignore Indexer properties Were previously throwing an exception * JSB - Add LegacyJavascriptBindingEnabled option so preserve existing behaviour This is only useful for SPA application and those that only navigate to pages hosting within a single domain. Any sort of cross-site navigation and a new render process will be spawned and objects won't be bound automatically (You can use the new methods to request they're bound yourself, at least in theory, more testing required on this) * Add LegacyBindingTest.html Current disabled by default. To enable uncomment CefSharpSettings.LegacyJavascriptBindingEnabled = true; in CefExample.cs * RegisterJsObject and RegisterAsyncJsObject can now only be used when CefSharpSettings.LegacyJavascriptBindingEnabled = true See https://github.com/cefsharp/CefSharp/issues/2246 for details
2018-01-22 10:24:25 +10:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
JavascriptAsyncMethodCallback^ callback;
Implement Javascript Binding v2 (#2247) * JSB Rewrite - Add CefSharp.RegisterBoundObject javascript method To get around the problem of IPC timing, I've reversed the communication, now it's the render process requesting the bound objects, the implementation is incomplete at this stage, more just a basic proof of concept Rewrite BindingTest.html using QUnit One of the tests doesn't map correctly as it requires def user interaction TODO: - Get objects by name - Rename Messages.h values that relate to this change so they are more descriptive - Better error handling - Caching of objects within a render process - Investigate global context options, don't think it's possible to call an async method directly in the global context # Conflicts: # CefSharp.Example/Resources/BindingTest.html * JSB Improve Request/Response message names * BindingTest.html - Output stress test results * Remove JavascriptRootObject was leftover from time we used WCF to transmit objects * JavascriptObjectRepository - Objects are now sent in the same list with an IsAsync flag Separation when sending over IPC with two unique lists isn't necessary * JavascriptObjectRepository - Return objects by name or return all by default Untabify CefAppUnmanagedWrapper.cpp Add minor comment to CefBrowserWrapper for a reminder that we use Frame Identifier as dictionary key * Add //TODO: JSB comments for work that's left to be done Ideally within a render process we cache bound objects once they've been communicated, It would also be nice to make multiple binding requests so objects can later be added dynamically * JSB Allow multiple calls to CefSharp.RegisterBoundObject Update BindingTest.html to name two distinct calls to different bound objects * JSB - Add some notes about caching, no working implementation yet * JSB - Dynamically Register object on Request * JSB Add ability to unbind an object and rename RegisterBoundObject to BindObjectAsync # Conflicts: # CefSharp.Example/Resources/BindingTest.html * JSB BindObjectAsync - if objects already bound then return false * JSB - Ignore Indexer properties Were previously throwing an exception * JSB - Add LegacyJavascriptBindingEnabled option so preserve existing behaviour This is only useful for SPA application and those that only navigate to pages hosting within a single domain. Any sort of cross-site navigation and a new render process will be spawned and objects won't be bound automatically (You can use the new methods to request they're bound yourself, at least in theory, more testing required on this) * Add LegacyBindingTest.html Current disabled by default. To enable uncomment CefSharpSettings.LegacyJavascriptBindingEnabled = true; in CefExample.cs * RegisterJsObject and RegisterAsyncJsObject can now only be used when CefSharpSettings.LegacyJavascriptBindingEnabled = true See https://github.com/cefsharp/CefSharp/issues/2246 for details
2018-01-22 10:24:25 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
try
Javascript Legacy Binding - Pass objects on CefBrowserHost::CreateBrowser Previously objects were sent in OnRenderViewReady, which is only called once for a browser instance, not for process switches Now objects are passed when the browser is created, still need to check for popup handling
2019-06-14 14:29:53 +10:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
rootObject->Bind(javascriptObjects, context->GetGlobal());
JSB Add Caching Bound object meta data is cached within a render process CefSharp.IsObjectCached - JS method to test if object cached CefSharp.RemoveObjectFromCache - JS method to remove object from cache If a request is made for multiple objects with not all of them being cached then a IPC message is sent. When all objects already bound return response object for consistency FindBrowserWrapper signature change - it's really not safe to throw a managed exception in the middle of unmanaged code, changed to logging and null checking JavascriptObjectRepository - Add All Constant - Used when All objects are requested for binding (objects can also be requested by name) TODO: Add a JS library to improve user experience when dealing with cached objects
2018-01-29 15:48:54 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
if (_registerBoundObjectRegistry->TryGetAndRemoveMethodCallback(callbackId, callback))
Javascript Legacy Binding - Pass objects on CefBrowserHost::CreateBrowser Previously objects were sent in OnRenderViewReady, which is only called once for a browser instance, not for process switches Now objects are passed when the browser is created, still need to check for popup handling
2019-06-14 14:29:53 +10:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
//Response object has no Accessor or Interceptor
C++/CLI - Replace NULL with nullptr Issue #3636
2021-07-31 15:35:38 +10:00
auto response = CefV8Value::CreateObject(nullptr, nullptr);
Implement Javascript Binding v2 (#2247) * JSB Rewrite - Add CefSharp.RegisterBoundObject javascript method To get around the problem of IPC timing, I've reversed the communication, now it's the render process requesting the bound objects, the implementation is incomplete at this stage, more just a basic proof of concept Rewrite BindingTest.html using QUnit One of the tests doesn't map correctly as it requires def user interaction TODO: - Get objects by name - Rename Messages.h values that relate to this change so they are more descriptive - Better error handling - Caching of objects within a render process - Investigate global context options, don't think it's possible to call an async method directly in the global context # Conflicts: # CefSharp.Example/Resources/BindingTest.html * JSB Improve Request/Response message names * BindingTest.html - Output stress test results * Remove JavascriptRootObject was leftover from time we used WCF to transmit objects * JavascriptObjectRepository - Objects are now sent in the same list with an IsAsync flag Separation when sending over IPC with two unique lists isn't necessary * JavascriptObjectRepository - Return objects by name or return all by default Untabify CefAppUnmanagedWrapper.cpp Add minor comment to CefBrowserWrapper for a reminder that we use Frame Identifier as dictionary key * Add //TODO: JSB comments for work that's left to be done Ideally within a render process we cache bound objects once they've been communicated, It would also be nice to make multiple binding requests so objects can later be added dynamically * JSB Allow multiple calls to CefSharp.RegisterBoundObject Update BindingTest.html to name two distinct calls to different bound objects * JSB - Add some notes about caching, no working implementation yet * JSB - Dynamically Register object on Request * JSB Add ability to unbind an object and rename RegisterBoundObject to BindObjectAsync # Conflicts: # CefSharp.Example/Resources/BindingTest.html * JSB BindObjectAsync - if objects already bound then return false * JSB - Ignore Indexer properties Were previously throwing an exception * JSB - Add LegacyJavascriptBindingEnabled option so preserve existing behaviour This is only useful for SPA application and those that only navigate to pages hosting within a single domain. Any sort of cross-site navigation and a new render process will be spawned and objects won't be bound automatically (You can use the new methods to request they're bound yourself, at least in theory, more testing required on this) * Add LegacyBindingTest.html Current disabled by default. To enable uncomment CefSharpSettings.LegacyJavascriptBindingEnabled = true; in CefExample.cs * RegisterJsObject and RegisterAsyncJsObject can now only be used when CefSharpSettings.LegacyJavascriptBindingEnabled = true See https://github.com/cefsharp/CefSharp/issues/2246 for details
2018-01-22 10:24:25 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
response->SetValue("Count", CefV8Value::CreateInt(javascriptObjects->Count), CefV8Value::PropertyAttribute::V8_PROPERTY_ATTRIBUTE_READONLY);
IJavascriptObjectRepositry - Add ObjectBoundInJavascript event Executed on the thread pool when objects are bound in JS
2018-01-22 11:59:13 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
if (javascriptObjects->Count > 0)
{
//TODO: JSB Should we include a list of successfully bound object names?
response->SetValue("Success", CefV8Value::CreateBool(true), CefV8Value::PropertyAttribute::V8_PROPERTY_ATTRIBUTE_READONLY);
response->SetValue("Message", CefV8Value::CreateString("OK"), CefV8Value::PropertyAttribute::V8_PROPERTY_ATTRIBUTE_READONLY);
callback->Success(response);
}
else
{
response->SetValue("Success", CefV8Value::CreateBool(false), CefV8Value::PropertyAttribute::V8_PROPERTY_ATTRIBUTE_READONLY);
response->SetValue("Message", CefV8Value::CreateString("Zero objects bounds"), CefV8Value::PropertyAttribute::V8_PROPERTY_ATTRIBUTE_READONLY);
callback->Success(response);
}
IJavascriptObjectRepositry - Add ObjectBoundInJavascript event Executed on the thread pool when objects are bound in JS
2018-01-22 11:59:13 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
//Send message notifying Browser Process of which objects were bound
//We do this after the objects have been created in the V8Context to gurantee
//they are accessible.
auto msg = CefProcessMessage::Create(kJavascriptObjectsBoundInJavascript);
auto args = msg->GetArgumentList();
JSB - Add JavascriptBindingCompleteEventArgs and config options to CefSharp.BindObjectAsync CefSharp.BindObjectAsync can now take an optional config object as first param Include additional information when binding complete Add option for cefSharp.bindObjectAsync (starting with lowercase latters) Add new syntax options - not entirely complete, no variant for the options object Add ignore cache option
2018-04-26 10:20:39 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
auto boundObjects = CefListValue::Create();
IJavascriptObjectRepositry - Add ObjectBoundInJavascript event Executed on the thread pool when objects are bound in JS
2018-01-22 11:59:13 +10:00
Core - Fix CPP compiler warnings
2026-02-20 21:08:41 +10:00
auto i = 0;
for each (auto jsObject in javascriptObjects)
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
{
auto dict = CefDictionaryValue::Create();
Core - Fix CPP compiler warnings
2026-02-20 21:08:41 +10:00
auto objectName = jsObject->JavascriptName;
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
dict->SetString("Name", StringUtils::ToNative(objectName));
dict->SetBool("IsCached", false);
dict->SetBool("AlreadyBound", false);
IJavascriptObjectRepository.ObjectBoundInJavascript - Fix bug and add example
2018-01-22 12:18:17 +10:00
Core - Fix CPP compiler warnings
2026-02-20 21:08:41 +10:00
boundObjects->SetDictionary(i++, dict);
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
}
args->SetList(0, boundObjects);
frame->SendProcessMessage(CefProcessId::PID_BROWSER, msg);
}
Implement Javascript Binding v2 (#2247) * JSB Rewrite - Add CefSharp.RegisterBoundObject javascript method To get around the problem of IPC timing, I've reversed the communication, now it's the render process requesting the bound objects, the implementation is incomplete at this stage, more just a basic proof of concept Rewrite BindingTest.html using QUnit One of the tests doesn't map correctly as it requires def user interaction TODO: - Get objects by name - Rename Messages.h values that relate to this change so they are more descriptive - Better error handling - Caching of objects within a render process - Investigate global context options, don't think it's possible to call an async method directly in the global context # Conflicts: # CefSharp.Example/Resources/BindingTest.html * JSB Improve Request/Response message names * BindingTest.html - Output stress test results * Remove JavascriptRootObject was leftover from time we used WCF to transmit objects * JavascriptObjectRepository - Objects are now sent in the same list with an IsAsync flag Separation when sending over IPC with two unique lists isn't necessary * JavascriptObjectRepository - Return objects by name or return all by default Untabify CefAppUnmanagedWrapper.cpp Add minor comment to CefBrowserWrapper for a reminder that we use Frame Identifier as dictionary key * Add //TODO: JSB comments for work that's left to be done Ideally within a render process we cache bound objects once they've been communicated, It would also be nice to make multiple binding requests so objects can later be added dynamically * JSB Allow multiple calls to CefSharp.RegisterBoundObject Update BindingTest.html to name two distinct calls to different bound objects * JSB - Add some notes about caching, no working implementation yet * JSB - Dynamically Register object on Request * JSB Add ability to unbind an object and rename RegisterBoundObject to BindObjectAsync # Conflicts: # CefSharp.Example/Resources/BindingTest.html * JSB BindObjectAsync - if objects already bound then return false * JSB - Ignore Indexer properties Were previously throwing an exception * JSB - Add LegacyJavascriptBindingEnabled option so preserve existing behaviour This is only useful for SPA application and those that only navigate to pages hosting within a single domain. Any sort of cross-site navigation and a new render process will be spawned and objects won't be bound automatically (You can use the new methods to request they're bound yourself, at least in theory, more testing required on this) * Add LegacyBindingTest.html Current disabled by default. To enable uncomment CefSharpSettings.LegacyJavascriptBindingEnabled = true; in CefExample.cs * RegisterJsObject and RegisterAsyncJsObject can now only be used when CefSharpSettings.LegacyJavascriptBindingEnabled = true See https://github.com/cefsharp/CefSharp/issues/2246 for details
2018-01-22 10:24:25 +10:00
}
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
finally
{
context->Exit();
CefAppUnmanagedWrapper - Minor refactor in kJavascriptRootObjectResponse and kJavascriptAsyncMethodCallResponse kJavascriptRootObjectResponse - delete the callback when not used kJavascriptAsyncMethodCallResponse - Only execute if we have a valid frame
2019-07-20 18:28:36 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
delete callback;
}
Javascript Legacy Binding - Pass objects on CefBrowserHost::CreateBrowser Previously objects were sent in OnRenderViewReady, which is only called once for a browser instance, not for process switches Now objects are passed when the browser is created, still need to check for popup handling
2019-06-14 14:29:53 +10:00
}
Implement Javascript Binding v2 (#2247) * JSB Rewrite - Add CefSharp.RegisterBoundObject javascript method To get around the problem of IPC timing, I've reversed the communication, now it's the render process requesting the bound objects, the implementation is incomplete at this stage, more just a basic proof of concept Rewrite BindingTest.html using QUnit One of the tests doesn't map correctly as it requires def user interaction TODO: - Get objects by name - Rename Messages.h values that relate to this change so they are more descriptive - Better error handling - Caching of objects within a render process - Investigate global context options, don't think it's possible to call an async method directly in the global context # Conflicts: # CefSharp.Example/Resources/BindingTest.html * JSB Improve Request/Response message names * BindingTest.html - Output stress test results * Remove JavascriptRootObject was leftover from time we used WCF to transmit objects * JavascriptObjectRepository - Objects are now sent in the same list with an IsAsync flag Separation when sending over IPC with two unique lists isn't necessary * JavascriptObjectRepository - Return objects by name or return all by default Untabify CefAppUnmanagedWrapper.cpp Add minor comment to CefBrowserWrapper for a reminder that we use Frame Identifier as dictionary key * Add //TODO: JSB comments for work that's left to be done Ideally within a render process we cache bound objects once they've been communicated, It would also be nice to make multiple binding requests so objects can later be added dynamically * JSB Allow multiple calls to CefSharp.RegisterBoundObject Update BindingTest.html to name two distinct calls to different bound objects * JSB - Add some notes about caching, no working implementation yet * JSB - Dynamically Register object on Request * JSB Add ability to unbind an object and rename RegisterBoundObject to BindObjectAsync # Conflicts: # CefSharp.Example/Resources/BindingTest.html * JSB BindObjectAsync - if objects already bound then return false * JSB - Ignore Indexer properties Were previously throwing an exception * JSB - Add LegacyJavascriptBindingEnabled option so preserve existing behaviour This is only useful for SPA application and those that only navigate to pages hosting within a single domain. Any sort of cross-site navigation and a new render process will be spawned and objects won't be bound automatically (You can use the new methods to request they're bound yourself, at least in theory, more testing required on this) * Add LegacyBindingTest.html Current disabled by default. To enable uncomment CefSharpSettings.LegacyJavascriptBindingEnabled = true; in CefExample.cs * RegisterJsObject and RegisterAsyncJsObject can now only be used when CefSharpSettings.LegacyJavascriptBindingEnabled = true See https://github.com/cefsharp/CefSharp/issues/2246 for details
2018-01-22 10:24:25 +10:00
}
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
else
{
LOG(INFO) << "CefAppUnmanagedWrapper Frame Invalid";
}
Implement Javascript Binding v2 (#2247) * JSB Rewrite - Add CefSharp.RegisterBoundObject javascript method To get around the problem of IPC timing, I've reversed the communication, now it's the render process requesting the bound objects, the implementation is incomplete at this stage, more just a basic proof of concept Rewrite BindingTest.html using QUnit One of the tests doesn't map correctly as it requires def user interaction TODO: - Get objects by name - Rename Messages.h values that relate to this change so they are more descriptive - Better error handling - Caching of objects within a render process - Investigate global context options, don't think it's possible to call an async method directly in the global context # Conflicts: # CefSharp.Example/Resources/BindingTest.html * JSB Improve Request/Response message names * BindingTest.html - Output stress test results * Remove JavascriptRootObject was leftover from time we used WCF to transmit objects * JavascriptObjectRepository - Objects are now sent in the same list with an IsAsync flag Separation when sending over IPC with two unique lists isn't necessary * JavascriptObjectRepository - Return objects by name or return all by default Untabify CefAppUnmanagedWrapper.cpp Add minor comment to CefBrowserWrapper for a reminder that we use Frame Identifier as dictionary key * Add //TODO: JSB comments for work that's left to be done Ideally within a render process we cache bound objects once they've been communicated, It would also be nice to make multiple binding requests so objects can later be added dynamically * JSB Allow multiple calls to CefSharp.RegisterBoundObject Update BindingTest.html to name two distinct calls to different bound objects * JSB - Add some notes about caching, no working implementation yet * JSB - Dynamically Register object on Request * JSB Add ability to unbind an object and rename RegisterBoundObject to BindObjectAsync # Conflicts: # CefSharp.Example/Resources/BindingTest.html * JSB BindObjectAsync - if objects already bound then return false * JSB - Ignore Indexer properties Were previously throwing an exception * JSB - Add LegacyJavascriptBindingEnabled option so preserve existing behaviour This is only useful for SPA application and those that only navigate to pages hosting within a single domain. Any sort of cross-site navigation and a new render process will be spawned and objects won't be bound automatically (You can use the new methods to request they're bound yourself, at least in theory, more testing required on this) * Add LegacyBindingTest.html Current disabled by default. To enable uncomment CefSharpSettings.LegacyJavascriptBindingEnabled = true; in CefExample.cs * RegisterJsObject and RegisterAsyncJsObject can now only be used when CefSharpSettings.LegacyJavascriptBindingEnabled = true See https://github.com/cefsharp/CefSharp/issues/2246 for details
2018-01-22 10:24:25 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
handled = true;
}
else if (name == kJavascriptAsyncMethodCallResponse)
CefAppUnmanagedWrapper - Minor refactor in kJavascriptRootObjectResponse and kJavascriptAsyncMethodCallResponse kJavascriptRootObjectResponse - delete the callback when not used kJavascriptAsyncMethodCallResponse - Only execute if we have a valid frame
2019-07-20 18:28:36 +10:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
if (frame.get() && frame->IsValid())
{
Change Frame identifier from Int64 to String (#4740) * Change Frame identifier from Int64 to String Issue https://github.com/cefsharp/CefSharp/issues/4737 * Fix SetCanExecuteJavascriptOnMainFrame frameId parsing * Add tests * NetCore Tests - Install missing packages
2024-03-09 06:55:27 +10:00
auto frameId = StringUtils::ToClr(frame->GetIdentifier());
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
auto callbackId = GetInt64(argList, 0);
Allow calling managed methods from objects bound with RegisterAsyncJsObject that return arrays of structs (#1981) * Fixed problem when calling CefV8Value::CreateArray. Needs prior call to V8 context enter * Call callback dispose in case of failure * Support serialization of struct arrays to JS side * Fixed formatting
2017-03-13 11:37:55 +00:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
JavascriptRootObjectWrapper^ rootObjectWrapper;
Core - Rewrite RenderProcess to avoid using OnBrowserDestroyed for JS eval (#5197) - JavascriptCallbackRegistry - Get BrowserId From V8Context - Render Process - Rewrite to store root object wrapper by frame instead of per browser - Don't store JavascriptRootObjectWrapper in the browserWrapper as CEF is calling destroyed more than it should. - Revert "Tests - Simplify ShouldFailWhenIsObjectCachedCalledWithInvalidObjectName" This reverts commit f8a81acf7abd270680f5c36fa165df948599f2a1. --------- Co-authored-by: amaitland <307872+amaitland@users.noreply.github.com>
2025-12-03 19:00:12 +10:00
_jsRootObjectWrappersByFrameId->TryGetValue(frameId, rootObjectWrapper);
Make js callbacks and async methods Frame aware - add FrameId so they can be executed on a specific frame Resolves a problem where multiple contexts are created and only the first one is dealt with properly (each frame has it's own V8 context)
2015-10-11 20:41:17 +10:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
if (rootObjectWrapper != nullptr)
Make js callbacks and async methods Frame aware - add FrameId so they can be executed on a specific frame Resolves a problem where multiple contexts are created and only the first one is dealt with properly (each frame has it's own V8 context)
2015-10-11 20:41:17 +10:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
JavascriptAsyncMethodCallback^ callback;
if (rootObjectWrapper->TryGetAndRemoveMethodCallback(callbackId, callback))
Allow calling managed methods from objects bound with RegisterAsyncJsObject that return arrays of structs (#1981) * Fixed problem when calling CefV8Value::CreateArray. Needs prior call to V8 context enter * Call callback dispose in case of failure * Support serialization of struct arrays to JS side * Fixed formatting
2017-03-13 11:37:55 +00:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
try
Allow calling managed methods from objects bound with RegisterAsyncJsObject that return arrays of structs (#1981) * Fixed problem when calling CefV8Value::CreateArray. Needs prior call to V8 context enter * Call callback dispose in case of failure * Support serialization of struct arrays to JS side * Fixed formatting
2017-03-13 11:37:55 +00:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
auto context = frame->GetV8Context();
if (context.get() && context->Enter())
Allow calling managed methods from objects bound with RegisterAsyncJsObject that return arrays of structs (#1981) * Fixed problem when calling CefV8Value::CreateArray. Needs prior call to V8 context enter * Call callback dispose in case of failure * Support serialization of struct arrays to JS side * Fixed formatting
2017-03-13 11:37:55 +00:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
try
Allow calling managed methods from objects bound with RegisterAsyncJsObject that return arrays of structs (#1981) * Fixed problem when calling CefV8Value::CreateArray. Needs prior call to V8 context enter * Call callback dispose in case of failure * Support serialization of struct arrays to JS side * Fixed formatting
2017-03-13 11:37:55 +00:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
auto success = argList->GetBool(1);
if (success)
{
callback->Success(DeserializeV8Object(argList, 2));
}
else
{
callback->Fail(argList->GetString(2));
}
Allow calling managed methods from objects bound with RegisterAsyncJsObject that return arrays of structs (#1981) * Fixed problem when calling CefV8Value::CreateArray. Needs prior call to V8 context enter * Call callback dispose in case of failure * Support serialization of struct arrays to JS side * Fixed formatting
2017-03-13 11:37:55 +00:00
}
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
finally
Allow calling managed methods from objects bound with RegisterAsyncJsObject that return arrays of structs (#1981) * Fixed problem when calling CefV8Value::CreateArray. Needs prior call to V8 context enter * Call callback dispose in case of failure * Support serialization of struct arrays to JS side * Fixed formatting
2017-03-13 11:37:55 +00:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
context->Exit();
Allow calling managed methods from objects bound with RegisterAsyncJsObject that return arrays of structs (#1981) * Fixed problem when calling CefV8Value::CreateArray. Needs prior call to V8 context enter * Call callback dispose in case of failure * Support serialization of struct arrays to JS side * Fixed formatting
2017-03-13 11:37:55 +00:00
}
}
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
else
Allow calling managed methods from objects bound with RegisterAsyncJsObject that return arrays of structs (#1981) * Fixed problem when calling CefV8Value::CreateArray. Needs prior call to V8 context enter * Call callback dispose in case of failure * Support serialization of struct arrays to JS side * Fixed formatting
2017-03-13 11:37:55 +00:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
callback->Fail("Unable to Enter Context");
Allow calling managed methods from objects bound with RegisterAsyncJsObject that return arrays of structs (#1981) * Fixed problem when calling CefV8Value::CreateArray. Needs prior call to V8 context enter * Call callback dispose in case of failure * Support serialization of struct arrays to JS side * Fixed formatting
2017-03-13 11:37:55 +00:00
}
}
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
finally
Allow calling managed methods from objects bound with RegisterAsyncJsObject that return arrays of structs (#1981) * Fixed problem when calling CefV8Value::CreateArray. Needs prior call to V8 context enter * Call callback dispose in case of failure * Support serialization of struct arrays to JS side * Fixed formatting
2017-03-13 11:37:55 +00:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
//dispose
delete callback;
Allow calling managed methods from objects bound with RegisterAsyncJsObject that return arrays of structs (#1981) * Fixed problem when calling CefV8Value::CreateArray. Needs prior call to V8 context enter * Call callback dispose in case of failure * Support serialization of struct arrays to JS side * Fixed formatting
2017-03-13 11:37:55 +00:00
}
}
Make js callbacks and async methods Frame aware - add FrameId so they can be executed on a specific frame Resolves a problem where multiple contexts are created and only the first one is dealt with properly (each frame has it's own V8 context)
2015-10-11 20:41:17 +10:00
}
added callback capability for async bound method with promises
2015-07-14 15:09:50 +02:00
}
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
handled = true;
added callback capability for async bound method with promises
2015-07-14 15:09:50 +02:00
}
added process message handlers and code to call them on both sides
2015-06-27 17:01:51 +02:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
return handled;
};
added callback capability for async bound method with promises
2015-07-14 15:09:50 +02:00
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
void CefAppUnmanagedWrapper::OnWebKitInitialized()
Extensions transmitted in OnRenderThreadCreated and registered after webkit initialization
2015-08-01 20:25:12 +02:00
{
BrowserSubprocess - Namespace cleanup Possibly a few cases that were missed, this should be the bulk of the rename Resolves #3253
2021-02-27 12:11:35 +10:00
if (!Object::ReferenceEquals(_handler, nullptr))
{
_handler->OnWebKitInitialized();
}
Extensions transmitted in OnRenderThreadCreated and registered after webkit initialization
2015-08-01 20:25:12 +02:00
}
added callback capability for async bound method with promises
2015-07-14 15:09:50 +02:00
}
CefAppUnmanagedWrapper::OnContextCreated - Fixed up merge mistake IPC message was only sent for main frame Follow up #2373
2018-10-28 16:52:21 +10:00
}
Reference in New Issue Copy Permalink