fix: [ENG-2858] address PR review feedback on sidecar wiring
Five reviewer issues: 1. Access-hit scoring: bumpSidecarOnQueryRead now mirrors SearchKnowledgeService.mirrorHitsToSignalStore — applies recordAccessHits (bumps accessCount AND importance) and re-evaluates maturity via determineTier. Bumping accessCount alone would let prune ignore frequently-read topics. 2. Windows path normalization: curate-session.ts forward-slash-normalizes the sidecar key via .replaceAll(sep, '/') to match the daemon's curate-html-direct path. Without this, the same topic hashes to two different sidecar entries on Windows. 3. Shared-source filter: SearchExecutor now skips results with origin === 'shared' before bumping the sidecar — those paths belong to a different context tree and would either orphan an entry or collide with a same-named local topic. 4. QueryExecutor TDD coverage: three new tests verify executeToolMode bumps accessCount on matched paths, returns envelope unchanged when no store is wired, and skips the bump on empty matches. 5. Logger wiring: write call sites (daemon agent-process and CLI curate-session) now pass loggers into bumpSidecarOnCurateWrite so swallowed failures leave breadcrumbs. Executor read paths skip the logger by design (documented in the helper) to avoid stderr spam on bulk reads; the underlying RuntimeSignalStore retains its own logger.
N
Nguyễn Thuận Phát committed
aeb5801b553aed0b3a9dbead255398b3e4a8b2d0
Parent: 6a9b256