Morph MORPH
SIGN IN SIGN UP
facebook / hermes UNCLAIMED

A JavaScript engine optimized for running React Native.

0 0 37 JavaScript
Normal View History Raw
Introduce StackExecutor Summary: StackExecutor is a new API that synchronously executes a callback in a fresh stack. This enables invocation of potentially deeply recursive code, like the Hermes parser, without concern of the current stack state. This diff provides only a default implementation using a thread (SerialExecutor), which isn't very efficient. Reviewed By: avp Differential Revision: D66343422 fbshipit-source-id: fe9994b8187590431189537ac84e5dfb3ddf680f
2024-11-22 12:19:49 -08:00
/*
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
#include "hermes/Support/StackExecutor.h"
Use Boost.Context instead of SerialExecutor Summary: Implement `StackExecutor` with `Boost.Context`. Reviewed By: avp Differential Revision: D66214582 fbshipit-source-id: a312043777a42e0731d37af6e4d73bbf89b5077a
2024-12-06 10:36:13 -08:00
#if defined(HERMES_USE_BOOST_CONTEXT) && HERMES_USE_BOOST_CONTEXT
#include "llvh/Support/Debug.h"
#include "llvh/Support/raw_ostream.h"
EASY: Suppress -Wundef in boost via pragma instead of patching headers Summary: Revert the patches to vendored boost headers (config.hpp, fiber_fcontext.hpp) and instead suppress -Wundef with a pragma push/pop around the boost includes in StackExecutor.cpp. This is the same approach used for dragonbox and avoids modifying vendored source. Reviewed By: avp Differential Revision: D95308162 fbshipit-source-id: 23b6688e057b567221b312279ec054dd209f767f
2026-03-04 18:58:18 -08:00
// Boost headers use #if on macros that may not be defined, triggering -Wundef.
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wundef"
Complete rename of Boost to Hoost (#1574) Summary: Pull Request resolved: https://github.com/facebook/hermes/pull/1574 Change the include paths from `boost/` to `hoost/`. Reviewed By: avp Differential Revision: D66799413 fbshipit-source-id: 3e52c4e57ff2561272d1068d4f15df2f16fa8fec
2024-12-06 10:36:13 -08:00
#include <hoost/context/fiber.hpp>
#include <hoost/context/protected_fixedsize_stack.hpp>
EASY: Suppress -Wundef in boost via pragma instead of patching headers Summary: Revert the patches to vendored boost headers (config.hpp, fiber_fcontext.hpp) and instead suppress -Wundef with a pragma push/pop around the boost includes in StackExecutor.cpp. This is the same approach used for dragonbox and avoids modifying vendored source. Reviewed By: avp Differential Revision: D95308162 fbshipit-source-id: 23b6688e057b567221b312279ec054dd209f767f
2026-03-04 18:58:18 -08:00
#pragma GCC diagnostic pop
Use Boost.Context instead of SerialExecutor Summary: Implement `StackExecutor` with `Boost.Context`. Reviewed By: avp Differential Revision: D66214582 fbshipit-source-id: a312043777a42e0731d37af6e4d73bbf89b5077a
2024-12-06 10:36:13 -08:00
#include <cassert>
#define DEBUG_TYPE "StackExecutor"
namespace ctx = boost::context;
namespace hermes {
class StackExecutor {
/// The argument to be passed to the callee.
void *arg_ = nullptr;
/// The callee to be invoked by the fiber each time it is resumed. If it is
/// nullptr when the fiber is resumed, the fiber terminates.
void (*fn_)(void *) = nullptr;
/// The fiber with its own stack.
ctx::fiber fiber_;
public:
explicit StackExecutor(size_t stackSize = 0)
: fiber_(
std::allocator_arg,
ctx::protected_fixedsize_stack(
stackSize ? stackSize : ctx::stack_traits::default_size()),
[this](ctx::fiber &&next) {
// Loop until the callee becomes nullptr.
while (fn_) {
LLVM_DEBUG(llvh::dbgs() << "StackExecutor running function\n");
(*fn_)(arg_);
LLVM_DEBUG(llvh::dbgs() << "StackExecutor function done\n");
next = std::move(next).resume();
}
LLVM_DEBUG(llvh::dbgs() << "Ending StackExecutor fiber\n");
// The std::move() here is required by older compilers.
return std::move(next);
}) {}
/// Execute the specified function in the fiber.
void exec(void *arg, void (*fn)(void *arg)) {
assert(fn_ == nullptr && "StackExecutor recursive call??");
arg_ = arg;
fn_ = fn;
fiber_ = std::move(fiber_).resume();
arg_ = nullptr;
fn_ = nullptr;
}
~StackExecutor() {
LLVM_DEBUG(llvh::dbgs() << "~StackExecutor");
assert(fn_ == nullptr && "StackExecutor recursive call??");
// Tell the fiber to terminate.
fiber_ = std::move(fiber_).resume();
}
};
std::shared_ptr<StackExecutor> newStackExecutor(
size_t stackSize,
std::chrono::milliseconds /*timeout*/) {
return std::make_shared<StackExecutor>(stackSize);
}
void executeInStack(StackExecutor &exec, void *arg, void (*func)(void *arg)) {
exec.exec(arg, func);
}
} // namespace hermes
StackExecutor: noop on Wasm without threads Summary: When targeting a threadless Wasm environment, StackExecutor cannot rely on creating another thread, so make it just call the function directly, which is better than failing. Reviewed By: fbmal7 Differential Revision: D67594745 fbshipit-source-id: 8ea2c3c43d3a6f5360151e11a7ef00f5a0309506
2024-12-23 13:25:40 -08:00
#elif defined(__wasm__) && !defined(__EMSCRIPTEN_THREADS__)
namespace hermes {
#pragma message("Warning: StackExecutor is no-op in Wasm without threads!")
class StackExecutor {
public:
};
std::shared_ptr<StackExecutor> newStackExecutor(
size_t stackSize,
std::chrono::milliseconds) {
return std::make_shared<StackExecutor>();
}
void executeInStack(StackExecutor &exec, void *arg, void (*func)(void *arg)) {
func(arg);
}
} // namespace hermes
Use Boost.Context instead of SerialExecutor Summary: Implement `StackExecutor` with `Boost.Context`. Reviewed By: avp Differential Revision: D66214582 fbshipit-source-id: a312043777a42e0731d37af6e4d73bbf89b5077a
2024-12-06 10:36:13 -08:00
#else
Introduce StackExecutor Summary: StackExecutor is a new API that synchronously executes a callback in a fresh stack. This enables invocation of potentially deeply recursive code, like the Hermes parser, without concern of the current stack state. This diff provides only a default implementation using a thread (SerialExecutor), which isn't very efficient. Reviewed By: avp Differential Revision: D66343422 fbshipit-source-id: fe9994b8187590431189537ac84e5dfb3ddf680f
2024-11-22 12:19:49 -08:00
#include "hermes/Support/SerialExecutor.h"
#include <future>
namespace hermes {
class StackExecutor {
public:
SerialExecutor executor;
explicit StackExecutor(size_t stackSize, std::chrono::milliseconds timeout)
: executor(stackSize, timeout) {}
};
std::shared_ptr<StackExecutor> newStackExecutor(
size_t stackSize,
std::chrono::milliseconds timeout) {
return std::make_shared<StackExecutor>(stackSize, timeout);
}
void executeInStack(StackExecutor &exec, void *arg, void (*func)(void *arg)) {
std::packaged_task<void()> task([arg, func]() { func(arg); });
auto future = task.get_future();
exec.executor.add([&task]() { task(); });
future.wait();
}
} // namespace hermes
Use Boost.Context instead of SerialExecutor Summary: Implement `StackExecutor` with `Boost.Context`. Reviewed By: avp Differential Revision: D66214582 fbshipit-source-id: a312043777a42e0731d37af6e4d73bbf89b5077a
2024-12-06 10:36:13 -08:00
#endif
Reference in New Issue Copy Permalink