Morph MORPH
SIGN IN SIGN UP
laravel / framework UNCLAIMED

Laravel is a web application framework with expressive, elegant syntax.

0 0 2 PHP
Normal View History Raw
[8.x] Conditional rules (#38361) * conditional rules * simplify some code * allow closures on conditional * Apply fixes from StyleCI * fix type hint Co-authored-by: Taylor Otwell <taylorotwell@users.noreply.github.com>
2021-08-12 15:27:53 -05:00
<?php
namespace Illuminate\Tests\Validation;
[8.x] Use `Fluent` instead of `array` on `Rule::when()` (#38397) Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
2021-08-16 21:21:52 +08:00
use Illuminate\Support\Fluent;
[8.x] Conditional rules (#38361) * conditional rules * simplify some code * allow closures on conditional * Apply fixes from StyleCI * fix type hint Co-authored-by: Taylor Otwell <taylorotwell@users.noreply.github.com>
2021-08-12 15:27:53 -05:00
use Illuminate\Validation\Rule;
use Illuminate\Validation\ValidationRuleParser;
use PHPUnit\Framework\TestCase;
class ValidationRuleParserTest extends TestCase
{
Add ability to nested validation rules
2022-01-19 11:52:41 -05:00
public function testConditionalRulesAreProperlyExpandedAndFiltered()
[8.x] Conditional rules (#38361) * conditional rules * simplify some code * allow closures on conditional * Apply fixes from StyleCI * fix type hint Co-authored-by: Taylor Otwell <taylorotwell@users.noreply.github.com>
2021-08-12 15:27:53 -05:00
{
[10.x] Add unless conditional on validation rules (#49048) * Add unless * Add tests * Formatting * Update Rule.php --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
2023-11-20 17:33:39 +02:00
$isAdmin = true;
[8.x] Conditional rules (#38361) * conditional rules * simplify some code * allow closures on conditional * Apply fixes from StyleCI * fix type hint Co-authored-by: Taylor Otwell <taylorotwell@users.noreply.github.com>
2021-08-12 15:27:53 -05:00
$rules = ValidationRuleParser::filterConditionalRules([
[10.x] Add unless conditional on validation rules (#49048) * Add unless * Add tests * Formatting * Update Rule.php --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
2023-11-20 17:33:39 +02:00
'name' => Rule::when($isAdmin, ['required', 'min:2']),
'email' => Rule::unless($isAdmin, ['required', 'min:2']),
'password' => Rule::when($isAdmin, 'required|min:2'),
'username' => ['required', Rule::when($isAdmin, ['min:2'])],
'address' => ['required', Rule::unless($isAdmin, ['min:2'])],
[8.x] Use `Fluent` instead of `array` on `Rule::when()` (#38397) Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
2021-08-16 21:21:52 +08:00
'city' => ['required', Rule::when(function (Fluent $input) {
[8.x] Conditional rules (#38361) * conditional rules * simplify some code * allow closures on conditional * Apply fixes from StyleCI * fix type hint Co-authored-by: Taylor Otwell <taylorotwell@users.noreply.github.com>
2021-08-12 15:27:53 -05:00
return true;
}, ['min:2'])],
[10.x] Add unless conditional on validation rules (#49048) * Add unless * Add tests * Formatting * Update Rule.php --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
2023-11-20 17:33:39 +02:00
'state' => ['required', Rule::when($isAdmin, function (Fluent $input) {
[9.x] Add ability to supply additional callbacks in Rule::when (#40730) * Add ability to supply callbacks in conditional rules * Revert call_user_func * Spacing
2022-02-01 09:50:14 -05:00
return 'min:2';
})],
[10.x] Add unless conditional on validation rules (#49048) * Add unless * Add tests * Formatting * Update Rule.php --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
2023-11-20 17:33:39 +02:00
'zip' => ['required', Rule::when($isAdmin, function (Fluent $input) {
[9.x] Add ability to supply additional callbacks in Rule::when (#40730) * Add ability to supply callbacks in conditional rules * Revert call_user_func * Spacing
2022-02-01 09:50:14 -05:00
return ['min:2'];
})],
fix Rule::unless for callable (#49726)
2024-01-17 22:16:48 +01:00
'when_cb_true' => Rule::when(fn () => true, ['required'], ['nullable']),
'when_cb_false' => Rule::when(fn () => false, ['required'], ['nullable']),
'unless_cb_true' => Rule::unless(fn () => true, ['required'], ['nullable']),
'unless_cb_false' => Rule::unless(fn () => false, ['required'], ['nullable']),
[8.x] Conditional rules (#38361) * conditional rules * simplify some code * allow closures on conditional * Apply fixes from StyleCI * fix type hint Co-authored-by: Taylor Otwell <taylorotwell@users.noreply.github.com>
2021-08-12 15:27:53 -05:00
]);
$this->assertEquals([
'name' => ['required', 'min:2'],
[8.x] Fix bug discarding input fields with empty validation rules (#38563) * Add failing tests * Fix `ValidationRuleParser` to ignore and preserve empty rules
2021-08-26 17:16:55 -04:00
'email' => [],
[8.x] Conditional rules (#38361) * conditional rules * simplify some code * allow closures on conditional * Apply fixes from StyleCI * fix type hint Co-authored-by: Taylor Otwell <taylorotwell@users.noreply.github.com>
2021-08-12 15:27:53 -05:00
'password' => ['required', 'min:2'],
'username' => ['required', 'min:2'],
'address' => ['required'],
'city' => ['required', 'min:2'],
[9.x] Add ability to supply additional callbacks in Rule::when (#40730) * Add ability to supply callbacks in conditional rules * Revert call_user_func * Spacing
2022-02-01 09:50:14 -05:00
'state' => ['required', 'min:2'],
'zip' => ['required', 'min:2'],
fix Rule::unless for callable (#49726)
2024-01-17 22:16:48 +01:00
'when_cb_true' => ['required'],
'when_cb_false' => ['nullable'],
'unless_cb_true' => ['nullable'],
'unless_cb_false' => ['required'],
[8.x] Conditional rules (#38361) * conditional rules * simplify some code * allow closures on conditional * Apply fixes from StyleCI * fix type hint Co-authored-by: Taylor Otwell <taylorotwell@users.noreply.github.com>
2021-08-12 15:27:53 -05:00
], $rules);
}
[8.x] Add default rules in conditional rules (#38450) * Add default rules in conditional rules * formatting Co-authored-by: Taylor Otwell <taylorotwell@gmail.com>
2021-08-19 22:58:29 +02:00
Add ability to nested validation rules
2022-01-19 11:52:41 -05:00
public function testEmptyRulesArePreserved()
[8.x] Fix bug discarding input fields with empty validation rules (#38563) * Add failing tests * Fix `ValidationRuleParser` to ignore and preserve empty rules
2021-08-26 17:16:55 -04:00
{
[10.x] Add unless conditional on validation rules (#49048) * Add unless * Add tests * Formatting * Update Rule.php --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
2023-11-20 17:33:39 +02:00
$isAdmin = true;
[8.x] Fix bug discarding input fields with empty validation rules (#38563) * Add failing tests * Fix `ValidationRuleParser` to ignore and preserve empty rules
2021-08-26 17:16:55 -04:00
$rules = ValidationRuleParser::filterConditionalRules([
'name' => [],
'email' => '',
[10.x] Add unless conditional on validation rules (#49048) * Add unless * Add tests * Formatting * Update Rule.php --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
2023-11-20 17:33:39 +02:00
'password' => Rule::when($isAdmin, 'required|min:2'),
'gender' => Rule::unless($isAdmin, 'required'),
[8.x] Fix bug discarding input fields with empty validation rules (#38563) * Add failing tests * Fix `ValidationRuleParser` to ignore and preserve empty rules
2021-08-26 17:16:55 -04:00
]);
$this->assertEquals([
'name' => [],
'email' => '',
'password' => ['required', 'min:2'],
[10.x] Add unless conditional on validation rules (#49048) * Add unless * Add tests * Formatting * Update Rule.php --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
2023-11-20 17:33:39 +02:00
'gender' => [],
[8.x] Fix bug discarding input fields with empty validation rules (#38563) * Add failing tests * Fix `ValidationRuleParser` to ignore and preserve empty rules
2021-08-26 17:16:55 -04:00
], $rules);
}
Fix deprecation with empty rules (#42213)
2022-05-02 15:55:57 +02:00
public function testEmptyRulesCanBeExploded()
{
$parser = new ValidationRuleParser(['foo' => 'bar']);
$this->assertIsObject($parser->explode(['foo' => []]));
}
Add ability to nested validation rules
2022-01-19 11:52:41 -05:00
public function testConditionalRulesWithDefault()
[8.x] Add default rules in conditional rules (#38450) * Add default rules in conditional rules * formatting Co-authored-by: Taylor Otwell <taylorotwell@gmail.com>
2021-08-19 22:58:29 +02:00
{
[10.x] Add unless conditional on validation rules (#49048) * Add unless * Add tests * Formatting * Update Rule.php --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
2023-11-20 17:33:39 +02:00
$isAdmin = true;
[8.x] Add default rules in conditional rules (#38450) * Add default rules in conditional rules * formatting Co-authored-by: Taylor Otwell <taylorotwell@gmail.com>
2021-08-19 22:58:29 +02:00
$rules = ValidationRuleParser::filterConditionalRules([
[10.x] Add unless conditional on validation rules (#49048) * Add unless * Add tests * Formatting * Update Rule.php --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
2023-11-20 17:33:39 +02:00
'name' => Rule::when($isAdmin, ['required', 'min:2'], ['string', 'max:10']),
'email' => Rule::unless($isAdmin, ['required', 'min:2'], ['string', 'max:10']),
'password' => Rule::unless($isAdmin, 'required|min:2', 'string|max:10'),
'username' => ['required', Rule::when($isAdmin, ['min:2'], ['string', 'max:10'])],
'address' => ['required', Rule::unless($isAdmin, ['min:2'], ['string', 'max:10'])],
[8.x] Add default rules in conditional rules (#38450) * Add default rules in conditional rules * formatting Co-authored-by: Taylor Otwell <taylorotwell@gmail.com>
2021-08-19 22:58:29 +02:00
]);
$this->assertEquals([
'name' => ['required', 'min:2'],
'email' => ['string', 'max:10'],
'password' => ['string', 'max:10'],
'username' => ['required', 'min:2'],
'address' => ['required', 'string', 'max:10'],
], $rules);
}
[8.x] Fix bug discarding input fields with empty validation rules (#38563) * Add failing tests * Fix `ValidationRuleParser` to ignore and preserve empty rules
2021-08-26 17:16:55 -04:00
Add ability to nested validation rules
2022-01-19 11:52:41 -05:00
public function testEmptyConditionalRulesArePreserved()
[8.x] Fix bug discarding input fields with empty validation rules (#38563) * Add failing tests * Fix `ValidationRuleParser` to ignore and preserve empty rules
2021-08-26 17:16:55 -04:00
{
[10.x] Add unless conditional on validation rules (#49048) * Add unless * Add tests * Formatting * Update Rule.php --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
2023-11-20 17:33:39 +02:00
$isAdmin = true;
[8.x] Fix bug discarding input fields with empty validation rules (#38563) * Add failing tests * Fix `ValidationRuleParser` to ignore and preserve empty rules
2021-08-26 17:16:55 -04:00
$rules = ValidationRuleParser::filterConditionalRules([
[10.x] Add unless conditional on validation rules (#49048) * Add unless * Add tests * Formatting * Update Rule.php --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
2023-11-20 17:33:39 +02:00
'name' => Rule::when($isAdmin, '', ['string', 'max:10']),
'email' => Rule::unless($isAdmin, ['required', 'min:2']),
'password' => Rule::unless($isAdmin, 'required|min:2', 'string|max:10'),
[8.x] Fix bug discarding input fields with empty validation rules (#38563) * Add failing tests * Fix `ValidationRuleParser` to ignore and preserve empty rules
2021-08-26 17:16:55 -04:00
]);
$this->assertEquals([
'name' => [],
'email' => [],
'password' => ['string', 'max:10'],
], $rules);
}
Add ability to nested validation rules
2022-01-19 11:52:41 -05:00
[9.x] Method explodeExplicitRule working wrong with regex rule - Issue 45520 (#45555) * Revert #40941 changes * Fix test * Update test ensuring default behaviour * Add issue test case
2023-01-09 09:42:00 -05:00
public function testExplodeFailsParsingSingleRegexRuleContainingPipe()
[9.x] Patch regex rule parsing due to `Rule::forEach()` (#40941) * Add failing test for `forEach` validation using regex * Apply fixes from StyleCI * Wrap rule before processing and fix test case * Don't explode regex rules * Refactor determination of regex validation rule * Add more previously failing test cases * Remove unneeded elseif * Add more tests with an expected failure test * Add another test case and unify other tests * Simplify string rule parsing * formatting * Add test for flattening rule arrays of arrays Co-authored-by: James Brooks <james@alt-three.com> Co-authored-by: StyleCI Bot <bot@styleci.io> Co-authored-by: Taylor Otwell <taylor@laravel.com>
2022-02-11 09:35:03 -05:00
{
$data = ['items' => [['type' => 'foo']]];
$exploded = (new ValidationRuleParser($data))->explode(
['items.*.type' => 'regex:/^(foo|bar)$/i']
);
[9.x] Method explodeExplicitRule working wrong with regex rule - Issue 45520 (#45555) * Revert #40941 changes * Fix test * Update test ensuring default behaviour * Add issue test case
2023-01-09 09:42:00 -05:00
$this->assertSame('regex:/^(foo', $exploded->rules['items.0.type'][0]);
$this->assertSame('bar)$/i', $exploded->rules['items.0.type'][1]);
}
public function testExplodeProperlyParsesSingleRegexRuleNotContainingPipe()
{
$data = ['items' => [['type' => 'foo']]];
$exploded = (new ValidationRuleParser($data))->explode(
['items.*.type' => 'regex:/^[\d\-]*$/|max:20']
);
$this->assertSame('regex:/^[\d\-]*$/', $exploded->rules['items.0.type'][0]);
$this->assertSame('max:20', $exploded->rules['items.0.type'][1]);
[9.x] Patch regex rule parsing due to `Rule::forEach()` (#40941) * Add failing test for `forEach` validation using regex * Apply fixes from StyleCI * Wrap rule before processing and fix test case * Don't explode regex rules * Refactor determination of regex validation rule * Add more previously failing test cases * Remove unneeded elseif * Add more tests with an expected failure test * Add another test case and unify other tests * Simplify string rule parsing * formatting * Add test for flattening rule arrays of arrays Co-authored-by: James Brooks <james@alt-three.com> Co-authored-by: StyleCI Bot <bot@styleci.io> Co-authored-by: Taylor Otwell <taylor@laravel.com>
2022-02-11 09:35:03 -05:00
}
public function testExplodeProperlyParsesRegexWithArrayOfRules()
{
$data = ['items' => [['type' => 'foo']]];
$exploded = (new ValidationRuleParser($data))->explode(
['items.*.type' => ['in:foo', 'regex:/^(foo|bar)$/i']]
);
Enforce stricter assertions. (#41165)
2022-02-22 15:46:19 +01:00
$this->assertSame('in:foo', $exploded->rules['items.0.type'][0]);
$this->assertSame('regex:/^(foo|bar)$/i', $exploded->rules['items.0.type'][1]);
[9.x] Patch regex rule parsing due to `Rule::forEach()` (#40941) * Add failing test for `forEach` validation using regex * Apply fixes from StyleCI * Wrap rule before processing and fix test case * Don't explode regex rules * Refactor determination of regex validation rule * Add more previously failing test cases * Remove unneeded elseif * Add more tests with an expected failure test * Add another test case and unify other tests * Simplify string rule parsing * formatting * Add test for flattening rule arrays of arrays Co-authored-by: James Brooks <james@alt-three.com> Co-authored-by: StyleCI Bot <bot@styleci.io> Co-authored-by: Taylor Otwell <taylor@laravel.com>
2022-02-11 09:35:03 -05:00
}
public function testExplodeProperlyParsesRegexThatDoesNotContainPipe()
{
$data = ['items' => [['type' => 'foo']]];
$exploded = (new ValidationRuleParser($data))->explode(
['items.*.type' => 'in:foo|regex:/^(bar)$/i']
);
Enforce stricter assertions. (#41165)
2022-02-22 15:46:19 +01:00
$this->assertSame('in:foo', $exploded->rules['items.0.type'][0]);
$this->assertSame('regex:/^(bar)$/i', $exploded->rules['items.0.type'][1]);
[9.x] Patch regex rule parsing due to `Rule::forEach()` (#40941) * Add failing test for `forEach` validation using regex * Apply fixes from StyleCI * Wrap rule before processing and fix test case * Don't explode regex rules * Refactor determination of regex validation rule * Add more previously failing test cases * Remove unneeded elseif * Add more tests with an expected failure test * Add another test case and unify other tests * Simplify string rule parsing * formatting * Add test for flattening rule arrays of arrays Co-authored-by: James Brooks <james@alt-three.com> Co-authored-by: StyleCI Bot <bot@styleci.io> Co-authored-by: Taylor Otwell <taylor@laravel.com>
2022-02-11 09:35:03 -05:00
}
public function testExplodeFailsParsingRegexWithOtherRulesInSingleString()
{
$data = ['items' => [['type' => 'foo']]];
$exploded = (new ValidationRuleParser($data))->explode(
['items.*.type' => 'in:foo|regex:/^(foo|bar)$/i']
);
Enforce stricter assertions. (#41165)
2022-02-22 15:46:19 +01:00
$this->assertSame('in:foo', $exploded->rules['items.0.type'][0]);
$this->assertSame('regex:/^(foo', $exploded->rules['items.0.type'][1]);
$this->assertSame('bar)$/i', $exploded->rules['items.0.type'][2]);
[9.x] Patch regex rule parsing due to `Rule::forEach()` (#40941) * Add failing test for `forEach` validation using regex * Apply fixes from StyleCI * Wrap rule before processing and fix test case * Don't explode regex rules * Refactor determination of regex validation rule * Add more previously failing test cases * Remove unneeded elseif * Add more tests with an expected failure test * Add another test case and unify other tests * Simplify string rule parsing * formatting * Add test for flattening rule arrays of arrays Co-authored-by: James Brooks <james@alt-three.com> Co-authored-by: StyleCI Bot <bot@styleci.io> Co-authored-by: Taylor Otwell <taylor@laravel.com>
2022-02-11 09:35:03 -05:00
}
Add ability to nested validation rules
2022-01-19 11:52:41 -05:00
public function testExplodeGeneratesNestedRules()
{
$parser = (new ValidationRuleParser([
'users' => [
Provide context for NestedRules (#51160)
2024-04-22 18:58:19 +03:30
['name' => 'Taylor Otwell', 'email' => 'taylor@laravel.com'],
Add ability to nested validation rules
2022-01-19 11:52:41 -05:00
],
]));
$results = $parser->explode([
Provide context for NestedRules (#51160)
2024-04-22 18:58:19 +03:30
'users.*.name' => Rule::forEach(function ($value, $attribute, $data, $context) {
Enforce stricter assertions. (#41165)
2022-02-22 15:46:19 +01:00
$this->assertSame('Taylor Otwell', $value);
$this->assertSame('users.0.name', $attribute);
[13.x] Enforce stricter assertions (#59749) * Enforce stricter assertions * StyleCI fix * Fix test --------- Co-authored-by: Lucas Michot <lucas@zaiple.com>
2026-04-17 15:15:54 +02:00
$this->assertSame('Taylor Otwell', $data['users.0.name']);
Provide context for NestedRules (#51160)
2024-04-22 18:58:19 +03:30
$this->assertEquals(['name' => 'Taylor Otwell', 'email' => 'taylor@laravel.com'], $context);
Add ability to nested validation rules
2022-01-19 11:52:41 -05:00
return [Rule::requiredIf(true)];
}),
]);
$this->assertEquals(['users.0.name' => ['required']], $results->rules);
$this->assertEquals(['users.*.name' => ['users.0.name']], $results->implicitAttributes);
}
public function testExplodeGeneratesNestedRulesForNonNestedData()
{
$parser = (new ValidationRuleParser([
'name' => 'Taylor Otwell',
Provide context for NestedRules (#51160)
2024-04-22 18:58:19 +03:30
'email' => 'taylor@laravel.com',
Add ability to nested validation rules
2022-01-19 11:52:41 -05:00
]));
$results = $parser->explode([
[11.x] Test Improvements (#51365) * Test Improvements Remove warnings and deprecations from tests. Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * Update queues.yml * Update queues.yml * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * Apply fixes from StyleCI * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * Apply fixes from StyleCI * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> --------- Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> Co-authored-by: StyleCI Bot <bot@styleci.io>
2024-05-11 03:24:21 +08:00
'name' => Rule::forEach(function ($value, $attribute, $data, $context) {
Enforce stricter assertions. (#41165)
2022-02-22 15:46:19 +01:00
$this->assertSame('Taylor Otwell', $value);
$this->assertSame('name', $attribute);
Provide context for NestedRules (#51160)
2024-04-22 18:58:19 +03:30
$this->assertEquals(['name' => 'Taylor Otwell', 'email' => 'taylor@laravel.com'], $data);
$this->assertEquals(['name' => 'Taylor Otwell', 'email' => 'taylor@laravel.com'], $context);
Add ability to nested validation rules
2022-01-19 11:52:41 -05:00
return 'required';
}),
]);
$this->assertEquals(['name' => ['required']], $results->rules);
[13.x] Enforce stricter assertions (#59749) * Enforce stricter assertions * StyleCI fix * Fix test --------- Co-authored-by: Lucas Michot <lucas@zaiple.com>
2026-04-17 15:15:54 +02:00
$this->assertSame([], $results->implicitAttributes);
Add ability to nested validation rules
2022-01-19 11:52:41 -05:00
}
[10.x] Escape forward slashes when exploding wildcard rules (#48936) * Escape forward slashes when exploding wildcard rules Array keys with a forward slash '/' passed into the validator will cause a preg_match(): Unknown modifier exception if they are validated using a rule keyed with a wildcard '*' This is due to the pattern being terminated early by the existence of the '/' in the pattern variable, this same fix is also used in Validator.php * Add test * Fix for continuous integration style
2023-11-07 13:17:03 +00:00
public function testExplodeHandlesForwardSlashesInWildcardRule()
{
$parser = (new ValidationRuleParser([
'redirects' => [
'directory/subdirectory/file' => [
'directory/subdirectory/redirectedfile',
],
],
]));
$results = $parser->explode([
'redirects.directory/subdirectory/file.*' => 'string',
]);
$this->assertEquals([
'redirects.directory/subdirectory/file.0' => ['string'],
], $results->rules);
$this->assertEquals([
'redirects.directory/subdirectory/file.*' => ['redirects.directory/subdirectory/file.0'],
], $results->implicitAttributes);
}
Add ability to nested validation rules
2022-01-19 11:52:41 -05:00
public function testExplodeHandlesArraysOfNestedRules()
{
$parser = (new ValidationRuleParser([
'users' => [
['name' => 'Taylor Otwell'],
['name' => 'Abigail Otwell'],
],
]));
$results = $parser->explode([
[9.x] Patch nested array validation rule regression bug (#43897) * Remove Arr::flatten * Update tests and remove no-longer relevant tests * Add test for nested validation rules * Rename and move test * Add failing validation run * CS fix
2022-08-29 09:56:58 -04:00
'users.*.name' => Rule::forEach(function ($value, $attribute, $data) {
Apply fixes from StyleCI
2022-08-29 13:57:28 +00:00
$this->assertEquals([
'users.0.name' => 'Taylor Otwell',
'users.1.name' => 'Abigail Otwell',
], $data);
return [
Rule::requiredIf(true),
$value === 'Taylor Otwell'
? Rule::in('taylor')
: Rule::in('abigail'),
];
}),
Add ability to nested validation rules
2022-01-19 11:52:41 -05:00
]);
$this->assertEquals([
'users.0.name' => ['required', 'in:"taylor"'],
'users.1.name' => ['required', 'in:"abigail"'],
], $results->rules);
$this->assertEquals([
'users.*.name' => [
'users.0.name',
'users.1.name',
],
], $results->implicitAttributes);
}
public function testExplodeHandlesRecursivelyNestedRules()
{
$parser = (new ValidationRuleParser([
'users' => [['name' => 'Taylor Otwell']],
]));
$results = $parser->explode([
[9.x] Patch nested array validation rule regression bug (#43897) * Remove Arr::flatten * Update tests and remove no-longer relevant tests * Add test for nested validation rules * Rename and move test * Add failing validation run * CS fix
2022-08-29 09:56:58 -04:00
'users.*.name' => Rule::forEach(function ($value, $attribute, $data) {
$this->assertSame('Taylor Otwell', $value);
$this->assertSame('users.0.name', $attribute);
$this->assertEquals(['users.0.name' => 'Taylor Otwell'], $data);
return Rule::forEach(function ($value, $attribute, $data) {
$this->assertNull($value);
Enforce stricter assertions. (#41165)
2022-02-22 15:46:19 +01:00
$this->assertSame('users.0.name', $attribute);
Add ability to nested validation rules
2022-01-19 11:52:41 -05:00
$this->assertEquals(['users.0.name' => 'Taylor Otwell'], $data);
Rename `Rule::nested` to `Rule::forEach` (#40586)
2022-01-24 11:33:32 -05:00
return Rule::forEach(function ($value, $attribute, $data) {
Add ability to nested validation rules
2022-01-19 11:52:41 -05:00
$this->assertNull($value);
Enforce stricter assertions. (#41165)
2022-02-22 15:46:19 +01:00
$this->assertSame('users.0.name', $attribute);
Add ability to nested validation rules
2022-01-19 11:52:41 -05:00
$this->assertEquals(['users.0.name' => 'Taylor Otwell'], $data);
[9.x] Patch nested array validation rule regression bug (#43897) * Remove Arr::flatten * Update tests and remove no-longer relevant tests * Add test for nested validation rules * Rename and move test * Add failing validation run * CS fix
2022-08-29 09:56:58 -04:00
return [Rule::requiredIf(true)];
Add ability to nested validation rules
2022-01-19 11:52:41 -05:00
});
[9.x] Patch nested array validation rule regression bug (#43897) * Remove Arr::flatten * Update tests and remove no-longer relevant tests * Add test for nested validation rules * Rename and move test * Add failing validation run * CS fix
2022-08-29 09:56:58 -04:00
});
}),
Add ability to nested validation rules
2022-01-19 11:52:41 -05:00
]);
$this->assertEquals(['users.0.name' => ['required']], $results->rules);
$this->assertEquals(['users.*.name' => ['users.0.name']], $results->implicitAttributes);
}
public function testExplodeHandlesSegmentingNestedRules()
{
$parser = (new ValidationRuleParser([
'items' => [
['discounts' => [['id' => 1], ['id' => 2]]],
['discounts' => [['id' => 1], ['id' => 2]]],
],
]));
$rules = [
Rename `Rule::nested` to `Rule::forEach` (#40586)
2022-01-24 11:33:32 -05:00
'items.*' => Rule::forEach(function () {
Add ability to nested validation rules
2022-01-19 11:52:41 -05:00
return ['discounts.*.id' => 'distinct'];
}),
];
$results = $parser->explode($rules);
$this->assertEquals([
'items.0.discounts.0.id' => ['distinct'],
'items.0.discounts.1.id' => ['distinct'],
'items.1.discounts.0.id' => ['distinct'],
'items.1.discounts.1.id' => ['distinct'],
], $results->rules);
$this->assertEquals([
'items.1.discounts.*.id' => [
'items.1.discounts.0.id',
'items.1.discounts.1.id',
],
'items.0.discounts.*.id' => [
'items.0.discounts.0.id',
'items.0.discounts.1.id',
],
'items.*' => [
'items.0',
'items.1',
],
], $results->implicitAttributes);
}
[11.x] Fix: Handles non nested explode of multiple Date and Numeric rules in ValidationRuleParser (#54718) * fix: added condition to exit if Rule is Date or Numeric * test: added tests for new condition
2025-02-19 22:52:59 +01:00
public function testExplodeHandlesStringDateRule()
{
$parser = (new ValidationRuleParser([
'date' => '2021-01-01',
]));
$rules = [
'date' => 'date|date_format:Y-m-d',
];
$results = $parser->explode($rules);
$this->assertEquals([
'date' => [
'date',
'date_format:Y-m-d',
],
], $results->rules);
}
public function testExplodeHandlesDateRule()
{
$parser = (new ValidationRuleParser([
'date' => '2021-01-01',
]));
$rules = [
'date' => Rule::date(),
];
$results = $parser->explode($rules);
$this->assertEquals([
'date' => [
'date',
],
], $results->rules);
}
public function testExplodeHandlesDateRuleWithAdditionalRules()
{
$parser = (new ValidationRuleParser([
'date' => '2021-01-01',
]));
$rules = [
[12.x] Fixes how the fluent Date rule builder handles `date_format` (#55052) * Fixed adding a format to the fluent date rule builder * Conformed to StyleCI * Take initial rules from previous PR * Added tests for specific dates with custom date format * Update Date.php --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
2025-03-17 15:32:44 -05:00
'date' => Rule::date()->after('today'),
[11.x] Fix: Handles non nested explode of multiple Date and Numeric rules in ValidationRuleParser (#54718) * fix: added condition to exit if Rule is Date or Numeric * test: added tests for new condition
2025-02-19 22:52:59 +01:00
];
$results = $parser->explode($rules);
$this->assertEquals([
'date' => [
'date',
[12.x] Fixes how the fluent Date rule builder handles `date_format` (#55052) * Fixed adding a format to the fluent date rule builder * Conformed to StyleCI * Take initial rules from previous PR * Added tests for specific dates with custom date format * Update Date.php --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
2025-03-17 15:32:44 -05:00
'after:today',
[11.x] Fix: Handles non nested explode of multiple Date and Numeric rules in ValidationRuleParser (#54718) * fix: added condition to exit if Rule is Date or Numeric * test: added tests for new condition
2025-02-19 22:52:59 +01:00
],
], $results->rules);
}
public function testExplodeHandlesNumericStringRule()
{
$parser = (new ValidationRuleParser([
'number' => 42,
]));
$rules = [
'number' => 'numeric|max:100',
];
$results = $parser->explode($rules);
$this->assertEquals([
'number' => [
'numeric',
'max:100',
],
], $results->rules);
}
public function testExplodeHandlesNumericRule()
{
$parser = (new ValidationRuleParser([
'number' => 42,
]));
$rules = [
'number' => Rule::numeric(),
];
$results = $parser->explode($rules);
$this->assertEquals([
'number' => [
'numeric',
],
], $results->rules);
}
public function testExplodeHandlesNumericRuleWithAdditionalRules()
{
$parser = (new ValidationRuleParser([
'number' => 42,
]));
$rules = [
'number' => Rule::numeric()->max(100),
];
$results = $parser->explode($rules);
$this->assertEquals([
'number' => [
'numeric',
'max:100',
],
], $results->rules);
}
Spacing
2022-01-19 11:53:58 -05:00
}
Reference in New Issue Copy Permalink