Commit Graph

432 Commits

Author SHA1 Message Date
Onkar Khadangale
b08a792a0a fix(ci/spelling-check-bot): Argument list too long (#40494)
* fix(ci/spelling-check-bot): Argument list too long

* Update .github/workflows/spelling-check-bot.yml

Co-authored-by: Joshua Chen <sidachen2003@gmail.com>

---------

Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
2025-07-22 15:03:45 +08:00
A1lo
095408eda6 fix(ci): add GITHUB_TOKEN env for rari related commands (#40395) 2025-07-17 09:18:13 +02:00
Claas Augner
8df3915939 Revert "Bump codelytv/pr-size-labeler from 1.10.2 to 1.10.3" (#40277)
Revert "Bump codelytv/pr-size-labeler from 1.10.2 to 1.10.3 (#39686)"

This reverts commit 83b07e6bb0.
2025-07-09 16:00:27 +02:00
Claas Augner
ccb4405a58 ci(pr-rebase-needed): use branch for push concurrency group (#40108)
Previously, any push to any origin branch was cancelling any running
workflow run caused by another push, including the main branch.
2025-06-27 16:02:31 +02:00
A1lo
46a210e49d fix(pr-test): add GITHUB_TOKEN env for rari related commands (#39958) 2025-06-23 16:35:42 +02:00
Brian Smith
8ada631be9 ci(spelling-check-bot): Set 5 min timeout for spellchecker (#39889)
feat(gha): Set 5 min timeout for spellchecker
2025-06-10 17:14:08 +02:00
Brian Smith
76893e4caa feat(gh): Tidy up PR template (#39766)
* feat: tidy up PR template

* feat: tidy up PR template

* feat: tidy up PR template

* Update .github/PULL_REQUEST_TEMPLATE

Co-authored-by: Hamish Willee <hamishwillee@gmail.com>

* feat(gh): Tidy up PR template

---------

Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
2025-06-09 07:26:28 +10:00
Pranshu Khanna
a155645cd0 Update Pull Request Template (#39707)
* Update Pull Request Template

* Apply suggestions from code review

Co-authored-by: Brian Smith <brian@smith.berlin>

* Update PULL_REQUEST_TEMPLATE

---------

Co-authored-by: Pranshu Khanna <pkhanna@macbookpro.localdomain>
Co-authored-by: Brian Smith <brian@smith.berlin>
2025-05-28 14:39:32 +02:00
dependabot[bot]
83b07e6bb0 Bump codelytv/pr-size-labeler from 1.10.2 to 1.10.3 (#39686) 2025-05-26 14:24:56 +00:00
Claas Augner
a86850fb5e fix(workflows): disable cache in privileged workflows (#39547) 2025-05-16 13:46:10 +02:00
Claas Augner
690504bd33 fix(pr-review-companion): set cache-control: no-store (#39409) 2025-05-05 17:52:03 +02:00
Claas Augner
364349bc71 ci(pr-review-companion): access step outputs via env vars (#38947)
Reduces the risk of command injection.
2025-04-03 10:55:25 +02:00
Claas Augner
64f9151746 chore(CODEOWNERS): update sidebars ownership (#38946)
Sidebar changes can be approved by @mdn/core-yari-content, and don't need review by @mdn/core-dev.
2025-04-03 10:48:27 +02:00
Claas Augner
6cf778154d Lefthook nits (#38825)
* Rename lefthook config

* Disable lefthook in auto-cleanup-bot workflow

* Remove .husky/* from labeler config
2025-03-28 10:18:36 +01:00
Claas Augner
a35353e896 ci(auto-cleanup-bot): link from PR to workflow (#38699)
Co-authored-by: Brian Smith <brian@smith.berlin>
2025-03-18 19:41:51 +01:00
Claas Augner
9d52110957 ci: pass data between steps via GITHUB_OUTPUT (#38702)
Avoids unintended side-effects of using GITHUB_ENV.
2025-03-18 16:58:36 +01:00
dependabot[bot]
f01fb8f260 Bump reviewdog/action-setup from 1.3.0 to 1.3.2 (#38700) 2025-03-18 14:37:09 +00:00
Claas Augner
eaeb5c27ca ci(system-file-changes): pass if author/actor is an admin (#38610)
Prevents the system-file-changes workflow from failing, 
if both PR author and actor are admin.

Reduces noise when admins update system files, and 
reduces the chances of missing other failing workflows.
2025-03-18 14:31:43 +01:00
Onkar Khadangale
2865d3c239 ci(cspell-bot): group words by file to reduce log size (#38575)
* ci(cspell-bot): group words by file to reduce log size

* need to run yarn install now

* add cspell and other linters to dev deps, add lint:typo commands

* remove extra info from the output

* update yarn.lock

---------

Co-authored-by: Brian Smith <brian@smith.berlin>
2025-03-14 14:48:00 +01:00
Claas Augner
49c9049989 ci: remove pr-test-legacy workflow (#38611)
We no longer use it, and it's already disabled.
2025-03-13 16:58:04 +01:00
Claas Augner
6b0e2924ff ci(pr-review-companion): remove deployer (#38607) 2025-03-13 14:43:29 +01:00
Claas Augner
b26d48d6e0 ci(pr-review-companion): install in content checkout (#38605) 2025-03-13 13:45:24 +01:00
Claas Augner
1417ecb72f ci(pr-review-companion): add missing install step (#38604) 2025-03-13 13:39:08 +01:00
Claas Augner
91645f7ea3 ci(pr-review-companion): checkout content + pass BUILD_OUT_ROOT (#38603) 2025-03-13 13:31:49 +01:00
Claas Augner
60ab40f4ef ci(pr-review-companion): port analyze-pr-build script (#38595)
* chore(scripts): initial analyze-pr implementation

Ported from 9c1231f1e9/deployer/src/deployer/analyze_pr.py using GPT-o3-mini-high, and reviewed manually.

* chore(scripts/analyze-pr): add yargs

* fix(analyze-pr): fix doc.flaws check

* chore(analzye-pr): remove Deployer version log

* enhance(analyze-pr): truncate once

* enhance(analyze-pr): sort docs naturally by slug

* ci(pr-review-companion): use scripts/analyze-pr conditionally

* refactor(scripts): rename to analyze-pr-build

* fix(analyze-pr-build): await result

* chore(deps): move new dev-deps to deps

* enhance(scripts/analyze-pr-build): introduce host option

* chore(analyze-pr-build): remove unnecessary issues API call

* chore(analyze-pr-build): rename {repoName => repo}

* ci(pr-review-companion): refine step name

* ci(pr-review-companion): quote PR number

Just to be safe.
2025-03-13 13:17:18 +01:00
Brian Smith
00628b124c feat(ci): cancel concurrent jobs when checking for merge conflicts (#37954)
* feat(ci): cancel concurrent jobs when checking for merge conflicts

* Update .github/workflows/pr-rebase-needed.yml

Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>

---------

Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
Co-authored-by: Andi Pieper <apieper@mozilla.com>
2025-03-06 11:08:54 +01:00
Claas Augner
ad7bce8740 fix(workflows/pr-review-companion): exclude parent from upload (#38452)
Previously, the folder `build` was uploaded inside the target folder.
2025-03-04 19:44:04 +01:00
dependabot[bot]
b7df0a9106 Bump peter-evans/create-pull-request from 7.0.7 to 7.0.8 (#38445) 2025-03-04 14:22:32 +00:00
Claas Augner
49f47b0daa refactor(workflows/pr-review-companion): upload to GSC first (#38422) 2025-03-03 15:35:03 +01:00
Claas Augner
5e6db50170 chore(workflows/pr-review-companion): optimize GCS upload (#38419)
Switch to google-github-actions/upload-cloud-storage with optimized parameters.
2025-03-03 15:09:56 +01:00
Claas Augner
914dfdd6f2 fix(workflows/pr-review-companion): set environment on job (#38383) 2025-02-28 19:55:46 +01:00
Claas Augner
f6ab32904a fix(workflows/pr-review-companion): fix permissions (#38382) 2025-02-28 19:42:03 +01:00
Claas Augner
c2c0b6e9af fix(workflows/pr-review-companion): auth before setup (#38381) 2025-02-28 19:30:48 +01:00
Claas Augner
bd35118a85 feat(workflows/pr-review-companion): sync build to GCS as well (#38380) 2025-02-28 19:25:02 +01:00
dependabot[bot]
8129aa56df Bump peter-evans/create-pull-request from 7.0.6 to 7.0.7 (#38323) 2025-02-25 14:08:17 +00:00
Claas Augner
8e726dec3f fix(workflows): pin 3rd party actions (#38016) 2025-02-07 11:36:35 +01:00
Claas Augner
7b40f1555b fix(workflows): assign explicit permissions (#38017)
Also documents what they are used for.
2025-02-07 11:36:21 +01:00
Claas Augner
63f1774fd2 chore(workflows/pr-check): validate redirects with rari + fix only en-US (#37867)
* Revert "fix(redirects): remove locale param + validate with legacy (#37844)"

This reverts commit b8cc989f11.

* chore(workflows/pr-check_scripts): add redirect scripts

* chore: validate redirects without --strict option

* chore(workflows/pr-check_redirects): use rari for redirect check

* fixup! chore(workflows/pr-check_scripts): add redirect scripts
2025-01-30 15:28:24 +01:00
Florian Dieminger
41289e8924 fix(ci): use rari from npm (#37870) 2025-01-29 20:11:54 +01:00
Brian Smith
e70e952bb7 chore(ci): Labeler needs updating after Learn move (#37294)
* chore(ci): Update labeler following learn move, make matching coarser

* chore(ci): Update labeler following learn move, make matching coarser

* chore(ci): Update labeler following learn move, make matching coarser

* chore: restore deleted directory configs as comment

* chore: Remove learn from codeowners
2025-01-28 09:56:00 +01:00
Claas Augner
9735c454c6 fix(workflows/pr-check_redirects): validate with content:legacy (#37822)
Workaround until rari implements `validate-redirects`
2025-01-27 12:21:30 +01:00
Onkar Khadangale
19492cf232 fix(ci/reviewdog): Flag files with CRLF line endings (#37445) 2025-01-24 13:07:09 -05:00
Claas Augner
452d2ecc73 refactor(workflows): extract pr-test-legacy (#37771)
Variables are not passed to workflows that are triggered
by a pull request from a fork, so mdn/content#37766 did
not work as intended, and rari is always used for tests.

To mitigate this, we extract a new legacy test workflow,
that we can disable, or re-enable in case of rari issues.
2025-01-23 13:39:39 +01:00
Claas Augner
a2503327b6 chore(workflows/pr-test): run rari alongside legacy (#37766)
Merges `pr-test-new-ci.yml` into `pr-test.yml`, creating two jobs:

- `legacy` (without rari), which is run if `vars.TEST_LEGACY == 'true'`
- `tests` (with rari), which is run unless `vars.TEST_SKIP_RARI == 'true'`

Which job results are uploaded as artifacts depends on `vars.TEST_LEGACY` and `vars.TEST_UPLOAD_LEGACY`. If both are `'true'`, then the legacy test results are uploaded, otherwise the rari test results.
2025-01-23 13:13:57 +01:00
Claas Augner
e4a247688d fix(workflows): unwrap if conditions (#37768) 2025-01-23 10:51:28 +01:00
Florian Dieminger
c5685255b5 new-ci: add inline flaw data (#37586) 2025-01-10 10:58:41 +01:00
Florian Dieminger
c792a1398d fix(ci): fix new ci test (#37576)
render html for the preview
2025-01-09 17:51:31 +01:00
Florian Dieminger
08112b5fc2 Pr test new ci (#37572)
* feat(ci): pr-test with rari

* change name and add to preview
2025-01-09 17:05:56 +01:00
Onkar Khadangale
52131aa028 fix(ci): improve logging in the reviewdog workflow (#37292)
* fix(ci): improve logging in the reviewdog workflow

* add one line separation in logs

* Update .github/workflows/pr-check-lint_content.yml

Co-authored-by: Joshua Chen <sidachen2003@gmail.com>

---------

Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
2024-12-27 22:43:44 -05:00
Florian Dieminger
1469cc4c30 feat(rari): support for template l10n and new sidebars (#36755)
* feat(rari): support for template l10n and new sidebars

For now these are protected by the code owners but will
be opened up soon.

Co-authored-by: Andi Pieper <apieper@mozilla.com>

* feat(sidebars): support hashes

---------

Co-authored-by: Andi Pieper <apieper@mozilla.com>
2024-11-14 14:18:40 +01:00