SIGN IN SIGN UP
python / cpython UNCLAIMED

The Python programming language

0 0 451 Python

Remove redundant check from arraymodule b_getitem (GH-14676)

The `arraymodule`'s `b_getitem` function returns a `PyLong` converted 
from `arrayobject`'s array, by dereferencing a pointer to `char`.

When the `char` type is `signed char`, the `if (x >= 128) x -= 256;` comparison/code is redundant because a `signed char` will have a value of `[-128, 127]` and so `x` will never be greater or equal than 128.

This check was indeed needed for situations where a given compiler would assume `char` being `unsigned char` which would make `x` in `[0, 256]` range.

However, the check can be removed if we cast the `ob_item` into a signed char pointer (`signed char*`) instead of `char*`.

This PR/commit introduces this change.
D
Disconnect3d committed
13ab570febac64bb55fb46d866a9ba5a46ab8902
Parent: 4737265
Committed by Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> on 7/11/2019, 9:57:42 PM