Morph MORPH
SIGN IN SIGN UP
restify / node-restify UNCLAIMED

The future of Node.js REST development

0 0 49 JavaScript
Normal View History Raw
Add plugins back in
2017-05-11 12:53:16 -07:00
'use strict';
refactor(lib): forbid anonymous function in lib code (#1538)
2017-10-24 10:05:49 +02:00
/* eslint-disable func-names */
Add plugins back in
2017-05-11 12:53:16 -07:00
// core requires
fix(bodyReader): Fix memory leak (#1566) Without handling the req 'close' event, we will leak ClientRequest objects when the client suddently stops sending the request body.
2017-11-20 12:55:43 -08:00
var http = require('http');
Add plugins back in
2017-05-11 12:53:16 -07:00
// external requires
var assert = require('chai').assert;
var restify = require('../../lib/index.js');
var restifyClients = require('restify-clients');
// local files
var helper = require('../lib/helper');
// local globals
var SERVER;
var CLIENT;
var PORT;
chore(prettier): use prettier for style checking and fixing (#1537)
2017-10-31 19:29:49 +01:00
describe('body reader', function() {
describe('gzip content encoding', function() {
beforeEach(function(done) {
Add plugins back in
2017-05-11 12:53:16 -07:00
SERVER = restify.createServer({
dtrace: helper.dtrace,
log: helper.getLog('server')
});
chore(prettier): use prettier for style checking and fixing (#1537)
2017-10-31 19:29:49 +01:00
SERVER.listen(0, '127.0.0.1', function() {
Add plugins back in
2017-05-11 12:53:16 -07:00
PORT = SERVER.address().port;
done();
});
});
chore(prettier): use prettier for style checking and fixing (#1537)
2017-10-31 19:29:49 +01:00
afterEach(function(done) {
Add plugins back in
2017-05-11 12:53:16 -07:00
CLIENT.close();
SERVER.close(done);
});
chore(prettier): use prettier for style checking and fixing (#1537)
2017-10-31 19:29:49 +01:00
it('should parse gzip encoded content', function(done) {
Restructure plugin directories
2017-05-12 17:48:56 -07:00
SERVER.use(restify.plugins.bodyParser());
Add plugins back in
2017-05-11 12:53:16 -07:00
CLIENT = restifyClients.createJsonClient({
url: 'http://127.0.0.1:' + PORT,
retry: false,
gzip: {}
});
chore(prettier): use prettier for style checking and fixing (#1537)
2017-10-31 19:29:49 +01:00
SERVER.post('/compressed', function(req, res, next) {
Add plugins back in
2017-05-11 12:53:16 -07:00
assert.equal(req.body.apple, 'red');
res.send();
next();
});
chore(prettier): use prettier for style checking and fixing (#1537)
2017-10-31 19:29:49 +01:00
CLIENT.post(
'/compressed',
{
apple: 'red'
},
function(err, _, res) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
done();
}
);
Add plugins back in
2017-05-11 12:53:16 -07:00
});
chore(prettier): use prettier for style checking and fixing (#1537)
2017-10-31 19:29:49 +01:00
it('should not accept unsupported content encoding', function(done) {
Restructure plugin directories
2017-05-12 17:48:56 -07:00
SERVER.use(restify.plugins.bodyParser());
Add plugins back in
2017-05-11 12:53:16 -07:00
CLIENT = restifyClients.createJsonClient({
url: 'http://127.0.0.1:' + PORT,
retry: false,
headers: {
'content-encoding': 'unsupported'
}
});
chore(prettier): use prettier for style checking and fixing (#1537)
2017-10-31 19:29:49 +01:00
SERVER.post('/compressed', function(req, res, next) {
Add plugins back in
2017-05-11 12:53:16 -07:00
assert.equal(req.body.apple, 'red');
res.send();
next();
});
chore(prettier): use prettier for style checking and fixing (#1537)
2017-10-31 19:29:49 +01:00
CLIENT.post(
'/compressed',
{
apple: 'red'
},
function(err, _, res) {
assert.isOk(err, 'should fail');
assert.equal(res.statusCode, 415);
assert.equal(res.headers['accept-encoding'], 'gzip');
done();
}
);
Add plugins back in
2017-05-11 12:53:16 -07:00
});
chore(prettier): use prettier for style checking and fixing (#1537)
2017-10-31 19:29:49 +01:00
it('should parse unencoded content', function(done) {
Restructure plugin directories
2017-05-12 17:48:56 -07:00
SERVER.use(restify.plugins.bodyParser());
Add plugins back in
2017-05-11 12:53:16 -07:00
CLIENT = restifyClients.createJsonClient({
url: 'http://127.0.0.1:' + PORT,
retry: false
});
chore(prettier): use prettier for style checking and fixing (#1537)
2017-10-31 19:29:49 +01:00
SERVER.post('/compressed', function(req, res, next) {
Add plugins back in
2017-05-11 12:53:16 -07:00
assert.equal(req.body.apple, 'red');
res.send();
next();
});
chore(prettier): use prettier for style checking and fixing (#1537)
2017-10-31 19:29:49 +01:00
CLIENT.post(
'/compressed',
{
apple: 'red'
},
function(err, _, res) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
done();
}
);
Add plugins back in
2017-05-11 12:53:16 -07:00
});
fix(bodyReader): Fix memory leak (#1566) Without handling the req 'close' event, we will leak ClientRequest objects when the client suddently stops sending the request body.
2017-11-20 12:55:43 -08:00
it('should handle client timeout', function(done) {
SERVER.use(restify.plugins.bodyParser());
SERVER.post('/compressed', function(req, res, next) {
feat(server): new router and middleware system (#1561) BREAKING CHANGE: - Server returns `RequestCloseError` instead of `RequestAbortedError` - Non-strict routing is gone - Different `RegExp` usage in router path and wildcards - Remove already deprecated `next.ifError` - Disable DTrace probes by default - Change in calling `next` multiple times - Router versioning and content type as a separate plugin: `conditionalHandler` - After event fires when both request is flushed and the last handler is finished - Metrics plugin latency logic changes and new latencies were added For more info see the `/guides/6to7guide.md`.
2018-02-23 11:20:44 -08:00
res.send('ok');
fix(bodyReader): Fix memory leak (#1566) Without handling the req 'close' event, we will leak ClientRequest objects when the client suddently stops sending the request body.
2017-11-20 12:55:43 -08:00
next();
});
// set timeout to 100ms so test runs faster, when client stops
// sending POST data
SERVER.on('connection', function(socket) {
socket.setTimeout(100);
});
var postData = 'hello world';
var options = {
hostname: '127.0.0.1',
port: PORT,
feat(server): new router and middleware system (#1561) BREAKING CHANGE: - Server returns `RequestCloseError` instead of `RequestAbortedError` - Non-strict routing is gone - Different `RegExp` usage in router path and wildcards - Remove already deprecated `next.ifError` - Disable DTrace probes by default - Change in calling `next` multiple times - Router versioning and content type as a separate plugin: `conditionalHandler` - After event fires when both request is flushed and the last handler is finished - Metrics plugin latency logic changes and new latencies were added For more info see the `/guides/6to7guide.md`.
2018-02-23 11:20:44 -08:00
path: '/compressed?v=1',
fix(bodyReader): Fix memory leak (#1566) Without handling the req 'close' event, we will leak ClientRequest objects when the client suddently stops sending the request body.
2017-11-20 12:55:43 -08:00
method: 'POST',
headers: {
'Content-Type': 'application/json',
// report postData + 1 so that request isn't sent
'Content-Length': Buffer.byteLength(postData) + 1
}
};
var req = http.request(options, function(res) {
// should never receive a response
assert.isNotOk(res);
});
feat(server): new router and middleware system (#1561) BREAKING CHANGE: - Server returns `RequestCloseError` instead of `RequestAbortedError` - Non-strict routing is gone - Different `RegExp` usage in router path and wildcards - Remove already deprecated `next.ifError` - Disable DTrace probes by default - Change in calling `next` multiple times - Router versioning and content type as a separate plugin: `conditionalHandler` - After event fires when both request is flushed and the last handler is finished - Metrics plugin latency logic changes and new latencies were added For more info see the `/guides/6to7guide.md`.
2018-02-23 11:20:44 -08:00
SERVER.on('after', function(req2) {
if (req2.href() === '/compressed?v=2') {
assert.equal(SERVER.inflightRequests(), 0);
done();
}
});
fix(bodyReader): Fix memory leak (#1566) Without handling the req 'close' event, we will leak ClientRequest objects when the client suddently stops sending the request body.
2017-11-20 12:55:43 -08:00
// will get a req error after 100ms timeout
req.on('error', function(e) {
// make another request to verify in flight request is only 1
CLIENT = restifyClients.createJsonClient({
url: 'http://127.0.0.1:' + PORT,
retry: false
});
CLIENT.post(
feat(server): new router and middleware system (#1561) BREAKING CHANGE: - Server returns `RequestCloseError` instead of `RequestAbortedError` - Non-strict routing is gone - Different `RegExp` usage in router path and wildcards - Remove already deprecated `next.ifError` - Disable DTrace probes by default - Change in calling `next` multiple times - Router versioning and content type as a separate plugin: `conditionalHandler` - After event fires when both request is flushed and the last handler is finished - Metrics plugin latency logic changes and new latencies were added For more info see the `/guides/6to7guide.md`.
2018-02-23 11:20:44 -08:00
'/compressed?v=2',
fix(bodyReader): Fix memory leak (#1566) Without handling the req 'close' event, we will leak ClientRequest objects when the client suddently stops sending the request body.
2017-11-20 12:55:43 -08:00
{
apple: 'red'
},
function(err, _, res, obj) {
assert.ifError(err);
assert.equal(res.statusCode, 200);
}
);
});
// write data to request body, but don't req.send()
req.write(postData);
});
Add plugins back in
2017-05-11 12:53:16 -07:00
});
});
Reference in New Issue Copy Permalink