31 Commits

Author SHA1 Message Date
Norm Evangelista
2cb416222f Add more bugprone-* clang-tidy checks, Part A (#6371)
* Added more bugprone-* checks, added -DBUILD_surface_on_nurbs=ON to clang-tidy GitHub action

* Part A: Run new bugprone checks, excluding the apps subdirectories

* Fix dynamic_cast missing const

* Revert -exclude in GitHub action, add .clang-tidy in directories to exclude from checks

* Modify to avoid "no checks enabled" errors

* Repair directory-level .clang-tidy files

* Switch to use an empty Checks string

* Revert to Checks: '-*'

* Implement a minimal clang-tidy check in third-party code

* Another try to disable clang-tidy in third-party directories

* Fix forward decls flagged by clang-tidy

* Address review comments, run clang-format on whitelist

* Revert "Address review comments, run clang-format on whitelist"

This reverts commit 60a7ee4c54.

* Readdress review comments

* Use only YAML formatter on GitHub Action

* Remove redundant using statement per review

* Address Copilot code review issues

* Change to use const auto* with dynamic_cast
2025-12-21 20:23:39 +01:00
Dilkhush
aabe846c9d Update clang-tidy github action (#6116) 2024-09-15 11:30:46 +02:00
Markus Vieth
5cd00c9b30 CI: updates and improvements
- release pipeline: fix git tag of final release (was previously e.g. pcl-1.13.0-rc0, is now pcl-1.13.0). Pre-releases/release-candidates are still pcl-1.13.0-rc1
- ubuntu-variety: update available compilers
- install libboost-system-dev. While this is installed implicitly by libboost-filesystem-dev, PCL needs the `system` module, so we should install it explicitly
- install libpcap-dev, an optional dependency of PCL
- update actions/checkout to v3 (see https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/)
2023-02-28 13:43:25 +01:00
luzpaz
44670ff3f4 Fix various typos (#5523)
* Fix various typos 

Found via `codespell -q 3 -S ./CHANGES.md,./surface/src/3rdparty,./surface/include/pcl/surface/3rdparty,./recognition/include/pcl/recognition/3rdparty -L ang,bu,childs,coo,currect,frome,gool,hsi,indeces,ihs,indext,ith,lod,meshe,metre,metres,nd,opps,ot,te,vertexes`

* Update cuda/common/include/pcl/cuda/cutil.h

Co-authored-by: Markus Vieth <39675748+mvieth@users.noreply.github.com>

* Update filters/src/extract_indices.cpp

Co-authored-by: Markus Vieth <39675748+mvieth@users.noreply.github.com>

* Fix typo incorrectly introduced

* Added requested changes to svm_wrapper.cpp manually

Co-authored-by: Markus Vieth <39675748+mvieth@users.noreply.github.com>
2022-12-10 19:58:46 +01:00
Norm Evangelista
6a4d872dfd Ran clang-tidy on optional modules (#5318)
* Ran clang-tidy on apps, apps_3d_rec_framework [PCL-5304]

* Ran clang-tidy on apps_cloud_composer through apps_point_cloud_editor

* Ran clang-tidy on benchmarks through global_tests

* Fixed issues flagged by clang-format [PCL-5304]

* Fixed remaining clang-format issue [PCL-5304]

* Added first set of optional modules to clang-tidy, and fixes

* Fixed clang-tidy issues from optional modules [PCL-5304]

* Added NOLINT to work around clang-tidy issue [PCL-5304]

* Omitted apps module to test effect on clang-tidy [PCL-5304]

* Enabled apps* modules for clang-tidy

* Switched to tidy non-apps* optional modules [PCL-5304]
2022-07-13 09:13:42 +02:00
Norm Evangelista
31564ba788 Added GitHub workflows [PCL-2731] (#4636)
* Added GitHub workflows [PCL-2731]

Signed-off-by: Norm Evangelista <norm.evangelista@gmail.com>

* Revised GitHub workflow per review [PCL-2731]

Signed-off-by: Norm Evangelista <norm.evangelista@gmail.com>

* Updated workflow syntax [PCL-2731]

Signed-off-by: Norm Evangelista <norm.evangelista@gmail.com>

* Made workflow files executable [PCL-2731]

Signed-off-by: Norm Evangelista <norm.evangelista@gmail.com>

* Added single file to compile database [PCL-2731]

Signed-off-by: Norm Evangelista <norm.evangelista@gmail.com>

* Removed paths from dummy file entry [PCL-2731]

Signed-off-by: Norm Evangelista <norm.evangelista@gmail.com>

* Removed dummy compile_commands.json

Signed-off-by: Norm Evangelista <norm.evangelista@gmail.com>

* Renamed tidy-modern.yml to clang-tidy.yml per review [PCL-2731]

* Added file missing from last staging [PCL-2731]

* Updated workflow to llvm 14 [PCL-2731]

* Restored git installation to workflow [PCL-2731]

* Retained checkout while removing git install [PCL-2731]

* Changed internal action name to clang-tidy [PCL-2731]

* Switch to use LLVM's installation script [PCL-2731]

* Tried enabling WITH_OPENMP option [PCL-2731]

* Made call to clang-tidy generic [PCL-2731]

* Specified clang compiler with CMake command [PCL-2731]

* Check whether run-clang-tidy emits a usable return code [PCL-2731]

* Removed -fix, removed -DCMAKE_EXPORT_COMPILE_COMMANDS=ON [PCL-2731]

* Fixed further clang-tidy escapes [PCL-2731]
2022-07-06 09:52:00 +02:00
Markus Vieth
86afaba4f9 Improve github issue templates 2022-03-28 18:20:54 +02:00
Kunal Tyagi
97b0f0e63b Create FUNDING.yml (#4816) 2021-07-19 01:21:51 +09:00
Kunal Tyagi
acae9bf2e5 Give more time to go through the stale issues
Currently, 150 notification left. More than 200 dealt with.
2020-05-25 12:01:10 +09:00
Kunal Tyagi
e33a77aff8 Adding todo to exempt from stale-ing 2020-05-19 18:53:01 +09:00
Kunal Tyagi
51e78542a7 Merge pull request #4104 from kunaltyagi/stale-patch
[meta] Getting the stale-bot up and running again
2020-05-19 12:42:03 +09:00
Kunal Tyagi
29c8e723f3 [github] Add links for discord or SO in Create Issue (#3992) 2020-05-19 01:36:17 +02:00
Kunal Tyagi
2d52c3bf26 Update stale.yml
* not include, but exclude
* shorter message
2020-05-16 07:17:34 +09:00
Sergey Alexandrov
73724f8b8e Remove obsolete changelog generation script 2020-03-28 20:19:04 +01:00
Kunal Tyagi
91847c3c5c Removing old issue template 2020-03-12 17:16:31 +09:00
Kunal Tyagi
147caf64d0 Update issue templates (#3602)
* Update issue templates

GitHub has new issue template, and the old one is expected to be deprecated

* Update as per test PR
2020-03-12 17:11:20 +09:00
Sergey Alexandrov
da27c07270 Update stalebot config
This alternates the behavior of the stalebot in several ways:
  * Issues can now be stale. We want the bot to chase down unconfirmed
    issues abandoned by their authors. If the author has lost interest,
    why would we care?
  * Reduce timeout until issue/pr is considered stale to 1 month. One of
    the purposes of marking issues/prs as stale is to poke their authors
    to return and finish off the work. The longer we wait, the less the
    chance they are still somewhat motivated.
  * Stale issues are automatically closed after 7 days. If the author
    did not reply to the poke, close the issue soon. It can be re-opened
    anyway, if the author awakens.
  * Only "needs: author reply" and "needs: more work" labels can become
    stale. These indicate that an action from the author is needed.
2020-02-24 21:12:23 +01:00
Sérgio Agostinho
57a25c6ca8 Update issue template. 2019-06-17 15:51:14 +02:00
Sérgio Agostinho
e0f1df91a3 Add missing visualization section from the changelog generation. 2018-11-22 22:35:44 +01:00
Sérgio Agostinho
eb6769d72b Add deprecated and removal sections. Reorganized section listing. Add descriptions. 2018-10-15 10:42:14 +02:00
Sérgio Agostinho
d9698d6dbc Revise parsing of commit history to include also GitHub squash commits 2018-10-15 10:42:13 +02:00
Sérgio Agostinho
2e2a27bef5 Save start and end revisions in cache 2018-10-15 10:42:13 +02:00
Sérgio Agostinho
41efd603ee Moved file location 2018-10-15 10:42:13 +02:00
Sergio Agostinho
870acffc3a ABI compatiblity reports generation script 2018-10-12 12:35:51 +02:00
Sergey Alexandrov
d0e5d0697d Never close stale issues/prs 2018-08-26 15:39:04 -04:00
Sérgio Agostinho
4d0e09cdf5 Fixed typo and rearragend items in the issue template 2018-01-28 10:28:42 +00:00
Sergey Alexandrov
986788ff49 Temporary change daysUntilClose to 10000
As per stalebot maintainers request in https://github.com/probot/stale/issues/79
2018-01-03 19:05:59 +01:00
Sérgio Agostinho
f469a7b1ac Change Stale daysTillClose to 100 years 2017-12-21 14:01:21 +00:00
Jochen Sprickerhof
07b637303b set stale daysUntilClose to a really big number 2017-12-18 20:50:30 +01:00
Sérgio Agostinho
3c85ad9241 Stale set up 2017-12-03 19:12:44 +00:00
Victor Lamoine
cdb732e3b8 Add issue template 2016-06-19 20:15:36 +02:00