Commit Graph

  • 78f6882b6e Checked PCL_ADD_RGB; Zekrom_7780 2023-11-26 04:06:58 +05:30
  • c9b83fb277 Checked PCL_MAKE_ALIGNED_OPERATOR_NEW; Zekrom_7780 2023-11-26 04:05:28 +05:30
  • e212ce77c9 Merge pull request #5879 from mvieth/rtd_requirements Markus Vieth 2023-11-25 13:02:11 +01:00
  • 50c406455a Issue 4718 (#5851) Bhavesh Misra 2023-11-25 17:30:25 +05:30
  • f06d1fb3b4 Add sphinx-rtd-theme in doc requirements Currently, readthedocs is failing with the error: no theme named 'sphinx_rtd_theme' found (missing theme.conf?) Markus Vieth 2023-11-20 13:32:02 +01:00
  • 0d123a41de Merge pull request #5878 from mvieth/readthedocs_config Markus Vieth 2023-11-20 08:25:05 +01:00
  • c37d57804c Add readthedocs config files Readthedocs now requires special config files: https://blog.readthedocs.com/migrate-configuration-v2/ The builds on rtd have been failing since end of September because we do not have them yet. Also add a rtd batch in our main README so we notice failing builds sooner. Markus Vieth 2023-11-18 14:34:22 +01:00
  • 84aa570db9 Merge pull request #5873 from ZhuLingfeng1993/fix_nurbs Markus Vieth 2023-11-16 20:37:39 +01:00
  • 95504e6e25 Merge pull request #5867 from mvieth/voxel_grid_occlusion_estimation Markus Vieth 2023-11-15 19:35:13 +01:00
  • a2e6f54582 Fix freeze in hdl_grabber.cpp (#5826) Sun-lay Gagneux 2023-11-14 06:34:43 -05:00
  • 60549ec9b0 [surface] Speed up nurbs surface fitting zhulingfeng 2023-11-14 07:40:28 +08:00
  • b4c9758712 remove deprecated code for 1.14 release (#5872) Kyle Stewart 2023-11-13 01:49:48 -07:00
  • 190ae4120d Fix VoxelGridOcclusionEstimation tool - call Update() on vtk classes, otherwise the shown window is empty - use the filtered cloud instead of whole input cloud, otherwise processing is very slow for larger clouds - use the fixed RenderWindowInteractor Markus Vieth 2023-11-05 18:30:13 +01:00
  • 41ff06f97e VoxelGridOcclusionEstimation: fix behaviour if sensor origin is inside the voxel grid Markus Vieth 2023-11-05 18:18:38 +01:00
  • 19a8221648 Merge pull request #5869 from mvieth/macos_ci_12 Markus Vieth 2023-11-08 07:19:38 +01:00
  • 508ec6373e CI: update MacOS from 11 to 12 Markus Vieth 2023-11-07 20:24:43 +01:00
  • 81b92a50f2 Fix PCD load crashes on empty files (#5855) Rasmus 2023-10-30 21:10:52 +01:00
  • 21dcddd7c4 Merge pull request #5857 from mvieth/gp3_tparam Lars Glud 2023-10-30 21:10:04 +01:00
  • b9360ef989 GreedyProjectionTriangulation: add hint about PointInT Markus Vieth 2023-10-25 14:56:03 +02:00
  • be7a26c13c Merge pull request #5825 from mvieth/gicp_newton Markus Vieth 2023-10-25 10:40:22 +02:00
  • 3928660816 Add test for GICP with BFGS optimizer Markus Vieth 2023-10-24 19:39:29 +02:00
  • 669652b7e2 Part F of transition to support modernize-use-default-member-init (#5815) Norm Evangelista 2023-10-21 12:04:36 -07:00
  • 54a5b4a031 Merge pull request #5845 from mvieth/misc12 Markus Vieth 2023-10-19 10:09:24 +02:00
  • 1cb996a5a8 MSAC and RMSAC: fix check array distances empty (#5849) gscholer 2023-10-18 17:39:52 +08:00
  • dc7aec5d38 Let setInputCloud of search methods indicate success or failure (#5840) Markus Vieth 2023-10-16 14:43:33 +02:00
  • 2e78e75426 Add checks for valid radius and max_results in gpu/features Fixes https://github.com/PointCloudLibrary/pcl/issues/5844 Markus Vieth 2023-10-14 17:32:40 +02:00
  • 7c81724196 Reduce number of allocations, for example for kdtree searches KdTree calls vectorize for every point. Before this commit, vectorize unnecessarily allocated and freed memory for evey call. Markus Vieth 2023-10-12 19:59:41 +02:00
  • 5e640dd0c2 Improve logging Markus Vieth 2023-10-12 17:22:57 +02:00
  • 2c32f359fe Fix maybe-uninitialized warnings by checking function results Markus Vieth 2023-10-12 16:12:13 +02:00
  • 55b57aee32 Replace io functions based on VTK with PCL-native functions This is a first step to make the io module not depend on VTK any more Markus Vieth 2023-10-12 15:27:14 +02:00
  • 9a12d817b9 Improve documentations/tutorials Markus Vieth 2023-10-12 15:19:51 +02:00
  • c6e36040d1 Fix problem when building against Eigen master See also f2984cd077 Markus Vieth 2023-10-12 15:10:42 +02:00
  • e2055de297 Update CI versions Update to MacOS 13, update README badges, update compiler versions for ubuntu-variety Markus Vieth 2023-10-12 15:03:15 +02:00
  • 69e645c946 Merge pull request #5832 from ZhuLingfeng1993/fix-poisson-reconstruntcion-memory-leak-bug Markus Vieth 2023-10-05 20:45:40 +02:00
  • 0e0a942cfa [surface] Fix memory leak bug of poisson reconstruction zhulingfeng 2023-10-03 16:22:44 +08:00
  • 86e89c2f5e Fix GICP6D test M_PI/0.1 would mean 10*M_PI or 5 times 360 degrees. GICP can't reliably find the correct solution for such large rotations (it might e.g. align the object upside down). When using 0.25*M_PI (45 degrees), the transformation is the correct one, and we can even tighten the error threshold to 1e-4 Markus Vieth 2023-09-25 11:20:32 +02:00
  • 180b6e0e4a GICP: add Newton optimizer (as new default) It replaces the current BFGS optimizer, which is still available via useBFGS. The Newton optimizer uses the hessian matrix of the function, while BFGS only computes an approximation of the hessian. In direct comparison (same GICP cost function to minimize and same starting point/same initial transformation), the Newton optimizer (estimateRigidTransformationNewton) takes only about one third of the time needed by the BFGS optimizer (estimateRigidTransformationBFGS). Every time, the Newton optimizer finds a slightly better transformation (lower cost) than the BFGS optimizer. Note: GICP.align() as a whole becomes only a bit faster (not 3x faster) because it also spends time on nearest-neighbour search. Even in very difficult situations, e.g. when both point clouds are far away from the origin meaning even a small rotation change results in a large point-to-point distance change, the Newton optimizer still finds a good solution, while the BFGS optimizer often fails completely. Markus Vieth 2023-09-23 16:36:33 +02:00
  • 9aa1336748 Merge pull request #5824 from javierBarandiaran/sac_model_random_seed Markus Vieth 2023-10-02 16:42:31 +02:00
  • d8127858c5 Some improvements to gpu/segmentation (#5813) Markus Vieth 2023-09-30 20:52:59 +02:00
  • b66f8b875b Merge pull request #5818 from themightyoarfish/organized-neihgbour-doc Markus Vieth 2023-09-27 13:42:32 +02:00
  • 8c0230c43c Replace std::time with std::random_device as seed for random number generator javierBarandiaran 2023-09-23 20:05:31 +02:00
  • 7cc21f7c64 Merge pull request #5821 from gaishunhua/master Markus Vieth 2023-09-23 15:12:53 +02:00
  • eccb2d124c Merge pull request #1 from gaishunhua/gaishunhua-patch-1 gaishunhua 2023-09-22 16:15:58 +08:00
  • 8662c13fc7 Update sac_model_cylinder.hpp gaishunhua 2023-09-22 16:07:16 +08:00
  • b5ce8f5ff3 Update pipeline to newer docker images. (#5807) Lars Glud 2023-09-21 13:23:55 +02:00
  • 77c628fba2 update doc for OrganizedNeighnor Rasmus Diederichsen 2023-09-21 12:54:02 +02:00
  • 90fda41b5e Merge pull request #5812 from mvieth/missing_cassert_include Markus Vieth 2023-09-15 11:54:21 +02:00
  • 9c2b0888a2 Add missing cassert include Markus Vieth 2023-09-14 21:43:39 +02:00
  • 3f3b74fe8d Merge pull request #5810 from mvieth/boost_1_83 Markus Vieth 2023-09-13 16:56:01 +02:00
  • e681e83cb6 Allow compilation with Boost 1.83 Markus Vieth 2023-09-13 09:42:43 +02:00
  • f3e615dd40 Merge pull request #5799 from larshg/update_docker Lars Glud 2023-09-12 09:18:17 +02:00
  • c2d850f20f Remove 18.04 as its EOL. Added 23.04 as newest. = 2023-09-05 08:15:43 +02:00
  • f2492bd65c Merge pull request #5796 from mvieth/deprecate_stick_model Markus Vieth 2023-09-04 09:40:09 +02:00
  • 6ae8c8844e Deprecate SampleConsensusModelStick Fixes https://github.com/PointCloudLibrary/pcl/issues/2452 Markus Vieth 2023-09-02 15:23:06 +02:00
  • 11a6627eb0 Merge pull request #5795 from mvieth/deprecate_crfnormalsegmentation Markus Vieth 2023-09-02 14:59:51 +02:00
  • 1b5f84e96a Deprecate CrfNormalSegmentation It is not implemented and does not do anything useful. Users should be warned so they do not attempt to use it. Markus Vieth 2023-09-02 12:08:58 +02:00
  • aab340f393 Improve optimizeModelCoefficients for cone, cylinder, sphere models (#5790) Markus Vieth 2023-09-02 07:53:35 +02:00
  • 969d5d39b8 Part E of transition to support modernize-use-default-member-init (#5782) Norm Evangelista 2023-08-31 05:21:26 -07:00
  • 14b7b72d6c Merge pull request #5793 from mvieth/fix_eigen_overaligned_cxx17 Markus Vieth 2023-08-27 15:40:14 +02:00
  • 3c77869e95 Fix Eigen alignment problem when user project is compiled as C++17 or newer Markus Vieth 2023-08-25 14:02:03 +02:00
  • c96248bdab Merge pull request #5792 from daohu527/master Markus Vieth 2023-08-25 13:29:43 +02:00
  • cb33bf7b6f Improve PPFRegistration (#5767) Markus Vieth 2023-08-24 09:20:25 +02:00
  • 1f73950034 fix: remove unnecessary indices erase in extract_clusters daohu527 2023-08-21 19:17:10 +08:00
  • b520a83118 Modify FlannSearch to return Indices of Point Cloud (issue #5774) (#5780) Tiago Gaspar Oliveira 2023-08-13 09:36:48 +01:00
  • 3ed96c246e fix build with GNU13 and Eigen3.4 (#5783) daizhirui 2023-08-09 00:41:36 -07:00
  • 4bdf8d9f08 Merge pull request #5684 from dg0yt/opennurbs-zlib Markus Vieth 2023-08-07 21:36:19 +02:00
  • 97ef1b7239 Merge pull request #5775 from mvieth/normal3d_dynamic_omp Markus Vieth 2023-08-07 14:24:46 +02:00
  • de6d7151d4 Merge pull request #5769 from mvieth/boxclipper3d Markus Vieth 2023-08-03 13:57:50 +02:00
  • 233bec8f52 Merge pull request #5777 from mvieth/qt6_apps_includes Markus Vieth 2023-08-01 14:01:00 +02:00
  • 244da6ebdd Add missing includes in cloud composer app Markus Vieth 2023-08-01 10:06:55 +02:00
  • d5ebc2eef0 Merge pull request #5766 from mvieth/ply_origin_orientation Lars Glud 2023-07-31 22:35:06 +02:00
  • be05749615 NormalEstimationOMP: use dynamic scheduling for faster computation So far, no scheduling was specified, which seems to result in a behaviour similar to static scheduling. However, this is suboptimal, as the workload is not balanced well between the threads, especially when using radius search. With dynamic scheduling (default chunk size of 256), the speedup (ratio of computation time of NormalEstimation and NormalEstimationOMP) is better. The speedup for organized datasets is slightly higher than for unorganized datasets, possibly because FLANN (used for unorganized datasets) already uses some parallelization, while OrganizedNeighbor does not. Markus Vieth 2023-07-30 16:55:22 +02:00
  • 3eabe5a772 Merge pull request #5772 from mvieth/flann_optional Markus Vieth 2023-07-29 11:28:26 +02:00
  • 680c9a788c Make Flann optional Fixes https://github.com/PointCloudLibrary/pcl/issues/5654 cmake prints a warning if Flann is not found PCL modules that can be built without Flann: common, octree, geometry, io, ml, stereo, tools Markus Vieth 2023-07-28 11:02:59 +02:00
  • dda590cfd1 Fix behaviour of BoxClipper3D The constructor (as well as the setTransformation function) that takes a rotation, translation, and scaling as input, says in the documentation that theses transformations are applied to the box. But actually they are applied to the points. This commit changes the behaviour of the code to match the documentation. I considered changing the documentation to match the behaviour of the code, but - in my opinion it is useful to have a constructor/function to describe the box (rotation, box center, box dimensions) - the current code (which applies first scaling, then rotation, then translation to the points) is not very useful or intuitive. Imagine for example a box, one side twice as long as the others, and rotated by 45 degrees around some axis. Then it is impossible to find a scaling transformation and rotation to transform all points inside the box to the interval [-1; +1]³, considering the scaling is applied first and in each axis separately. It would always result in a parallelepiped. - if one specifically wants to rotate/translate/whatever the points, it is easy to do so by using the constructor/function that takes an Affine3f and construct for example Eigen::Affine3f transform=Eigen::Translation3f(...)*Eigen::AngleAxisf(..., Eigen::Vector3f(...).normalized()); Markus Vieth 2023-07-22 15:34:56 +02:00
  • 11bcfa7ac4 Merge pull request #5764 from mvieth/mls_reduce_nr_of_instantiations Markus Vieth 2023-07-22 12:09:38 +02:00
  • e72ec76b6d Correct doxygen in ply_io.h Markus Vieth 2023-07-21 10:32:27 +02:00
  • c577fbe7b4 Merge pull request #5765 from mvieth/remove_unnecessary_instantiation Markus Vieth 2023-07-20 21:17:30 +02:00
  • 04906b4f5e Fix reading of origin and orientation from PLY files origin_ and orientation_ are set inside the parse function (if the PLY file contains the information). Afterwards, the values have to be transferred to origin and orientation (the output parameters) Markus Vieth 2023-07-19 10:18:14 +02:00
  • 27198225dc Remove unnecessary pseudo-instantiations of checkCoordinateSystem Reduces the compile time of PCL, see also https://github.com/PointCloudLibrary/pcl/pull/4788 Markus Vieth 2023-07-17 14:18:14 +02:00
  • 6bb70d68ca Clarify expected speedup with NormalEstimationOMP (#5721) Alessio Stella 2023-07-17 10:42:07 +02:00
  • 0bc2f2cc36 MovingLeastSquares: reduce the number of instantiations to reduce compile time PCL_XYZ_POINT_TYPES currently contains 18 types, so previously, MLS was instantiated for 18*18=324 different type combinations. However, among those were instantiations which are likely used by nobody (like pcl::MovingLeastSquares<pcl::PointWithRange, pcl::PointDEM>). With these changes, MLS is only instantiated 6*6+(18-6)=48 times. The most common type combinations should be covered, but if someone uses an uncommon combinations, they have to add #define PCL_NO_PRECOMPILE before including pcl/surface/mls.h to avoid linker errors. Markus Vieth 2023-07-15 15:49:25 +02:00
  • b268d07d9f Part D of transition to support modernize-use-default-member-init (#5738) Norm Evangelista 2023-07-13 07:19:04 -07:00
  • c6fb0d7c48 Eigen: switch to imported modules and NO_MODULE (#5613) Patrick Scheckenbach 2023-07-13 10:14:51 +02:00
  • 79e6ccd7a8 Merge pull request #5755 from themightyoarfish/remove-icp-rotation-epsilon Lars Glud 2023-07-07 22:47:48 +02:00
  • 7a70069129 ApproximateProgressiveMorphologicalFilter: check for finite-ness (#5756) Markus Vieth 2023-07-07 14:09:05 +02:00
  • e1b34f7b4a ICP: remove possibly inappropriate default setting of rotation convergence threshold when user does not set it. Rasmus Diederichsen 2023-07-02 10:11:42 +02:00
  • 6c23c85438 Merge pull request #5747 from mvieth/misc11 Lars Glud 2023-06-16 12:29:16 +02:00
  • cf46790f4e Make OpenMP available in downstream projects (#5744) Markus Vieth 2023-06-12 15:20:26 +02:00
  • 8fb956d28a Improve doc and tutorials - fix broken links - add missing include in tutorial - change find_package(PCL ...) call to search for all components, instead of only two components. This is easier and less error-prone for CMake beginners, who may copy the command without fully understanding it, and later wonder why link errors appear when they use classes from other modules. The tutorial later also shows how to request some components only. Markus Vieth 2023-06-11 16:01:53 +02:00
  • 053995b7ed Small fixes and code improvements - in PCLPointCloud2.h, a cast is necessary, otherwise the elements are printed as characters instead of numbers - in setNumberOfThreads, add debug output/warning if OpenMP is not available - resize is more efficient than substr - implicit_shape_model.hpp: move peak_counter increment inside if-statement. This does not change much in practice because all of the peak_densities are larger than -1.0, but it silences the warning that strongest_peak may be uninitialized - region_growing.hpp and region_growing_rgb.hpp: switch range-for-loop, while also fixing bug (i_point was used in nearestKSearch, but point_index should have been used instead) - pcl_visualizer.hpp: make sure that point and normals are finite, otherwise VTK displays strange things Markus Vieth 2023-06-11 11:56:23 +02:00
  • 956f89c72c Merge pull request #4901 from al-tu/no-more-typeid-its-constexpr Markus Vieth 2023-06-11 09:59:16 +02:00
  • 14caf35822 Ubuntu variety: update available package version Markus Vieth 2023-06-10 11:17:23 +02:00
  • f0c7c46e82 Merge pull request #5729 from mvieth/organized_search_checks Markus Vieth 2023-06-07 13:06:39 +02:00
  • 68904fc025 function computeCentroidAndOBB (#5690) Alessio Stella 2023-06-01 12:09:54 +02:00
  • 4d8f60706c Part C of transition to support modernize-use-default-member-init (#5722) Norm Evangelista 2023-05-30 03:13:16 -07:00
  • c1581718ea OrganizedNeighbor: add additional check to make sure the cloud is suitable Markus Vieth 2023-05-29 13:12:49 +02:00
  • 28e75bfb86 Update includes per new rule. Lars Glud 2023-05-26 13:21:28 +02:00
  • dd07da01df Add SortIncludes: CaseInsensitive, so includes get sorted alphetically without considering lower/upper case. Lars Glud 2023-05-26 09:00:29 +02:00
  • 6356e1b5ae Merge pull request #5653 from mvieth/octree_growing Markus Vieth 2023-05-24 11:23:03 +02:00