mirror of
https://github.com/apache/airflow.git
synced 2026-03-27 19:31:27 +00:00
3442d811cf
The pre-commit is a fantastic tool, and we heavily used it for years, but generally the tool stagnated and is not showing a sign of adapting to our needs. For years we tried to convince pre-commit maintainers that things like autocomplete are necessary - but it met with pretty much resistance (if not hostility) from the maintainer. Also there was no chance for them to accept expectations of bigger projects like ours, where we have a huge monorepo and not only multiple needs but also different parts of the repo needing different language support (golang, typescript soon) - and apparenty the maintainer of pre-commit does not think monorepo is a good thing at all. Similarly - they did not recognize the raise of `uv` and the only way to use `uv` with pre-commit is to patch it by installing `pre-comit-uv` that essentialy patches pre-commit with uv support. This is not really sustainable and the tool lags behind many of our needs. Luckily - we have new project in town - prek - which rewrites pre-commit that is 100% compatible (now), 10x faster (because rust), uses `uv` natively, supports auto-complete already and they have very friendly maintainer who is not only supporting us but also very happily works on improving `prek` to close all the gaps, and plans to implement (with our support of course and cooperation) monorepo support - that will allow us to modularise our pre-commits. This PR switches our pre-commit support to use prek exclusively: * breeze static checks command is completely removed * custom auto-complete code in breeze as well * instructions are updated to setup prek instead of precommit * CI is updated to run prek instead of pre-commmit * documentation for static checks is reviewed and new features that prek enables are added
40 lines
1.4 KiB
YAML
40 lines
1.4 KiB
YAML
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
---
|
|
|
|
# Reference: https://www.gitpod.io/docs/references/gitpod-yml
|
|
# Docs: https://www.gitpod.io/docs/config-gitpod-file/
|
|
|
|
# default "gitpod/workspace-full" python version > 3.11
|
|
image: gitpod/workspace-python-3.11
|
|
|
|
tasks:
|
|
- init: ./scripts/ci/install_breeze.sh
|
|
- name: Install prek
|
|
openMode: split-right
|
|
command: |
|
|
printf '%s\n' "export PIP_USER=no" >> "$HOME/.bashrc"
|
|
source "$HOME/.bashrc"
|
|
pip install prek
|
|
prek install
|
|
echo "for running integration test with breeze"
|
|
|
|
# Ports to expose on workspace startup
|
|
ports:
|
|
- port: 8000
|
|
onOpen: open-preview
|